From nectar@nectar.com Sat May  1 17:10:02 1999
Return-Path: <nectar@nectar.com>
Received: from sakaki.communique.net (sakaki.communique.net [204.27.64.202])
	by hub.freebsd.org (Postfix) with ESMTP id 8F72815289
	for <FreeBSD-gnats-submit@freebsd.org>; Sat,  1 May 1999 17:10:01 -0700 (PDT)
	(envelope-from nectar@nectar.com)
Received: from cerebus.nectar.com (nectar-gw.nectar.com [204.0.249.101])
	by sakaki.communique.net (8.8.8/8.8.8) with ESMTP id TAA21735
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 1 May 1999 19:10:00 -0500 (CDT)
Received: from spawn.nectar.com (spawn.nectar.com [10.0.0.101])
	by cerebus.nectar.com (Postfix) with ESMTP id 5C41422
	for <FreeBSD-gnats-submit@freebsd.org>; Sat,  1 May 1999 19:10:00 -0500 (CDT)
Received: by spawn.nectar.com (Postfix, from userid 1001)
	id 2BFFC1DC5; Sat,  1 May 1999 19:09:34 -0500 (CDT)
Message-Id: <19990502000934.2BFFC1DC5@spawn.nectar.com>
Date: Sat,  1 May 1999 19:09:34 -0500 (CDT)
From: nectar@nectar.com
Reply-To: nectar@nectar.com
To: FreeBSD-gnats-submit@freebsd.org
Subject: dump munges device names greater than 16 bytes in /etc/dumpdates
X-Send-Pr-Version: 3.2

>Number:         11433
>Category:       bin
>Synopsis:       dump munges device names greater than 16 bytes in /etc/dumpdates
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat May  1 17:20:00 PDT 1999
>Closed-Date:    Sun May 9 21:31:23 PDT 1999
>Last-Modified:  Tue Nov 27 18:30:28 PST 2001
>Originator:     Jacques Vidrine
>Release:        FreeBSD 3.1-STABLE i386
>Organization:
None
>Environment:

	All versions of FreeBSD

>Description:

	When reading or updating /etc/dumpdates, dump will truncate
	device names (the first column) longer than 16 bytes.  This
	was discovered while dumping vinum volumes, which may have
	long names such as /dev/vinum/rpackages.

>How-To-Repeat:

	``dump -u'' with a device that has a name longer than 16
	bytes.

>Fix:

	Increasing the size to 32 bytes was sufficient for this 
	site.
	
Index: dumprestore.h
===================================================================
RCS file: /home/ncvs/src/include/protocols/dumprestore.h,v
retrieving revision 1.5
diff -u -u -r1.5 dumprestore.h
--- dumprestore.h	1998/10/27 04:01:19	1.5
+++ dumprestore.h	1999/05/01 23:57:45
@@ -105,8 +105,8 @@
 #define DR_NEWHEADER	0x0001	/* new format tape header */
 #define DR_NEWINODEFMT	0x0002	/* new format inodes on tape */
 
-#define	DUMPOUTFMT	"%-16s %c %s"		/* for printf */
+#define	DUMPOUTFMT	"%-32s %c %s"		/* for printf */
 						/* name, level, ctime(date) */
-#define	DUMPINFMT	"%16s %c %[^\n]\n"	/* inverse for scanf */
+#define	DUMPINFMT	"%32s %c %[^\n]\n"	/* inverse for scanf */
 
 #endif /* !_DUMPRESTORE_H_ */



>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: nectar 
State-Changed-When: Sun May 9 21:31:23 PDT 1999 
State-Changed-Why:  
/etc/dumpdates format was changed to allow 32 bytes for the raw 
device name.  The revisions were: 
src/include/protocols/dumprestore.h 1.6     (CURRENT) 
src/include/protocols/dumprestore.h 1.5.2.1 (STABLE) 
>Unformatted:
