From dmitri@dma.org.ru  Sat Mar 24 23:02:01 2007
Return-Path: <dmitri@dma.org.ru>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 266F616A401
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 24 Mar 2007 23:02:01 +0000 (UTC)
	(envelope-from dmitri@dma.org.ru)
Received: from dma.org.ru (dma.org.ru [82.146.56.105])
	by mx1.freebsd.org (Postfix) with ESMTP id 35A4C13C489
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 24 Mar 2007 23:01:55 +0000 (UTC)
	(envelope-from dmitri@dma.org.ru)
Received: (from dmitri@localhost)
	by dma.org.ru (8.14.0/8.13.8) id l2N9fX1h089061;
	Fri, 23 Mar 2007 12:41:33 +0300 (MSK)
	(envelope-from dmitri)
Message-Id: <200703230941.l2N9fX1h089061@dma.org.ru>
Date: Fri, 23 Mar 2007 12:41:33 +0300 (MSK)
From: Dmitri Alenitchev <dmitri@dworlds.ru>
Reply-To: Dmitri Alenitchev <dmitri@dworlds.ru>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [patch] ftpd(8): don't advertise version by default
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         110779
>Category:       bin
>Synopsis:       [patch] ftpd(8): don't advertise version by default
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Mar 24 23:10:05 GMT 2007
>Closed-Date:    Sun Mar 25 12:43:27 GMT 2007
>Last-Modified:  Sun Mar 25 12:43:27 GMT 2007
>Originator:     Dmitri Alenitchev
>Release:        FreeBSD 6.2-STABLE i386
>Organization:
Digital Worlds J.S.C.
>Environment:
System: FreeBSD dma.org.ru 6.2-STABLE FreeBSD 6.2-STABLE #0: Mon Feb 5 04:50:06 CET 2007 root@dione.ispsystem.net:/root/src/sys/i386/compile/ISPSYSTEM_SMP i386


	
>Description:
	do not advertise version in the ftp banner, because there is no reason to
>How-To-Repeat:
	
>Fix:

	

--- ftpd.diff begins here ---
Index: ftpd.c
===================================================================
RCS file: /home/ncvs/src/libexec/ftpd/ftpd.c,v
retrieving revision 1.211
diff -u -r1.211 ftpd.c
--- ftpd.c	9 Feb 2007 17:18:39 -0000	1.211
+++ ftpd.c	23 Mar 2007 09:11:46 -0000
@@ -102,7 +102,6 @@
 
 #include <stdarg.h>
 
-static char version[] = "Version 6.00LS";
 #undef main
 
 extern	off_t restart_point;
@@ -641,7 +640,7 @@
 	hostname[MAXHOSTNAMELEN - 1] = '\0';
 #endif
 	if (hostinfo)
-		reply(220, "%s FTP server (%s) ready.", hostname, version);
+		reply(220, "%s FTP server ready.", hostname);
 	else
 		reply(220, "FTP server ready.");
 	for (;;)
@@ -2370,7 +2369,6 @@
 
 	if (hostinfo) {
 		lreply(211, "%s FTP server status:", hostname);
-		printf("     %s\r\n", version);
 	} else
 		lreply(211, "FTP server status:");
 	printf("     Connected to %s", remotehost);
--- ftpd.diff ends here ---


>Release-Note:
>Audit-Trail:

From: Maxim Konovalov <maxim@macomnet.ru>
To: Dmitri Alenitchev <dmitri@dworlds.ru>
Cc: bug-followup@freebsd.org
Subject: Re: bin/110779: [patch] ftpd(8): don't advertise version by default
Date: Sun, 25 Mar 2007 03:24:49 +0400 (MSD)

 On Fri, 23 Mar 2007, 12:41+0300, Dmitri Alenitchev wrote:
 
 >
 > >Number:         110779
 > >Category:       bin
 > >Synopsis:       [patch] ftpd(8): don't advertise version by default
 > >Confidential:   no
 > >Severity:       non-critical
 > >Priority:       low
 > >Responsible:    freebsd-bugs
 > >State:          open
 > >Quarter:
 > >Keywords:
 > >Date-Required:
 > >Class:          change-request
 > >Submitter-Id:   current-users
 > >Arrival-Date:   Sat Mar 24 23:10:05 GMT 2007
 > >Closed-Date:
 > >Last-Modified:
 > >Originator:     Dmitri Alenitchev
 > >Release:        FreeBSD 6.2-STABLE i386
 > >Organization:
 > Digital Worlds J.S.C.
 > >Environment:
 > System: FreeBSD dma.org.ru 6.2-STABLE FreeBSD 6.2-STABLE #0: Mon Feb 5 04:50:06 CET 2007 root@dione.ispsystem.net:/root/src/sys/i386/compile/ISPSYSTEM_SMP i386
 >
 >
 >
 > >Description:
 
 > 	do not advertise version in the ftp banner, because there is
 > 	no reason to
 [...]
 
 It's not clear why you submit this patch again after Remko closed your
 previous PR.
 
 Moreover, did you try ftpd's -h flag?
 
 -- 
 Maxim Konovalov

From: "Dmitri Alenitchev" <dmitri@dworlds.ru>
To: "Maxim Konovalov" <maxim@macomnet.ru>
Cc: bug-followup@freebsd.org
Subject: Re: bin/110779: [patch] ftpd(8): don't advertise version by default
Date: Sun, 25 Mar 2007 05:12:34 +0300

 Maxim Konovalov wrote:
 > On Fri, 23 Mar 2007, 12:41+0300, Dmitri Alenitchev wrote:
 >
 > >
 > > >Number:         110779
 > > >Category:       bin
 > > >Synopsis:       [patch] ftpd(8): don't advertise version by default
 > > >Confidential:   no
 > > >Severity:       non-critical
 > > >Priority:       low
 > > >Responsible:    freebsd-bugs
 > > >State:          open
 > > >Quarter:
 > > >Keywords:
 > > >Date-Required:
 > > >Class:          change-request
 > > >Submitter-Id:   current-users
 > > >Arrival-Date:   Sat Mar 24 23:10:05 GMT 2007
 > > >Closed-Date:
 > > >Last-Modified:
 > > >Originator:     Dmitri Alenitchev
 > > >Release:        FreeBSD 6.2-STABLE i386
 > > >Organization:
 > > Digital Worlds J.S.C.
 > > >Environment:
 > > System: FreeBSD dma.org.ru 6.2-STABLE FreeBSD 6.2-STABLE #0: Mon Feb 5 04:50:06 CET 2007 root@dione.ispsystem.net:/root/src/sys/i386/compile/ISPSYSTEM_SMP i386
 > >
 > >
 > >
 > > >Description:
 >
 > >       do not advertise version in the ftp banner, because there is
 > >       no reason to
 > [...]
 >
 > It's not clear why you submit this patch again after Remko closed your
 > previous PR.
 
 I'm sorry. When i try to send this PR, mx1.freebsd.org don't get my mail
 for FreeBSD-gnats-submit@freebsd.org. Looks like, it was bug with
 my mail system settings. And this PR come twice.
 
 > Moreover, did you try ftpd's -h flag?
 
 Of course. I always use -h flag.

From: Maxim Konovalov <maxim@macomnet.ru>
To: Dmitri Alenitchev <dmitri@dworlds.ru>
Cc: bug-followup@freebsd.org
Subject: Re: bin/110779: [patch] ftpd(8): don't advertise version by default
Date: Sun, 25 Mar 2007 12:44:50 +0400 (MSD)

 > > Moreover, did you try ftpd's -h flag?
 >
 > Of course. I always use -h flag.
 
 So, what's the problem?  With -h ftpd does not show "host-specific
 information, such as the server software version or hostname, in
 server messages".
 
 -- 
 Maxim Konovalov

From: "Dmitri Alenitchev" <dmitri@dworlds.ru>
To: "Maxim Konovalov" <maxim@macomnet.ru>
Cc: bug-followup@freebsd.org
Subject: Re: bin/110779: [patch] ftpd(8): don't advertise version by default
Date: Sun, 25 Mar 2007 13:31:09 +0400

 Maxim Konovalov wrote:
 > > > Moreover, did you try ftpd's -h flag?
 > >
 > > Of course. I always use -h flag.
 >
 > So, what's the problem?  With -h ftpd does not show "host-specific
 > information, such as the server software version or hostname, in
 > server messages".
 
 Not problem, just paranoia.
State-Changed-From-To: open->closed 
State-Changed-By: maxim 
State-Changed-When: Sun Mar 25 12:42:37 UTC 2007 
State-Changed-Why:  
ftpd -h hides host specific information quite well. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=110779 
>Unformatted:
