From nobody@FreeBSD.org  Sun Mar 11 04:43:32 2007
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 847D616A41F
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 11 Mar 2007 04:43:32 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [69.147.83.33])
	by mx1.freebsd.org (Postfix) with ESMTP id 7392C13C4A7
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 11 Mar 2007 04:43:32 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id l2B4hWmA064141
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 11 Mar 2007 04:43:32 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id l2B4hWW5064140;
	Sun, 11 Mar 2007 04:43:32 GMT
	(envelope-from nobody)
Message-Id: <200703110443.l2B4hWW5064140@www.freebsd.org>
Date: Sun, 11 Mar 2007 04:43:32 GMT
From: Alex Kozlov<spam@rm-rf.kiev.ua>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] Fix handling of -n option in /sbin/mdmfs
X-Send-Pr-Version: www-3.0

>Number:         110178
>Category:       bin
>Synopsis:       [patch] Fix handling of -n option in mdmfs(8)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    remko
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Mar 11 04:50:03 GMT 2007
>Closed-Date:    Sat Jul 07 11:31:16 GMT 2007
>Last-Modified:  Sat Jul 07 11:31:16 GMT 2007
>Originator:     Alex Kozlov
>Release:        FreeBSD 6.2
>Organization:
private
>Environment:
>Description:
mdmfs describes -n option as 'rotational-positions' but in newfs it means
'do not create a .snap directory'
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

--- mdmfs.c
+++ mdmfs.c.new
@@ -127,7 +127,7 @@
 	}
 
 	while ((ch = getopt(argc, argv,
-	    "a:b:Cc:Dd:E:e:F:f:hi:LlMm:Nn:O:o:Pp:Ss:t:Uv:w:X")) != -1)
+	    "a:b:Cc:Dd:E:e:F:f:hi:LlMm:NnO:o:Pp:Ss:t:Uv:w:X")) != -1)
 		switch (ch) {
 		case 'a':
 			argappend(&newfs_arg, "-a %s", optarg);
@@ -188,7 +188,7 @@
 			norun = true;
 			break;
 		case 'n':
-			argappend(&newfs_arg, "-n %s", optarg);
+			argappend(&newfs_arg, "-n");
 			break;
 		case 'O':
 			argappend(&newfs_arg, "-o %s", optarg);
@@ -655,10 +655,10 @@
 {
 
 	fprintf(stderr,
-"usage: %s [-DLlMNPSUX] [-a maxcontig] [-b block-size]\n"
+"usage: %s [-DLlMNnPSUX] [-a maxcontig] [-b block-size]\n"
 "\t[-c blocks-per-cylinder-group][-d max-extent-size] [-E path-mdconfig]\n"
 "\t[-e maxbpg] [-F file] [-f frag-size] [-i bytes] [-m percent-free]\n"
-"\t[-n rotational-positions] [-O optimization] [-o mount-options]\n"
+"\t[-O optimization] [-o mount-options]\n"
 "\t[-p permissions] [-s size] [-v version] [-w user:group]\n"
 "\tmd-device mount-point\n", getprogname());
 	exit(1);

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->remko 
Responsible-Changed-By: remko 
Responsible-Changed-When: Sun Mar 11 08:03:31 UTC 2007 
Responsible-Changed-Why:  
This looks correct, let me handle this 

http://www.freebsd.org/cgi/query-pr.cgi?pr=110178 
State-Changed-From-To: open->patched 
State-Changed-By: remko 
State-Changed-When: Mon May 14 19:23:37 UTC 2007 
State-Changed-Why:  
Patched in head, will MFC in a couple of days. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=110178 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/110178: commit references a PR
Date: Mon, 14 May 2007 19:23:19 +0000 (UTC)

 remko       2007-05-14 19:23:13 UTC
 
   FreeBSD src repository
 
   Modified files:
     sbin/mdmfs           mdmfs.c 
   Log:
   -n is used by newfs to tell "do not generate a .snap directory" instead of
   specifying rotational-positions, reflect that in the command arguments.
   
   PR:             bin/110178
   Submitted by:   Alex Kozlov <spam at rm-rf dot kiev dot ua>
   Approved by:    imp (mentor)
   
   Revision  Changes    Path
   1.33      +4 -4      src/sbin/mdmfs/mdmfs.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/110178: commit references a PR
Date: Sat,  7 Jul 2007 11:22:56 +0000 (UTC)

 remko       2007-07-07 11:22:46 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_6)
     sbin/mdmfs           mdmfs.c 
   Log:
   MFC rev 1.33 mdmfs.c
   
    -n is used by newfs to tell "do not generate a .snap directory" instead of
    specifying rotational-positions, reflect that in the command arguments.
   
    PR: bin/110178
    Submitted by: Alex Kozlov <spam at rm-rf dot kiev dot ua>
    Approved by: imp (mentor)
   
   Approved by:    imp (mentor, implicit)
   
   Revision  Changes    Path
   1.23.2.5  +4 -4      src/sbin/mdmfs/mdmfs.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/110178: commit references a PR
Date: Sat,  7 Jul 2007 11:29:34 +0000 (UTC)

 remko       2007-07-07 11:29:27 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_5)
     sbin/mdmfs           mdmfs.c 
   Log:
   MFC rev 1.33 mdmfs.c
   
   o For this change I needed to modify a little extra, since the RELENG_5 version
     works different then the RELENG_6 or HEAD version that we currently have.
     I "backported" the -n change to RELENG_5 as well, without modifying the
     current behaviour for the other options etc.
   
       -n is used by newfs to tell "do not generate a .snap directory" instead of
       specifying rotational-positions, reflect that in the command arguments.
   
       PR: bin/110178
       Submitted by: Alex Kozlov <spam at rm-rf dot kiev dot ua>
       Approved by: imp (mentor)
   
   Approved by:    imp (mentor, implicit)
   
   Revision  Changes    Path
   1.20.2.1  +6 -6      src/sbin/mdmfs/mdmfs.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: remko 
State-Changed-When: Sat Jul 7 11:31:12 UTC 2007 
State-Changed-Why:  
The changed had been backported to RELENG_6 and RELENG_5 moments ago, 
thanks for the submission! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=110178 
>Unformatted:
