From bmah@eisenhower.ca.sandia.gov Tue Mar 16 20:57:31 1999
Return-Path: <bmah@eisenhower.ca.sandia.gov>
Received: from eisenhower.ca.sandia.gov (eisenhower.ca.sandia.gov [146.246.243.57])
	by hub.freebsd.org (Postfix) with ESMTP id CB2F814E74
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 16 Mar 1999 20:57:14 -0800 (PST)
	(envelope-from bmah@eisenhower.ca.sandia.gov)
Received: (from bmah@localhost)
	by eisenhower.ca.sandia.gov (8.9.2/8.9.2) id UAA54794;
	Tue, 16 Mar 1999 20:56:56 -0800 (PST)
	(envelope-from bmah)
Message-Id: <199903170456.UAA54794@eisenhower.ca.sandia.gov>
Date: Tue, 16 Mar 1999 20:56:56 -0800 (PST)
From: bmah@ca.sandia.gov
Sender: bmah@eisenhower.ca.sandia.gov
Reply-To: bmah@ca.sandia.gov
To: FreeBSD-gnats-submit@freebsd.org
Subject: [patch] tcpslice timezone problem and update/contribify/fix
X-Send-Pr-Version: 3.2

>Number:         10633
>Category:       bin
>Synopsis:       [patch] tcpslice timezone problem and update/contribify/fix
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    fenner
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Mar 16 21:00:02 PST 1999
>Closed-Date:    Mon Jun 14 13:44:16 GMT 2004
>Last-Modified:  Mon Jun 14 13:44:16 GMT 2004
>Originator:     Bruce A. Mah
>Release:        FreeBSD 3.1-RELEASE i386
>Organization:
Sandia National Laboratories
>Environment:

	

>Description:

The version of tcpslice in the source tree has a few problems related
to how it interprets temporal arguments.  It appears to be doing
timezone conversions wrong.

>How-To-Repeat:

With a "tcpdump -w" file, try subsetting parts of the file.  The examples
below were attempts to get all packets in a 24-hour time window, starting
at 2 AM the morning after a trace started.

Wrong behavior:

eisenhower:tcpslice% tcpslice -d -r 2h +24h tcpdump.out
tcpdump.out    Fri Mar 12 16:24:00 1999        Mon Mar 15 09:50:18 1999
start   Thu Mar 11 18:00:00 1999
stop    Fri Mar 12 10:00:00 1999 

Correct behavior: 

eisenhower:tcpslice% ./tcpslice -d -r 2h +24h tcpdump.out 
tcpdump.out    Fri Mar 12 16:24:00 1999        Mon Mar 15 09:50:18 1999
start   Fri Mar 12 02:00:00 1999
stop    Sat Mar 13 02:00:00 1999

>Fix:
	
Pursuant to ports/9358, the idea was discussed of importing a newer
tcpslice into the source tree.  A newer version from LBL fixes the problem
above.  I think it'd also be appropriate to move the distribution of
tcpslice into /usr/src/contrib, to parallel the location of tcpdump.

I think the steps needed are these:

1.  Grab ftp://ftp.ee.lbl.gov/tcpslice-1.1a3.tar.Z.  Unpack it,
and make the resulting directory /usr/src/contrib/tcpslice.

2.  cvs remove all of the files in /usr/src/usr.sbin/tcpdump/tcpslice
except for the Makefile.

3.  New /usr/src/usr.sbin/tcpdump/tcpslice/Makefile is uuencoded 
and enclosed below.  (No diffs sent since the two Makefiles
don't have much in common.)

begin 644 Makefile
M(PDD260D"@I04D]'/0ET8W!S;&EC90I#1DQ!1U,K/2U$2$%615]&0TY43%](
M/3$@+41424U%7U=)5$A?4UE37U1)344],2`M1$A!5D5?5D904DE.5$8],0I-
M04XQ/0ET8W!S;&EC92XQ"E-20U,@/0EV97)S:6]N+F,@=&-P<VQI8V4N8R!<
M"@EG;70R;&]C86PN8R!G=W1M,G-E8W,N8R!M86-H9&5P+F,@<V5A<F-H+F,@
M=71I;"YC"D-,14%.1DE,15,K/0EV97)S:6]N+F,*1%!!1$0K/0DD>TQ)0E!#
M05!]"DQ$041$*ST)+6QP8V%P"@I40U!33$E#15]$25-41$E2/ST@)'LN0U52
M1$E2?2\N+B\N+B\N+B]C;VYT<FEB+W1C<'-L:6-E"D-&3$%'4RL]("U))'M4
M0U!33$E#15]$25-41$E2?2]L8FP*+E!!5$@Z"21[5$-04TQ)0T5?1$E35$1)
M4GT*"G9E<G-I;VXN8SH@)'M40U!33$E#15]$25-41$E2?2]615)324]."@ER
M;2`M9B!V97)S:6]N+F,@.R!<"@ES960@)W,O+BHO8VAA<B!V97)S:6]N6UT@
M/2`B)B([+R<@)'M40U!33$E#15]$25-41$E2?2]615)324].(#X@=F5R<VEO
<;BYC"@HN:6YC;'5D92`\8G-D+G!R;V<N;6L^"B]6
`
end

>Release-Note:
>Audit-Trail:

From: bmah@ca.sandia.gov
To: FreeBSD-gnats-submit@freebsd.org
Cc:  
Subject: bin/10633: [patch] tcpslice timezone problem and update/contribify/fix
Date: Tue, 16 Mar 1999 20:56:56 -0800 (PST)

 >Number:         10633
 >Category:       bin
 >Synopsis:       [patch] tcpslice timezone problem and update/contribify/fix
 >Confidential:   no
 >Severity:       serious
 >Priority:       low
 >Responsible:    freebsd-bugs
 >State:          open
 >Quarter:        
 >Keywords:       
 >Date-Required:
 >Class:          sw-bug
 >Submitter-Id:   current-users
 >Arrival-Date:   Tue Mar 16 21:00:02 PST 1999
 >Closed-Date:
 >Last-Modified:
 >Originator:     Bruce A. Mah
 >Release:        FreeBSD 3.1-RELEASE i386
 >Organization:
 Sandia National Laboratories
 >Environment:
 
 	
 
 >Description:
 
 The version of tcpslice in the source tree has a few problems related
 to how it interprets temporal arguments.  It appears to be doing
 timezone conversions wrong.
 
 >How-To-Repeat:
 
 With a "tcpdump -w" file, try subsetting parts of the file.  The examples
 below were attempts to get all packets in a 24-hour time window, starting
 at 2 AM the morning after a trace started.
 
 Wrong behavior:
 
 eisenhower:tcpslice% tcpslice -d -r 2h +24h tcpdump.out
 tcpdump.out    Fri Mar 12 16:24:00 1999        Mon Mar 15 09:50:18 1999
 start   Thu Mar 11 18:00:00 1999
 stop    Fri Mar 12 10:00:00 1999 
 
 Correct behavior: 
 
 eisenhower:tcpslice% ./tcpslice -d -r 2h +24h tcpdump.out 
 tcpdump.out    Fri Mar 12 16:24:00 1999        Mon Mar 15 09:50:18 1999
 start   Fri Mar 12 02:00:00 1999
 stop    Sat Mar 13 02:00:00 1999
 
 >Fix:
 	
 Pursuant to ports/9358, the idea was discussed of importing a newer
 tcpslice into the source tree.  A newer version from LBL fixes the problem
 above.  I think it'd also be appropriate to move the distribution of
 tcpslice into /usr/src/contrib, to parallel the location of tcpdump.
 
 I think the steps needed are these:
 
 1.  Grab ftp://ftp.ee.lbl.gov/tcpslice-1.1a3.tar.Z.  Unpack it,
 and make the resulting directory /usr/src/contrib/tcpslice.
 
 2.  cvs remove all of the files in /usr/src/usr.sbin/tcpdump/tcpslice
 except for the Makefile.
 
 3.  New /usr/src/usr.sbin/tcpdump/tcpslice/Makefile is uuencoded 
 and enclosed below.  (No diffs sent since the two Makefiles
 don't have much in common.)
 
 begin 644 Makefile
 M(PDD260D"@I04D]'/0ET8W!S;&EC90I#1DQ!1U,K/2U$2$%615]&0TY43%](
 M/3$@+41424U%7U=)5$A?4UE37U1)344],2`M1$A!5D5?5D904DE.5$8],0I-
 M04XQ/0ET8W!S;&EC92XQ"E-20U,@/0EV97)S:6]N+F,@=&-P<VQI8V4N8R!<
 M"@EG;70R;&]C86PN8R!G=W1M,G-E8W,N8R!M86-H9&5P+F,@<V5A<F-H+F,@
 M=71I;"YC"D-,14%.1DE,15,K/0EV97)S:6]N+F,*1%!!1$0K/0DD>TQ)0E!#
 M05!]"DQ$041$*ST)+6QP8V%P"@I40U!33$E#15]$25-41$E2/ST@)'LN0U52
 M1$E2?2\N+B\N+B\N+B]C;VYT<FEB+W1C<'-L:6-E"D-&3$%'4RL]("U))'M4
 M0U!33$E#15]$25-41$E2?2]L8FP*+E!!5$@Z"21[5$-04TQ)0T5?1$E35$1)
 M4GT*"G9E<G-I;VXN8SH@)'M40U!33$E#15]$25-41$E2?2]615)324]."@ER
 M;2`M9B!V97)S:6]N+F,@.R!<"@ES960@)W,O+BHO8VAA<B!V97)S:6]N6UT@
 M/2`B)B([+R<@)'M40U!33$E#15]$25-41$E2?2]615)324].(#X@=F5R<VEO
 <;BYC"@HN:6YC;'5D92`\8G-D+G!R;V<N;6L^"B]6
 `
 end
 
 >Release-Note:
 >Audit-Trail:
 >Unformatted:
 
 
 To Unsubscribe: send mail to majordomo@FreeBSD.org
 with "unsubscribe freebsd-bugs" in the body of the message
 
 
 
 
Responsible-Changed-From-To: freebsd-bugs->obrien 
Responsible-Changed-By: obrien 
Responsible-Changed-When: Mon Apr 19 15:20:08 PDT 1999 
Responsible-Changed-Why:  
I've been doing much contrib/ work lately... 
Responsible-Changed-From-To: obrien->fenner 
Responsible-Changed-By: fenner 
Responsible-Changed-When: Mon Sep 3 13:23:06 PDT 2001 
Responsible-Changed-Why:  
I'm gonna release tcpslice 1.2 and contribity it RSN... 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=10633 
State-Changed-From-To: open->closed 
State-Changed-By: bms 
State-Changed-When: Mon Jun 14 13:43:31 GMT 2004 
State-Changed-Why:  
Looks like this has been fixed since tcpslice.c rev 1.12. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=10633 
>Unformatted:
