From nobody@FreeBSD.org  Mon Nov 13 16:21:34 2006
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1DD0F16A4EB
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 13 Nov 2006 16:21:34 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 19ADB4407F
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 13 Nov 2006 16:14:59 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id kADGEXlW012034
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 13 Nov 2006 16:14:33 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id kADGEXVk012033;
	Mon, 13 Nov 2006 16:14:33 GMT
	(envelope-from nobody)
Message-Id: <200611131614.kADGEXVk012033@www.freebsd.org>
Date: Mon, 13 Nov 2006 16:14:33 GMT
From: "Dr. Markus Waldeck"<waldeck@gmx.de>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Mounting ext2fs with noatime option
X-Send-Pr-Version: www-3.0

>Number:         105483
>Category:       bin
>Synopsis:       [patch] mount(8): Mounting ext2fs with noatime option
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    rodrigc
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Nov 13 16:30:01 GMT 2006
>Closed-Date:    Tue Dec 19 01:40:51 GMT 2006
>Last-Modified:  Tue Dec 19 01:40:51 GMT 2006
>Originator:     Dr. Markus Waldeck
>Release:        7.0-CURRENT-200611
>Organization:
>Environment:
FreeBSD fbh 7.0-CURRENT-200610 FreeBSD 7.0-CURRENT-200611
root@fb:/usr/src/sys/i386/compile/FB70B01 i386
>Description:
In FreeBSD 6.1 it is possible to mount an ext2fs partition with the option noatime.

In FreeBSD 7.0 it is NOT possible.

>How-To-Repeat:
mount -t ext2fs -o noatime <ext2fs partition> <mount point>
>Fix:
--- mount.c     2006-11-13 17:35:48.335682544 +0200
+++ mount.c.patched     2006-11-13 17:34:45.790190904 +0200
@@ -133,7 +133,7 @@
         */
        unsigned int i;
        const char *fs[] = {
-       "cd9660", "mfs", "msdosfs", "nfs", "nfs4", "ntfs",
+       "cd9660", "ext2fs", "mfs", "msdosfs", "nfs", "nfs4", "ntfs",
        "nwfs", "nullfs", "portalfs", "smbfs", "udf", "umapfs",
        "unionfs",
        NULL

>Release-Note:
>Audit-Trail:

From: Craig Rodrigues <rodrigc@crodrigues.org>
To: "Dr. Markus Waldeck" <waldeck@gmx.de>
Cc: bug-followup@freebsd.org
Subject: Re: bin/105483: Mounting ext2fs with noatime option
Date: Sat, 18 Nov 2006 11:55:40 -0500

 Hi,
 
 Can you revert your patch to mount, and apply this patch to the
 ext2 filesystem instead?
 
 
 Index: ext2_vfsops.c
 ===================================================================
 RCS file: /home/ncvs/src/sys/gnu/fs/ext2fs/ext2_vfsops.c,v
 retrieving revision 1.159
 diff -u -u -r1.159 ext2_vfsops.c
 --- ext2_vfsops.c	6 Nov 2006 13:41:58 -0000	1.159
 +++ ext2_vfsops.c	18 Nov 2006 16:53:22 -0000
 @@ -119,7 +119,10 @@
  static int	compute_sb_data(struct vnode * devvp,
  		    struct ext2_super_block * es, struct ext2_sb_info * fs);
  
 -static const char *ext2_opts[] = { "from", "export" };
 +static const char *ext2_opts[] = { "from", "export", "union", "acls", "noexec",
 +    "noatime", "union", "suiddir", "multilabel", "nosymfollow", "noclusterr",
 +    "noclusterw" };
 + 
  /*
   * VFS Operations.
   *
 
 
 
 -- 
 Craig Rodrigues        
 rodrigc@crodrigues.org

From: Craig Rodrigues <rodrigc@crodrigues.org>
To: "Dr. Markus Waldeck" <waldeck@gmx.de>
Cc: bug-followup@freebsd.org
Subject: Re: bin/105483: Mounting ext2fs with noatime option
Date: Sat, 18 Nov 2006 13:11:44 -0500

 Hi,
 
 My previous patch had a minor mistake in it.  Try this instead.
 
 Index: ext2_vfsops.c
 ===================================================================
 RCS file: /home/ncvs/src/sys/gnu/fs/ext2fs/ext2_vfsops.c,v
 retrieving revision 1.159
 diff -u -u -r1.159 ext2_vfsops.c
 --- ext2_vfsops.c	6 Nov 2006 13:41:58 -0000	1.159
 +++ ext2_vfsops.c	18 Nov 2006 18:10:37 -0000
 @@ -119,7 +119,10 @@
  static int	compute_sb_data(struct vnode * devvp,
  		    struct ext2_super_block * es, struct ext2_sb_info * fs);
  
 -static const char *ext2_opts[] = { "from", "export" };
 +static const char *ext2_opts[] = { "from", "export", "union", "acls", "exec",
 +    "atime", "union", "suiddir", "multilabel", "symfollow", "clusterr",
 +    "clusterw" };
 + 
  /*
   * VFS Operations.
   *
 
 -- 
 Craig Rodrigues        
 rodrigc@crodrigues.org
State-Changed-From-To: open->patched 
State-Changed-By: rodrigc 
State-Changed-When: Sat Nov 18 18:23:23 UTC 2006 
State-Changed-Why:  
Patched. 


Responsible-Changed-From-To: freebsd-bugs->rodrigc 
Responsible-Changed-By: rodrigc 
Responsible-Changed-When: Sat Nov 18 18:23:23 UTC 2006 
Responsible-Changed-Why:  
Patched. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=105483 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/105483: commit references a PR
Date: Sat, 18 Nov 2006 18:22:36 +0000 (UTC)

 rodrigc     2006-11-18 18:22:11 UTC
 
   FreeBSD src repository
 
   Modified files:
     sys/gnu/fs/ext2fs    ext2_vfsops.c 
   Log:
   Previously, the mount_ext2fs binary listed the acceptable mount
   options for ext2fs.  Now that we use nmount() directly from the mount
   binary to access ext2fs filesystems, add the list of acceptable mount
   options to ext2_ops, so that vfs_filteropts() will accept
   options like "noatime" for ext2fs.
   
   PR:             105483
   Noticed by:     Dr. Markus Waldeck <waldeck gmx de>
   MFC after:      1 month
   
   Revision  Changes    Path
   1.160     +4 -1      src/sys/gnu/fs/ext2fs/ext2_vfsops.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/105483: commit references a PR
Date: Tue, 19 Dec 2006 01:37:22 +0000 (UTC)

 rodrigc     2006-12-19 01:36:44 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_6)
     sys/gnu/fs/ext2fs    ext2_vfsops.c 
   Log:
   MFC 1.160: Add more mount options to ext2_ops, so that vfs_filteropts()
   will accept options like "noatime" for ext2fs.
   
   PR:             105483
   Noticed by:     Dr. Markus Waldeck <waldeck gmx de>
   
   Revision   Changes    Path
   1.151.2.7  +4 -1      src/sys/gnu/fs/ext2fs/ext2_vfsops.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: rodrigc 
State-Changed-When: Tue Dec 19 01:40:34 UTC 2006 
State-Changed-Why:  
Merged to RELENG_6. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=105483 
>Unformatted:
