From nectar@nectar.com Tue Mar  9 10:07:50 1999
Return-Path: <nectar@nectar.com>
Received: from cerebus.nectar.com (nectar-gw.nectar.com [204.0.249.101])
	by hub.freebsd.org (Postfix) with ESMTP id D876E1506A
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  9 Mar 1999 10:07:48 -0800 (PST)
	(envelope-from nectar@nectar.com)
Received: (from smap@localhost)
	by cerebus.nectar.com (8.9.1/8.9.1) id MAA28045
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 9 Mar 1999 12:07:30 -0600 (CST)
	(envelope-from nectar@nectar.com)
Received: from spawn.nectar.com(10.0.0.101) by cerebus.nectar.com via smap (V2.1)
	id xma028043; Tue, 9 Mar 99 12:07:14 -0600
Received: (from nectar@localhost)
	by spawn.nectar.com (8.9.2/8.9.1) id MAA93173;
	Tue, 9 Mar 1999 12:07:14 -0600 (CST)
	(envelope-from nectar)
Message-Id: <199903091807.MAA93173@spawn.nectar.com>
Date: Tue, 9 Mar 1999 12:07:14 -0600 (CST)
From: Jacques Vidrine <nectar@nectar.com>
Reply-To: nectar@nectar.com
To: FreeBSD-gnats-submit@freebsd.org
Subject: Remote cvs botches commits on occassion
X-Send-Pr-Version: 3.2

>Number:         10510
>Category:       bin
>Synopsis:       Remote cvs botches commits on occassion
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Mar  9 10:10:00 PST 1999
>Closed-Date:    Thu Sep 23 18:54:31 GMT 2004
>Last-Modified:  Thu Sep 23 18:54:31 GMT 2004
>Originator:     Jacques Vidrine
>Release:        FreeBSD 3.1-STABLE i386
>Organization:
None to be had
>Environment:

	FreeBSD 3.x - 4.x

>Description:

	On occassion, when committing a new file in place of a dead
	revision using remote cvs (i.e. ``cvs server''), cvs barfs
	and leaves the repository in an inconsistent state.  The
	repository will contain an rcsfile with the latest revision
	being ``state dead'', and further attempts to commit new
	revisions will fail with ``cannot add file `foo' when RCS file
	`..../foo,v' already exists''.

	As an example session:

	local_machine$ cvs ci
	[fill out the log]
	cvs commit: Examining .
	cvs server: warning: cannot stat patch-ag: No such file or directory
	Checking in patch-ag;
	/home/ncvs/ports/x11/gnomecore/patches/patch-ag,v  <--  patch-ag
	cvs [server aborted]: can't stat patch-ag: No such file or directory
	cvs commit: saving log message in /tmp/cvsm91737

	[wonder what went wrong, try to commit again]
	local_machine$ cvs ci
	[fill out log]
	cvs commit: Examining .
	cvs commit: cannot add file `patch-ag' when RCS file `/home/ncvs/ports/x11/gnomecore/patches/patch-ag,v' already exists
	cvs [commit aborted]: correct above errors first!


>How-To-Repeat:

	Not sure -- it doesn't happen always.  But a prerequisite is 
	that you are committing a revision to a file that has previously
	been ``cvs remove''d.
	
	In the above example, the CVS/Entries file looks normal:

	/patch-ab/1.3/Fri Jan  1 06:20:55 1999//
	/patch-ac/1.3/Fri Jan  1 06:20:55 1999//
	/patch-ad/1.3/Fri Jan  1 06:20:55 1999//
	/patch-aa/1.8/Mon Mar  8 19:22:03 1999//
	/patch-ae/1.8/Mon Mar  8 19:22:03 1999//
	/patch-af/1.6/Mon Mar  8 19:22:03 1999//
	/patch-ag/0/Mon Mar  8 19:22:03 1999//
	/patch-ah/0/Mon Mar  8 19:22:03 1999//
	D

>Fix:
	

>Release-Note:
>Audit-Trail:

From: Mike Barcroft <mike@FreeBSD.org>
To: John Polstra <jdp@FreeBSD.org>
Cc: freebsd-gnats-submit@FreeBSD.org, nectar@nectar.com
Subject: Re: bin/10510: Remote cvs botches commits on occassion
Date: Thu, 19 Jul 2001 20:10:06 -0400

 John,
 Warner thinks this PR can be closed.  Can you confirm whether this problem
 has been fixed or not?
 
 Best regards,
 Mike Barcroft

From: John Polstra <jdp@polstra.com>
To: Mike Barcroft <mike@FreeBSD.org>
Cc: nectar@nectar.com, freebsd-gnats-submit@FreeBSD.org
Subject: Re: bin/10510: Remote cvs botches commits on occassion
Date: Thu, 19 Jul 2001 17:03:52 -0700 (PDT)

 Mike Barcroft wrote:
 > Warner thinks this PR can be closed.  Can you confirm whether this
 > problem has been fixed or not?
 
 I don't recall hearing that it has been fixed.  Peter Wemm
 <peter@freebsd.org> may be able to tell you.
 
 John

From: Mike Barcroft <mike@FreeBSD.org>
To: John Polstra <jdp@polstra.com>
Cc: nectar@nectar.com, freebsd-gnats-submit@FreeBSD.org
Subject: Re: bin/10510: Remote cvs botches commits on occassion
Date: Thu, 19 Jul 2001 21:00:37 -0400

 On Thu, Jul 19, 2001 at 05:03:52PM -0700, John Polstra wrote:
 > Mike Barcroft wrote:
 > > Warner thinks this PR can be closed.  Can you confirm whether this
 > > problem has been fixed or not?
 > 
 > I don't recall hearing that it has been fixed.  Peter Wemm
 > <peter@freebsd.org> may be able to tell you.
 
 Just to follow-up.  Peter confirmed that this bug is still present.
 
 Best regards,
 Mike Barcroft

From: Giorgos Keramidas <keramida@FreeBSD.org>
To: Jacques Vidrine <nectar@nectar.com>
Cc: bug-followup@FreeBSD.org, Mike Barcroft <mike@FreeBSD.org>,
	John Polstra <jdp@FreeBSD.org>, Peter Wemm <peter@FreeBSD.org>
Subject: Re: bin/10510: Remote cvs botches commits on occassion
Date: Mon, 26 Aug 2002 13:15:42 +0300

 On 1999-03-09 12:07 +0000, Jacques Vidrine wrote:
 > 	As an example session:
 >
 > 	local_machine$ cvs ci
 > 	[fill out the log]
 > 	cvs commit: Examining .
 > 	cvs server: warning: cannot stat patch-ag: No such file or directory
 > 	Checking in patch-ag;
 > 	/home/ncvs/ports/x11/gnomecore/patches/patch-ag,v  <--  patch-ag
 > 	cvs [server aborted]: can't stat patch-ag: No such file or directory
 > 	cvs commit: saving log message in /tmp/cvsm91737
 >
 > 	[wonder what went wrong, try to commit again]
 > 	local_machine$ cvs ci
 > 	[fill out log]
 > 	cvs commit: Examining .
 > 	cvs commit: cannot add file `patch-ag' when RCS file `/home/ncvs/ports/x11/gnomecore/patches/patch-ag,v' already exists
 > 	cvs [commit aborted]: correct above errors first!
 
 Is this behavior related to the remote client/server that fenner fixed
 only recently in rev 1.7 of src/contrib/cvs/src/client.c ?  IIRC, from
 the related threads when des and fenner were bit by the client not
 correctly uploading files for "cvs import" they fixed it by forcing
 the client to always upload the new files.  The relevant delta is:
 
 	2002.07.08.10.05.26 client.c 1.7 fenner
 
 -- 
 FreeBSD: The Power to Serve <> http://www.FreeBSD.org
 FreeBSD 5.0-CURRENT #0: Wed Aug 21 22:08:19 EEST 2002
State-Changed-From-To: open->closed 
State-Changed-By: delphij 
State-Changed-When: Thu Sep 23 18:49:22 GMT 2004 
State-Changed-Why:  
In a private conversation between I and nectar@, he thought that he did 
not saw the same problem for some years, nor anyone reported the same 
issue.  The issue is not "completely proven" to be solved, however, 
we both think it's OK to close this PR, as there is nobody else claims 
the same issue, and CVS itself has upgraded several times. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=10510 
>Unformatted:
