From durian@boogie.com  Mon Oct 16 19:04:45 2006
Return-Path: <durian@boogie.com>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id CAF4F16A417
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 16 Oct 2006 19:04:45 +0000 (UTC)
	(envelope-from durian@boogie.com)
Received: from mailhost.boogie.com (mailhost.boogie.com [70.91.170.29])
	by mx1.FreeBSD.org (Postfix) with ESMTP id A13AF4412D
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 16 Oct 2006 18:57:29 +0000 (GMT)
	(envelope-from durian@boogie.com)
Received: from boogie.com (man.boogie.com [192.168.1.3])
	by mailhost.boogie.com (8.13.6/8.13.6) with ESMTP id k9GIv2gi048736
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 16 Oct 2006 12:57:02 -0600 (MDT)
	(envelope-from durian@fever.boogie.com)
Received: from man.boogie.com (localhost [127.0.0.1])
	by boogie.com (8.13.8/8.13.8) with ESMTP id k9GIv2Jl044809
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 16 Oct 2006 12:57:02 -0600 (MDT)
	(envelope-from durian@man.boogie.com)
Received: (from durian@localhost)
	by man.boogie.com (8.13.8/8.13.6/Submit) id k9GIv1A2044803;
	Mon, 16 Oct 2006 12:57:01 -0600 (MDT)
	(envelope-from durian)
Message-Id: <200610161857.k9GIv1A2044803@man.boogie.com>
Date: Mon, 16 Oct 2006 12:57:01 -0600 (MDT)
From: Mike Durian <durian@shadetreesoftware.com>
Reply-To: Mike Durian <durian@shadetreesoftware.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: ngctl Makefile doesn't observe NO_LIBPTHREAD
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         104478
>Category:       bin
>Synopsis:       [patch] ngctl(8) Makefile doesn't observe NO_LIBPTHREAD
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    glebius
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Oct 16 19:10:10 GMT 2006
>Closed-Date:    Fri Mar 30 08:26:24 GMT 2007
>Last-Modified:  Fri Mar 30 08:30:04 GMT 2007
>Originator:     Mike Durian
>Release:        FreeBSD 6.2-PRERELEASE i386
>Organization:
>Environment:
System: FreeBSD man.boogie.com 6.2-PRERELEASE FreeBSD 6.2-PRERELEASE #0: Fri Oct 13 10:41:27 MDT 2006 root@man.boogie.com:/usr/obj/usr/src/sys/BOOGIE i386


	
>Description:
	I recently updated my kernel and tried to build an image
	using nanobsd.sh.  The build failed with usr.sbin/ngctl,
	because the Makefile didn't know how to build libpthread.

	My nanobsd configuration file does define NO_LIBPTHREAD=YES.

	I believe the ngctl/Makefile 1.14.8.1 change which adds
	dependancies on libedit and libpthread unless RELEASE_CRUNCH
	is defined, should also exclude those dependancies if
	NO_LIBTHREAD is defined.
>How-To-Repeat:
	Define NO_LIBTHREAD=YES in a nanobsd configuration file, or
	easier, in make.conf.  Try to buildworld.
>Fix:

	--- Makefile.orig       Mon Oct 16 12:21:11 2006
	+++ Makefile    Mon Oct 16 12:21:56 2006
	@@ -7,7 +7,7 @@
	        msg.c debug.c shutdown.c rmhook.c status.c types.c write.c
	 WARNS?=        3
	
	-.if defined(RELEASE_CRUNCH)
	+.if defined(RELEASE_CRUNCH) || defined(NO_LIBPTHREAD)
	 NGCTL_NO_LIBEDIT=
	 .endif


>Release-Note:
>Audit-Trail:

From: Mike Durian <durian@shadetreesoftware.com>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: bin/104478: [patch] ngctl(8) Makefile doesn't observe NO_LIBPTHREAD
Date: Tue, 17 Oct 2006 12:45:17 -0600

 I think I miscategorized this.  It should probably be filed under net,
 not bin.
 
 mike
 
Responsible-Changed-From-To: freebsd-bugs->glebius 
Responsible-Changed-By: glebius 
Responsible-Changed-When: Tue Mar 13 15:57:05 UTC 2007 
Responsible-Changed-Why:  
I'll handle this. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=104478 
State-Changed-From-To: open->patched 
State-Changed-By: glebius 
State-Changed-When: Wed Mar 28 14:02:59 UTC 2007 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=104478 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/104478: commit references a PR
Date: Wed, 28 Mar 2007 14:04:41 +0000 (UTC)

 glebius     2007-03-28 14:04:35 UTC
 
   FreeBSD src repository
 
   Modified files:
     usr.sbin/ngctl       Makefile 
   Log:
   Do not build the libedit support if NO_LIBPTHREAD is defined.
   
   PR:             bin/104478
   Submitted by:   Mike Durian <durian shadetreesoftware.com>
   
   Revision  Changes    Path
   1.18      +1 -1      src/usr.sbin/ngctl/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: glebius 
State-Changed-When: Fri Mar 30 08:26:09 UTC 2007 
State-Changed-Why:  
Merged to RELENG_6. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=104478 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/104478: commit references a PR
Date: Fri, 30 Mar 2007 08:26:00 +0000 (UTC)

 glebius     2007-03-30 08:25:53 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_6)
     usr.sbin/ngctl       Makefile 
   Log:
   Merge rev. 1.17:
     Do not build the libedit support if NO_LIBPTHREAD is defined.
   
     PR:           bin/104478
     Submitted by: Mike Durian <durian shadetreesoftware.com>
   
   Revision  Changes    Path
   1.14.8.2  +1 -1      src/usr.sbin/ngctl/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
