From thomas@cuivre.fr.eu.org  Thu Aug 17 07:07:08 2006
Return-Path: <thomas@cuivre.fr.eu.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 6F09A16A4DA
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 17 Aug 2006 07:07:08 +0000 (UTC)
	(envelope-from thomas@cuivre.fr.eu.org)
Received: from melamine.cuivre.fr.eu.org (melusine.cuivre.fr.eu.org [82.225.155.84])
	by mx1.FreeBSD.org (Postfix) with ESMTP id DB7AC43D64
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 17 Aug 2006 07:07:05 +0000 (GMT)
	(envelope-from thomas@cuivre.fr.eu.org)
Received: by melamine.cuivre.fr.eu.org (Postfix, from userid 1000)
	id 8CD495C47F; Thu, 17 Aug 2006 09:07:04 +0200 (CEST)
Message-Id: <20060817070704.8CD495C47F@melamine.cuivre.fr.eu.org>
Date: Thu, 17 Aug 2006 09:07:04 +0200 (CEST)
From: Thomas Quinot <thomas@cuivre.fr.eu.org>
Reply-To: Thomas Quinot <thomas@cuivre.fr.eu.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] rpc.lockd: grace period is always 10 seconds
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         102176
>Category:       bin
>Synopsis:       [PATCH] rpc.lockd: grace period is always 10 seconds
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    thomas
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Aug 17 07:10:15 GMT 2006
>Closed-Date:    Thu Aug 31 18:13:31 GMT 2006
>Last-Modified:  Thu Aug 31 18:13:31 GMT 2006
>Originator:     Thomas Quinot
>Release:        FreeBSD 6.1-RC i386
>Organization:
>Environment:
System: FreeBSD melamine.cuivre.fr.eu.org 6.1-RC FreeBSD 6.1-RC #0: Thu May 4 13:21:21 CEST 2006 thomas@melamine.cuivre.fr.eu.org:/space/build/obj/space/build/src/RELENG_6/sys/MELAMINE i386


	
>Description:
	From code reading, it looks like the default grace period of 30 seconds
	and the user-specified grace period from the -g command line switch are
	not taken into account; instead, a fixed grace period of 10 seconds is
	implemented.

>How-To-Repeat:
	
>Fix:

	The following patch is the obvious fix; however it has not been tested yet.

Index: lockd.c
===================================================================
RCS file: /space/mirror/ncvs/src/usr.sbin/rpc.lockd/lockd.c,v
retrieving revision 1.18
diff -u -r1.18 lockd.c
--- lockd.c	16 Jul 2004 19:30:59 -0000	1.18
+++ lockd.c	17 Aug 2006 07:02:13 -0000
@@ -203,7 +203,7 @@
 		exit(1);
 	}
 	grace_expired = 0;
-	alarm(10);
+	alarm(grace_period);
 
 	init_nsm();
 


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->thomas 
Responsible-Changed-By: thomas 
Responsible-Changed-When: Thu Aug 17 07:18:34 UTC 2006 
Responsible-Changed-Why:  
I'll take care of this one. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=102176 
State-Changed-From-To: open->patched 
State-Changed-By: thomas 
State-Changed-When: Wed Aug 23 16:00:52 UTC 2006 
State-Changed-Why:  
Patch tested locally and committed: 
Revision  Changes    Path 
1.19      +1 -1      src/usr.sbin/rpc.lockd/lockd.c 

http://www.freebsd.org/cgi/query-pr.cgi?pr=102176 
State-Changed-From-To: patched->closed 
State-Changed-By: thomas 
State-Changed-When: Thu Aug 31 18:13:06 UTC 2006 
State-Changed-Why:  
MFC'd to RELENG_6 (lockd.c rev. 1.18.8.1). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=102176 
>Unformatted:
