From nobody@FreeBSD.org  Sun Aug 13 16:11:53 2006
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 996AA16A4DF
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 13 Aug 2006 16:11:53 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 622B743D45
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 13 Aug 2006 16:11:53 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k7DGBrca012369
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 13 Aug 2006 16:11:53 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id k7DGBrQb012368;
	Sun, 13 Aug 2006 16:11:53 GMT
	(envelope-from nobody)
Message-Id: <200608131611.k7DGBrQb012368@www.freebsd.org>
Date: Sun, 13 Aug 2006 16:11:53 GMT
From: Roberto Lima <roberto@forbrazil.com.br>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] Adding percents in /usr/src/usr.bin/systat/pigs.c
X-Send-Pr-Version: www-2.3

>Number:         101975
>Category:       bin
>Synopsis:       [PATCH] Adding percents in /usr/src/usr.bin/systat/pigs.c
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    yar
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Aug 13 16:20:13 GMT 2006
>Closed-Date:    Fri Jan 05 13:34:06 GMT 2007
>Last-Modified:  Fri Jan 05 13:34:06 GMT 2007
>Originator:     Roberto Lima
>Release:        FreeBSD 6.1-STABLE
>Organization:
ForBrazil
>Environment:
FreeBSD bsd.forbr.com.br 6.1-STABLE FreeBSD 6.1-STABLE #1: Tue Jun 27 17:20:15 BRT 2006     root@bsd.forbr.com.br:/usr/src/sys/i386/compile/ForBrazil  i386

>Description:
I see that systat -pigs don't shows percents in /0 ... /100, so I make this patch.
>How-To-Repeat:
# systat -pigs

                    /0   /10  /20  /30  /40  /50  /60  /70  /80  /90  /100
root     idle: cpu0 XXXXXXXXXXXXXXX

>Fix:
--- /usr/src/usr.bin/systat/pigs.c.old  Fri Jun  2 10:40:01 2006
+++ /usr/src/usr.bin/systat/pigs.c      Sun Aug 13 13:01:26 2006
@@ -236,7 +236,7 @@
        wmove(wnd, 0, 0);
        wclrtoeol(wnd);
        mvwaddstr(wnd, 0, 20,
-           "/0   /10  /20  /30  /40  /50  /60  /70  /80  /90  /100");
+           "/0%   /10%  /20%  /30%  /40%  /50%  /60%  /70%  /80%  /90%  /100%");
 }
 
 int

>Release-Note:
>Audit-Trail:

From: Giorgos Keramidas <keramida@ceid.upatras.gr>
To: Roberto Lima <roberto@forbrazil.com.br>
Cc: freebsd-gnats-submit@freebsd.org
Subject: Re: bin/101975: [PATCH] Adding percents in /usr/src/usr.bin/systat/pigs.c
Date: Mon, 14 Aug 2006 03:45:22 +0300

 On 2006-08-13 16:11, Roberto Lima <roberto@forbrazil.com.br> wrote:
 > >Description:
 > I see that systat -pigs don't shows percents in /0 ... /100, so
 > I make this patch.
 >
 > >How-To-Repeat:
 > # systat -pigs
 > 
 >                     /0   /10  /20  /30  /40  /50  /60  /70  /80  /90  /100
 > root     idle: cpu0 XXXXXXXXXXXXXXX
 > 
 > >Fix:
 > --- /usr/src/usr.bin/systat/pigs.c.old  Fri Jun  2 10:40:01 2006
 > +++ /usr/src/usr.bin/systat/pigs.c      Sun Aug 13 13:01:26 2006
 > @@ -236,7 +236,7 @@
 >         wmove(wnd, 0, 0);
 >         wclrtoeol(wnd);
 >         mvwaddstr(wnd, 0, 20,
 > -           "/0   /10  /20  /30  /40  /50  /60  /70  /80  /90  /100");
 > +           "/0%   /10%  /20%  /30%  /40%  /50%  /60%  /70%  /80%  /90%  /100%");
 >  }
 >  
 >  int
 > ---
 
 Why?  Isn't it obvious from the scale that this is a percentage?
 
 Moreover, you have just broken the alignment of the "Load
 Average" scale parts with the percentage stats.
 
 You are "wasting space" by using 10 percent signs.  Maybe we
 can make it more obvious that 0/10/20/.../100 is a percentage
 with a single '%' character as below (which also preserves
 the current alignment of "Load average" and pigs columns?
 
 %%%
 Index: pigs.c
 ===================================================================
 RCS file: /home/ncvs/src/usr.bin/systat/pigs.c,v
 retrieving revision 1.21
 diff -u -r1.21 pigs.c
 --- pigs.c	30 Apr 2006 04:26:46 -0000	1.21
 +++ pigs.c	14 Aug 2006 00:40:06 -0000
 @@ -236,7 +236,7 @@
  	wmove(wnd, 0, 0);
  	wclrtoeol(wnd);
  	mvwaddstr(wnd, 0, 20,
 -	    "/0   /10  /20  /30  /40  /50  /60  /70  /80  /90  /100");
 +	    "/0   /10  /20  /30  /40  /50  /60  /70  /80  /90  /100%");
  }
  
  int
 %%%
 

From: bsd@forbrazil.com.br
To: "Giorgos Keramidas" <keramida@ceid.upatras.gr>
Cc: freebsd-gnats-submit@freebsd.org
Subject: Re: bin/101975: [PATCH] Adding percents in 
     /usr/src/usr.bin/systat/pigs.c
Date: Mon, 14 Aug 2006 14:54:49 -0400 (AMT)

 Sorry, but i'm only based in 'systat -swaps', where shows it:
 Disk 1K-blocks     Used  /0%  /10% /20% /30% /40% /50% /60% /70% /80% /90%
 /100%
 ad0s1  8388480     1076  X
 

From: Giorgos Keramidas <keramida@ceid.upatras.gr>
To: bsd@forbrazil.com.br
Cc: freebsd-gnats-submit@freebsd.org
Subject: Re: bin/101975: [PATCH] Adding percents in /usr/src/usr.bin/systat/pigs.c
Date: Tue, 15 Aug 2006 15:25:25 +0300

 On 2006-08-14 14:54, bsd@forbrazil.com.br wrote:
 > Sorry, but i'm only based in 'systat -swaps', where shows it:
 > Disk 1K-blocks     Used  /0%  /10% /20% /30% /40% /50% /60% /70% /80% /90% /100%
 > ad0s1  8388480     1076  X
 
 There is no % after 100 in "systat -swap".  Precisely because all those
 % characters push the line length up to almost 80 characters and this
 would overflow 80x25 terminal lines.
 
 I'm not sure it's worth repeating the same 'hack' in other screens, but
 I'd certainly prefer any of:
 
 Disk 1K-blocks     Used  /0  /10 /20 /30 /40 /50 /60 /70 /80 /90 /100%
 Disk 1K-blocks     Used  /0% /10 /20 /30 /40 /50 /60 /70 /80 /90 /100
 
State-Changed-From-To: open->patched 
State-Changed-By: yar 
State-Changed-When: Mon Nov 27 20:19:31 UTC 2006 
State-Changed-Why:  
A consistent change applied to all percentage scales in systat. 
MFC is due. 


Responsible-Changed-From-To: freebsd-bugs->yar 
Responsible-Changed-By: yar 
Responsible-Changed-When: Mon Nov 27 20:19:31 UTC 2006 
Responsible-Changed-Why:  
A consistent change applied to all percentage scales in systat. 
MFC is due. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=101975 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/101975: commit references a PR
Date: Mon, 27 Nov 2006 20:46:51 +0000 (UTC)

 yar         2006-11-27 20:19:05 UTC
 
   FreeBSD src repository
 
   Modified files:
     usr.bin/systat       iostat.c pigs.c swap.c 
   Log:
   Consistently mark percentage scales as such.
   
   PR:             bin/101975
   MFC after:      3 days
   
   Revision  Changes    Path
   1.24      +2 -2      src/usr.bin/systat/iostat.c
   1.22      +1 -1      src/usr.bin/systat/pigs.c
   1.24      +1 -1      src/usr.bin/systat/swap.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: yar 
State-Changed-When: Fri Jan 5 13:33:18 UTC 2007 
State-Changed-Why:  
Fixed in CURRENT and STABLE.  Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=101975 
>Unformatted:
