From novel@FreeBSD.org  Sat Aug 12 16:23:10 2006
Return-Path: <novel@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 92F3A16A4F2
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 12 Aug 2006 16:23:10 +0000 (UTC)
	(envelope-from novel@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 490D343D4C
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 12 Aug 2006 16:23:10 +0000 (GMT)
	(envelope-from novel@FreeBSD.org)
Received: from freefall.freebsd.org (novel@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k7CGNAcJ032127
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 12 Aug 2006 16:23:10 GMT
	(envelope-from novel@freefall.freebsd.org)
Received: (from novel@localhost)
	by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k7CGNAvE032126;
	Sat, 12 Aug 2006 16:23:10 GMT
	(envelope-from novel)
Message-Id: <200608121623.k7CGNAvE032126@freefall.freebsd.org>
Date: Sat, 12 Aug 2006 16:23:10 GMT
From: Roman Bogorodskiy <novel@FreeBSD.org>
Reply-To: Roman Bogorodskiy <novel@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [pkg_install] fix pkg_version -Io coredump for packages with no ORIGIN
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         101932
>Category:       bin
>Synopsis:       [pkg_install] fix pkg_version -Io coredump for packages with no ORIGIN
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    krion
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Aug 12 16:30:17 GMT 2006
>Closed-Date:    Thu Aug 17 08:08:18 GMT 2006
>Last-Modified:  Thu Aug 17 08:08:18 GMT 2006
>Originator:     Roman Bogorodskiy
>Release:        FreeBSD 6.0-STABLE i386
>Organization:
>Environment:
System: FreeBSD freefall.freebsd.org 6.0-STABLE FreeBSD 6.0-STABLE #0: Sat Dec 10 03:18:20 UTC 2005 kensmith@freefall.freebsd.org:/usr/obj/usr/src/sys/FREEFALL i386


>Description:
	In '-Io' mode pkg_version(1) coredumps if some package has no
	origin because it tries to strlcpy NULL.

	Problem was spotted by sat@ and he provided the simular fix as well.
>How-To-Repeat:
>Fix:

--- pkg_version.diff begins here ---
Index: version/perform.c
===================================================================
RCS file: /home/ncvs/src/usr.sbin/pkg_install/version/perform.c,v
retrieving revision 1.15
diff -u -r1.15 perform.c
--- version/perform.c	12 Feb 2006 16:09:33 -0000	1.15
+++ version/perform.c	12 Aug 2006 16:16:59 -0000
@@ -259,7 +259,7 @@
 
     if (!plist.name || strlen(plist.name) == 0)
 	return;
-    if (ShowOrigin != FALSE)
+    if (ShowOrigin != FALSE && plist.origin != NULL)
 	strlcpy(tmp, plist.origin, PATH_MAX);
     else {
 	strlcpy(tmp, plist.name, PATH_MAX);
--- pkg_version.diff ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->krion 
Responsible-Changed-By: novel 
Responsible-Changed-When: Sat Aug 12 16:36:44 UTC 2006 
Responsible-Changed-Why:  
Over to maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=101932 
State-Changed-From-To: open->closed 
State-Changed-By: krion 
State-Changed-When: Thu Aug 17 08:08:17 UTC 2006 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=101932 
>Unformatted:
