From andrew@ugh.net.au  Mon Jul 17 15:51:21 2006
Return-Path: <andrew@ugh.net.au>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 9B1EB16A4DA;
	Mon, 17 Jul 2006 15:51:21 +0000 (UTC)
	(envelope-from andrew@ugh.net.au)
Received: from starbug.ugh.net.au (starbug.ugh.net.au [210.10.122.37])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 4A3CB43D46;
	Mon, 17 Jul 2006 15:51:20 +0000 (GMT)
	(envelope-from andrew@ugh.net.au)
Received: by starbug.ugh.net.au (Postfix, from userid 1000)
	id CB4F4386C0F; Tue, 18 Jul 2006 01:51:18 +1000 (EST)
Message-Id: <20060717155118.CB4F4386C0F@starbug.ugh.net.au>
Date: Tue, 18 Jul 2006 01:51:18 +1000 (EST)
From: Andrew Stevenson <andrew@ugh.net.au>
Reply-To: Andrew Stevenson <andrew@ugh.net.au>
To: FreeBSD-gnats-submit@freebsd.org
Cc: obrien@freebsd.org, mikeh@freebsd.org
Subject: lukemftpd core dumps on anonymous login
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         100442
>Category:       bin
>Synopsis:       ftpd(8): lukemftpd core dumps on anonymous login
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    obrien
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jul 17 16:00:34 GMT 2006
>Closed-Date:    Fri Mar 14 15:44:55 UTC 2014
>Last-Modified:  Fri Mar 14 15:44:55 UTC 2014
>Originator:     Andrew Stevenson
>Release:        FreeBSD 6.1-RELEASE i386
>Organization:
UgH!
>Environment:
System: FreeBSD starbug.ugh.net.au 6.1-RELEASE FreeBSD 6.1-RELEASE #0: Mon Jun 12 07:32:23 UTC 2006 root@jail.ugh.net.au:/usr/obj/usr/src/sys/KERNEL1 i386


	
>Description:

lukemftpd core dumps on anonymous login after accepting the password. What
seems to be happening is that the user function (ftpd.c:716) is called but we
hit the goto on line 786 and so skip the call to parse_conf on line 821. This
means that when we get to count_users (conf.c:883) (called from pass
(ftpd.c:1149)) curclass.classname is still NULL and the strlcat on line 892 of
conf.c causes a segfault.

The NetBSD code differs in that it doesn't have the goto though I haven't
tested to see if that avoids the problem. I'm not sure of the rationale for
the differing code - the comments seem to say the NetBSD code came from
FreeBSD originally.

>How-To-Repeat:

Added an ftp user and group. Shell set to nologin.
Added lukemftpd to inetd.conf with the flags "ftpd -ll -r -d"
Login via FTP as "ftp" with any password.

>Fix:

	


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->obrien 
Responsible-Changed-By: maxim 
Responsible-Changed-When: Tue Jul 18 12:39:36 UTC 2006 
Responsible-Changed-Why:  
Over to maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=100442 
State-Changed-From-To: open->closed 
State-Changed-By: maxim 
State-Changed-When: Fri Mar 14 15:44:21 UTC 2014 
State-Changed-Why:  
No lukemftpd in the base anymore. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=100442 
>Unformatted:
