From nobody@FreeBSD.org  Thu Jul 13 12:22:49 2006
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1660316A4DD
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 13 Jul 2006 12:22:49 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id D7D3443D72
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 13 Jul 2006 12:22:48 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k6DCMmX8006663
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 13 Jul 2006 12:22:48 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id k6DCMmPn006662;
	Thu, 13 Jul 2006 12:22:48 GMT
	(envelope-from nobody)
Message-Id: <200607131222.k6DCMmPn006662@www.freebsd.org>
Date: Thu, 13 Jul 2006 12:22:48 GMT
From: Dmitry Kazarov <kazarov@mcm.ru>
To: freebsd-gnats-submit@FreeBSD.org
Subject: pam_ssh works no more after introducing src/crypto/openssh/ssh_namespace.h
X-Send-Pr-Version: www-2.3

>Number:         100209
>Category:       bin
>Synopsis:       [pam] [patch] pam_ssh works no more after introducing src/crypto/openssh/ssh_namespace.h
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    des
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jul 13 12:30:14 GMT 2006
>Closed-Date:    Fri Jul 14 06:36:49 GMT 2006
>Last-Modified:  Fri Jul 14 06:36:49 GMT 2006
>Originator:     Dmitry Kazarov
>Release:        6.1-STABLE
>Organization:
Multicom Ltd, Moscow
>Environment:
FreeBSD kazarov.cds.ru 6.1-STABLE FreeBSD 6.1-STABLE #0: Thu Jul 13 12:29:13 MSD 2006     root@kazarov.cds.ru:/var/tmp/obj/usr/src/sys/CE  i386

>Description:
I had recompiled world today and login (1) became unworkable due to 
auth            sufficient      pam_ssh.so              no_warn try_first_pass
line in /etc/pam.d/system

Found that due to introduction of src/crypto/openssh/ssh_namespace.h some functions names were changed and loading of /usr/lib/pam_ssh.so failed with error 
/usr/lib/pam_ssh.so: Undefined symbol "key_load_private"

IMNO: linker should at least warn on unresolved external references while building shared object.


>How-To-Repeat:
uncomment ssh line in /etc/pam.d/system and try to login
>Fix:
--- pam_ssh.c.orig      Thu Jul 13 15:54:19 2006
+++ pam_ssh.c   Thu Jul 13 16:08:02 2006
@@ -56,6 +56,7 @@

 #include <openssl/evp.h>

+#include "ssh_namespace.h"
 #include "key.h"
 #include "authfd.h"
 #include "authfile.h"

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->des 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Thu Jul 13 23:24:30 UTC 2006 
Responsible-Changed-Why:  
Over to des who imported src/crypto/openssh/ssh_namespace.h. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=100209 
State-Changed-From-To: open->closed 
State-Changed-By: des 
State-Changed-When: Fri Jul 14 06:36:47 UTC 2006 
State-Changed-Why:  
I forgot part of the MFC.  Fixed now, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=100209 
>Unformatted:
