From nobody@FreeBSD.org  Wed Jul 12 12:48:43 2006
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5F7DA16A4DA
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 12 Jul 2006 12:48:43 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id F2EFB43D4C
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 12 Jul 2006 12:48:42 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k6CCmgDG038415
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 12 Jul 2006 12:48:42 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id k6CCmgbd038414;
	Wed, 12 Jul 2006 12:48:42 GMT
	(envelope-from nobody)
Message-Id: <200607121248.k6CCmgbd038414@www.freebsd.org>
Date: Wed, 12 Jul 2006 12:48:42 GMT
From: Patrick Wolfe <pwolfe@employease.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: mount ignoring "ro" option in fstab
X-Send-Pr-Version: www-2.3

>Number:         100164
>Category:       bin
>Synopsis:       mount(8) ignoring "ro" option in fstab
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    jmallett
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jul 12 12:50:16 GMT 2006
>Closed-Date:    Tue Oct 24 22:03:38 GMT 2006
>Last-Modified:  Wed Oct 25 13:40:20 GMT 2006
>Originator:     Patrick Wolfe
>Release:        7.0 CURRENT
>Organization:
Employease Inc
>Environment:
FreeBSD spank.tek.eease.com 7.0-CURRENT FreeBSD 7.0-CURRENT #0: Wed Jun 21 15:40:32 EDT 2006     root@spank.tek.eease.com:/usr/obj/usr/src/sys/SPANK  i386

>Description:
The "mount" command silently ignores the "ro" option when specified in the
fstab file.  This bug only exists in the development version of FreeBSD.  I
also tested 6.1 and 5.4, and they work fine.

Note: the "-r" and "-o ro" command line options are not affected, they work
fine.

>How-To-Repeat:
mkdir /foo
echo "/etc /foo nullfs ro 0 0" >> /etc/fstab
mount /foo
mount | grep foo
>Fix:

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-i386->rodrigc 
Responsible-Changed-By: arved 
Responsible-Changed-When: Thu Jul 13 11:23:03 UTC 2006 
Responsible-Changed-Why:  
Craig recently worked on mount 

http://www.freebsd.org/cgi/query-pr.cgi?pr=100164 
State-Changed-From-To: open->closed 
State-Changed-By: ru 
State-Changed-When: Tue Oct 24 22:02:55 UTC 2006 
State-Changed-Why:  
Fixed by backing the offending change. 


Responsible-Changed-From-To: rodrigc->jmallett 
Responsible-Changed-By: ru 
Responsible-Changed-When: Tue Oct 24 22:02:55 UTC 2006 
Responsible-Changed-Why:  
The offending change was made by Juli. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=100164 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/100164: commit references a PR
Date: Tue, 24 Oct 2006 22:02:48 +0000 (UTC)

 ru          2006-10-24 22:02:29 UTC
 
   FreeBSD src repository
 
   Modified files:
     sbin/mount           mount.c 
   Log:
   Revert rev. 1.86 by jmallett@ as it breaks "ro" mounts specified
   in /etc/fstab.
   
   This has been happening due to the priority inversion; options
   specified on the command line should take precedence over options
   from fstab over default "noro" option, but since both the default
   "noro" and options specified on the command line (-w, -r, -o ...)
   were put into the same "options" variable, "noro" took precedence
   over fstab "ro" (this is easily visible with "mount -d").
   
   PR:             bin/100164
   
   Revision  Changes    Path
   1.89      +32 -6     src/sbin/mount/mount.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: Craig Rodrigues <rodrigc@crodrigues.org>
To: Ruslan Ermilov <ru@FreeBSD.org>
Cc: pwolfe@employease.com, rodrigc@FreeBSD.org, jmallett@FreeBSD.org,
        bug-followup@FreeBSD.org
Subject: Re: bin/100164: mount(8) ignoring "ro" option in fstab
Date: Wed, 25 Oct 2006 09:37:56 -0400

 On Tue, Oct 24, 2006 at 10:03:36PM +0000, Ruslan Ermilov wrote:
 > Synopsis: mount(8) ignoring "ro" option in fstab
 > 
 > State-Changed-From-To: open->closed
 > State-Changed-By: ru
 > State-Changed-When: Tue Oct 24 22:02:55 UTC 2006
 > State-Changed-Why: 
 > Fixed by backing the offending change.
 
 Thanks Ruslan!
 -- 
 Craig Rodrigues        
 rodrigc@crodrigues.org
>Unformatted:
