From nobody@FreeBSD.org  Sun Jan 26 14:09:39 2014
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTPS id BF2CD1E4
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 26 Jan 2014 14:09:39 +0000 (UTC)
Received: from oldred.freebsd.org (oldred.freebsd.org [IPv6:2001:1900:2254:206a::50:4])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.freebsd.org (Postfix) with ESMTPS id AB19919E7
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 26 Jan 2014 14:09:39 +0000 (UTC)
Received: from oldred.freebsd.org ([127.0.1.6])
	by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id s0QE9d9q066256
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 26 Jan 2014 14:09:39 GMT
	(envelope-from nobody@oldred.freebsd.org)
Received: (from nobody@localhost)
	by oldred.freebsd.org (8.14.5/8.14.5/Submit) id s0QE9dRw066249;
	Sun, 26 Jan 2014 14:09:39 GMT
	(envelope-from nobody)
Message-Id: <201401261409.s0QE9dRw066249@oldred.freebsd.org>
Date: Sun, 26 Jan 2014 14:09:39 GMT
From: Takanori Sawada <tak.swd@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: ti mbox and pruss has params to mtx_init reversed
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         186129
>Category:       arm
>Synopsis:       ti mbox and pruss has params to mtx_init reversed
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-arm
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jan 26 14:10:00 UTC 2014
>Closed-Date:    Mon Jan 27 17:32:32 UTC 2014
>Last-Modified:  Mon Jan 27 17:40:00 UTC 2014
>Originator:     Takanori Sawada
>Release:        
>Organization:
>Environment:
FreeBSD Current
>Description:
Args are in wrong order to mtx_init(9)

(1)
http://svnweb.freebsd.org/base/head/sys/arm/ti/ti_mbox.c?revision=258209&view=markup#l143

now:
mtx_init(&sc->sc_mtx, "TI mbox", MTX_DEF, 0);

correct:
mtx_init(&sc->sc_mtx, "TI mbox", NULL, MTX_DEF);


(2)
http://svnweb.freebsd.org/base/head/sys/arm/ti/ti_pruss.c?revision=258210&view=markup#l169

now:
mtx_init(&sc->sc_mtx, "TI PRUSS", MTX_DEF, 0);

correct:
mtx_init(&sc->sc_mtx, "TI PRUSS", NULL, MTX_DEF);
>How-To-Repeat:

>Fix:


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: jmg 
State-Changed-When: Mon Jan 27 17:32:00 UTC 2014 
State-Changed-Why:  
commited..  Thanks for the report... 

http://www.freebsd.org/cgi/query-pr.cgi?pr=186129 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: arm/186129: commit references a PR
Date: Mon, 27 Jan 2014 17:31:29 +0000 (UTC)

 Author: jmg
 Date: Mon Jan 27 17:31:21 2014
 New Revision: 261211
 URL: http://svnweb.freebsd.org/changeset/base/261211
 
 Log:
   fix args to mtx_init
   
   Note that this commit hasn't been compile tested because these files
   are not hooked up to the build...
   
   PR:		186129
   Submitted by:	Takanori Sawada
   Approved by:	rpaulo
 
 Modified:
   head/sys/arm/ti/ti_mbox.c
   head/sys/arm/ti/ti_pruss.c
 
 Modified: head/sys/arm/ti/ti_mbox.c
 ==============================================================================
 --- head/sys/arm/ti/ti_mbox.c	Mon Jan 27 13:28:55 2014	(r261210)
 +++ head/sys/arm/ti/ti_mbox.c	Mon Jan 27 17:31:21 2014	(r261211)
 @@ -140,7 +140,7 @@ ti_mbox_attach(device_t dev)
  	}
  	sc = device_get_softc(dev);
  	rid = 0;
 -	mtx_init(&sc->sc_mtx, "TI mbox", MTX_DEF, 0);
 +	mtx_init(&sc->sc_mtx, "TI mbox", NULL, MTX_DEF);
  	sc->sc_mem_res = bus_alloc_resource_any(dev, SYS_RES_MEMORY, &rid,
  	    RF_ACTIVE);
  	if (sc->sc_mem_res == NULL) {
 
 Modified: head/sys/arm/ti/ti_pruss.c
 ==============================================================================
 --- head/sys/arm/ti/ti_pruss.c	Mon Jan 27 13:28:55 2014	(r261210)
 +++ head/sys/arm/ti/ti_pruss.c	Mon Jan 27 17:31:21 2014	(r261211)
 @@ -166,7 +166,7 @@ ti_pruss_attach(device_t dev)
  	}
  	sc = device_get_softc(dev);
  	rid = 0;
 -	mtx_init(&sc->sc_mtx, "TI PRUSS", MTX_DEF, 0);
 +	mtx_init(&sc->sc_mtx, "TI PRUSS", NULL, MTX_DEF);
  	sc->sc_mem_res = bus_alloc_resource_any(dev, SYS_RES_MEMORY, &rid,
  	    RF_ACTIVE);
  	if (sc->sc_mem_res == NULL) {
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
