From nobody@FreeBSD.org  Mon Feb 25 18:32:12 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	by hub.freebsd.org (Postfix) with ESMTP id 9BC84786
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 25 Feb 2013 18:32:12 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 8CC07DEE
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 25 Feb 2013 18:32:12 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.5/8.14.5) with ESMTP id r1PIWBZl086570
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 25 Feb 2013 18:32:11 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.5/8.14.5/Submit) id r1PIWBqO086569;
	Mon, 25 Feb 2013 18:32:11 GMT
	(envelope-from nobody)
Message-Id: <201302251832.r1PIWBqO086569@red.freebsd.org>
Date: Mon, 25 Feb 2013 18:32:11 GMT
From: Josef Larsson <josla972@student.liu.se>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Compiler warning, TARGET_ARCH=armv6, make MALLOC_PRODUCTION=yes buildworld
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         176424
>Category:       arm
>Synopsis:       Compiler warning, TARGET_ARCH=armv6, make MALLOC_PRODUCTION=yes buildworld
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-arm
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Feb 25 18:40:00 UTC 2013
>Closed-Date:    Wed Sep 11 18:15:20 UTC 2013
>Last-Modified:  Wed Sep 11 18:15:20 UTC 2013
>Originator:     Josef Larsson
>Release:        FreeBSD server 9.1-RELEASE
>Organization:
>Environment:
FreeBSD server 9.1-RELEASE FreeBSD 9.1-RELEASE #0 r243825: Tue Dec  4 09:23:10 UTC 2012     root@farrell.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
When doing make MALLOC_PRODUCTION=yes buildworld, a compiler warning will be issued which halts compilation. The warning is issued because line 463 of head/sbin/fsck_ffs/fsutil.c uses "%ld" and "%lld", for variables of type time_t, which I think are of the type int in this case when compiling for armv6. 
>How-To-Repeat:
Following this guide to step 13 should do the trick:
http://ogris.de/howtos/freebsd-raspberry.html
>Fix:
Typecasting like this solved the problem:

printf("%21s:%8ld %2ld.%ld%% %8lld msec %2lld.%lld%%\n", buftype[i], (long)readcnt[i], (long) readcnt[i] * 100 / diskreads, (long) (readcnt[i] * 1000 / diskreads) % 10, (long long) msec, (long long) msec * 100 / totalmsec, (long long) (msec * 1000 / totalmsec) % 10);

>Release-Note:
>Audit-Trail:

From: Ian Lepore <ian@FreeBSD.org>
To: Josef Larsson <josla972@student.liu.se>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: arm/176424: Compiler warning, TARGET_ARCH=armv6, make
 MALLOC_PRODUCTION=yes buildworld
Date: Mon, 25 Feb 2013 12:08:22 -0700

 On Mon, 2013-02-25 at 18:32 +0000, Josef Larsson wrote:
 > >Number:         176424
 > >Category:       arm
 > >Synopsis:       Compiler warning, TARGET_ARCH=armv6, make MALLOC_PRODUCTION=yes buildworld
 > >Confidential:   no
 > >Severity:       non-critical
 > >Priority:       low
 > >Responsible:    freebsd-arm
 > >State:          open
 > >Quarter:        
 > >Keywords:       
 > >Date-Required:
 > >Class:          sw-bug
 > >Submitter-Id:   current-users
 > >Arrival-Date:   Mon Feb 25 18:40:00 UTC 2013
 > >Closed-Date:
 > >Last-Modified:
 > >Originator:     Josef Larsson
 > >Release:        FreeBSD server 9.1-RELEASE
 > >Organization:
 > >Environment:
 > FreeBSD server 9.1-RELEASE FreeBSD 9.1-RELEASE #0 r243825: Tue Dec  4 09:23:10 UTC 2012     root@farrell.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64
 > >Description:
 > When doing make MALLOC_PRODUCTION=yes buildworld, a compiler warning will be issued which halts compilation. The warning is issued because line 463 of head/sbin/fsck_ffs/fsutil.c uses "%ld" and "%lld", for variables of type time_t, which I think are of the type int in this case when compiling for armv6. 
 > >How-To-Repeat:
 > Following this guide to step 13 should do the trick:
 > http://ogris.de/howtos/freebsd-raspberry.html
 > >Fix:
 > Typecasting like this solved the problem:
 > 
 > printf("%21s:%8ld %2ld.%ld%% %8lld msec %2lld.%lld%%\n", buftype[i], (long)readcnt[i], (long) readcnt[i] * 100 / diskreads, (long) (readcnt[i] * 1000 / diskreads) % 10, (long long) msec, (long long) msec * 100 / totalmsec, (long long) (msec * 1000 / totalmsec) % 10);
 
 FYI, this was fixed with r247269.
 
 Also, there's no need to use MALLOC_PRODUCTION anymore, a change about a
 month ago fixed the performance and memory-hogging problems.
 
 -- Ian
 
 
State-Changed-From-To: open->closed 
State-Changed-By: loos 
State-Changed-When: Wed Sep 11 18:15:13 UTC 2013 
State-Changed-Why:  
Closing this PR.  The issue was fixed in r247269.  Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=176424 
>Unformatted:
