From ga9@buffy.york.ac.uk  Wed Apr 29 14:10:25 2009
Return-Path: <ga9@buffy.york.ac.uk>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5133B106564A
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 29 Apr 2009 14:10:25 +0000 (UTC)
	(envelope-from ga9@buffy.york.ac.uk)
Received: from mail-gw0.york.ac.uk (mail-gw0.york.ac.uk [144.32.128.245])
	by mx1.freebsd.org (Postfix) with ESMTP id C25728FC08
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 29 Apr 2009 14:10:24 +0000 (UTC)
	(envelope-from ga9@buffy.york.ac.uk)
Received: from mail-gw6.york.ac.uk (mail-gw6.york.ac.uk [144.32.129.26])
	by mail-gw0.york.ac.uk (8.13.6/8.13.6) with ESMTP id n3TDd1Nk009166
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 29 Apr 2009 14:39:01 +0100 (BST)
Received: from buffy-128.york.ac.uk ([144.32.128.160] helo=buffy.york.ac.uk)
	by mail-gw6.york.ac.uk with esmtps (TLSv1:AES256-SHA:256)
	(Exim 4.68)
	(envelope-from <ga9@buffy.york.ac.uk>)
	id 1LzA04-0004k0-QK
	for FreeBSD-gnats-submit@freebsd.org; Wed, 29 Apr 2009 14:39:00 +0100
Received: from buffy.york.ac.uk (localhost [127.0.0.1])
	by buffy.york.ac.uk (8.14.3/8.14.3) with ESMTP id n3TDd0Ia095740
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 29 Apr 2009 14:39:00 +0100 (BST)
	(envelope-from ga9@buffy.york.ac.uk)
Received: (from ga9@localhost)
	by buffy.york.ac.uk (8.14.3/8.14.3/Submit) id n3TDd0jw095739;
	Wed, 29 Apr 2009 14:39:00 +0100 (BST)
	(envelope-from ga9)
Message-Id: <200904291339.n3TDd0jw095739@buffy.york.ac.uk>
Date: Wed, 29 Apr 2009 14:39:00 +0100 (BST)
From: Gavin Atkinson <gavin@freebsd.org>
Reply-To: Gavin Atkinson <gavin@freebsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [patch] NSLU.hints contains wrong hints for on board npe(4) NIC
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         134092
>Category:       arm
>Synopsis:       [patch] NSLU.hints contains wrong hints for on board npe(4) NIC
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    cognet
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Apr 29 14:20:01 UTC 2009
>Closed-Date:    Fri Dec 06 22:20:21 UTC 2013
>Last-Modified:  Fri Dec 06 22:20:21 UTC 2013
>Originator:     Gavin Atkinson
>Release:        FreeBSD 7.1-STABLE amd64
>Organization:
>Environment:
System: FreeBSD buffy.york.ac.uk 7.1-STABLE FreeBSD 7.1-STABLE #5: Fri Feb 13 11:25:58 GMT 2009 root@buffy.york.ac.uk:/usr/obj/usr/src/sys/GENERIC amd64

>Description:
	The NSLU kernel will fail to find the associated PHYs.  The
attached patch fixes this for both me, and for the user in
http://lists.freebsd.org/pipermail/freebsd-arm/2009-April/001649.html

The patch also removes the PHY/MAC hints for npe1 - all that is required
is the single "at" hint, and not the full config.

While here, fix a comment.

>How-To-Repeat:
	Presumably, just try booting on an NSLU2.
>Fix:

--- NSLU.hints.diff begins here ---
Index: src-head/sys/arm/conf/NSLU.hints
===================================================================
RCS file: /home/ncvs/src/sys/arm/conf/NSLU.hints,v
retrieving revision 1.1
diff -u -r1.1 NSLU.hints
--- src-head/sys/arm/conf/NSLU.hints	3 Aug 2008 07:10:25 -0000	1.1
+++ src-head/sys/arm/conf/NSLU.hints	27 Jan 2009 16:06:24 -0000
@@ -17,17 +17,17 @@
 # NPE Hardware Queue Manager
 hint.ixpqmgr.0.at="ixp0"
 
-# NPE wireless NIC's, requires ixpqmgr
+# NPE wired NICs, requires ixpqmgr
 hint.npe.0.at="ixp0"
-hint.npe.0.mac="A"
-hint.npe.0.mii="A"
+hint.npe.0.mac="B"
+hint.npe.0.mii="B"
 hint.npe.0.phy=1
 # The second MAC isn't used on the NSLU, but it needs to be configured or
 # we timeout on dhcp packets
 hint.npe.1.at="ixp0"
-hint.npe.1.mac="B"
-hint.npe.1.mii="A"
-hint.npe.1.phy=0
+#hint.npe.1.mac="B"
+#hint.npe.1.mii="A"
+#hint.npe.1.phy=0
 
 #not yet
 # RTC
--- NSLU.hints.diff ends here ---


>Release-Note:
>Audit-Trail:

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: arm/134092: commit references a PR
Date: Wed,  6 May 2009 20:24:27 +0000 (UTC)

 Author: cognet
 Date: Wed May  6 20:24:17 2009
 New Revision: 191858
 URL: http://svn.freebsd.org/changeset/base/191858
 
 Log:
   Use the good hints for the NSLU, it should fix the network adapter.
   
   PR:		arm/134092
   Submitted by:	gavin
 
 Modified:
   head/sys/arm/conf/NSLU.hints
 
 Modified: head/sys/arm/conf/NSLU.hints
 ==============================================================================
 --- head/sys/arm/conf/NSLU.hints	Wed May  6 20:07:28 2009	(r191857)
 +++ head/sys/arm/conf/NSLU.hints	Wed May  6 20:24:17 2009	(r191858)
 @@ -17,17 +17,17 @@ hint.uart.1.irq=13
  # NPE Hardware Queue Manager
  hint.ixpqmgr.0.at="ixp0"
  
 -# NPE wireless NIC's, requires ixpqmgr
 +# NPE wired NICs, requires ixpqmgr
  hint.npe.0.at="ixp0"
 -hint.npe.0.mac="A"
 -hint.npe.0.mii="A"
 +hint.npe.0.mac="B"
 +hint.npe.0.mii="B"
  hint.npe.0.phy=1
  # The second MAC isn't used on the NSLU, but it needs to be configured or
  # we timeout on dhcp packets
  hint.npe.1.at="ixp0"
 -hint.npe.1.mac="B"
 -hint.npe.1.mii="A"
 -hint.npe.1.phy=0
 +#hint.npe.1.mac="B"
 +#hint.npe.1.mii="A"
 +#hint.npe.1.phy=0
  
  #not yet
  # RTC
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->patched 
State-Changed-By: gavin 
State-Changed-When: Sat Mar 20 14:45:53 UTC 2010 
State-Changed-Why:  
Fixed in head and stable/8 


Responsible-Changed-From-To: freebsd-arm->cognet 
Responsible-Changed-By: gavin 
Responsible-Changed-When: Sat Mar 20 14:45:53 UTC 2010 
Responsible-Changed-Why:  
Over to cognet as MFC reminder 

http://www.freebsd.org/cgi/query-pr.cgi?pr=134092 
State-Changed-From-To: patched->closed 
State-Changed-By: cognet 
State-Changed-When: Fri Dec 6 22:20:21 UTC 2013 
State-Changed-Why:  
The fix is in all supported releases 

http://www.freebsd.org/cgi/query-pr.cgi?pr=134092 
>Unformatted:
