From nobody@FreeBSD.org  Sat Nov 15 21:02:47 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 96468106567F
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 15 Nov 2008 21:02:47 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 862D98FC13
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 15 Nov 2008 21:02:47 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id mAFL2khj011192
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 15 Nov 2008 21:02:46 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id mAFL2kLY011191;
	Sat, 15 Nov 2008 21:02:46 GMT
	(envelope-from nobody)
Message-Id: <200811152102.mAFL2kLY011191@www.freebsd.org>
Date: Sat, 15 Nov 2008 21:02:46 GMT
From: Pankov Pavel <pankov_p@mail.ru>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] Failture to build arm kernel with "options KTR"
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         128897
>Category:       arm
>Synopsis:       [PATCH] Failture to build arm kernel with "options KTR"
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    stas
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Nov 15 21:10:06 UTC 2008
>Closed-Date:    Sun Nov 30 22:58:39 UTC 2008
>Last-Modified:  Sun Jan 18 11:50:01 UTC 2009
>Originator:     Pankov Pavel
>Release:        8.0-CURRENT
>Organization:
MPEI
>Environment:
FreeBSD tionfather 8.0-CURRENT FreeBSD 8.0-CURRENT #0: Wed Oct 29 13:12:21 MSK 2008 root@tionfather:/usr/obj/usr/src/sys/TIONFATHER i386
>Description:
Building ktr(4)-enabled ARM kernel results in error because of use of undefined variable Maxmem in _bus_dmamap_count_pages function.
>How-To-Repeat:
Add "options KTR" to any ARM kernel config try building kernel.
>Fix:
Apply the attached patch.

Patch attached with submission follows:

Index: sys/arm/arm/busdma_machdep.c
===================================================================
RCS file: /home/ncvs/src/sys/arm/arm/busdma_machdep.c,v
retrieving revision 1.39
diff -u -r1.39 busdma_machdep.c
--- sys/arm/arm/busdma_machdep.c	13 Oct 2008 18:59:59 -0000	1.39
+++ sys/arm/arm/busdma_machdep.c	15 Nov 2008 15:35:46 -0000
@@ -673,8 +673,8 @@
 	bus_addr_t paddr;
 
 	if ((map->pagesneeded == 0)) {
-		CTR4(KTR_BUSDMA, "lowaddr= %d Maxmem= %d, boundary= %d, "
-		    "alignment= %d", dmat->lowaddr, ptoa((vm_paddr_t)Maxmem),
+		CTR3(KTR_BUSDMA, "lowaddr= %d, boundary= %d, "
+		    "alignment= %d", dmat->lowaddr,
 		    dmat->boundary, dmat->alignment);
 		CTR2(KTR_BUSDMA, "map= %p, pagesneeded= %d",
 		    map, map->pagesneeded);


>Release-Note:
>Audit-Trail:

From: Stanislav Sedov <stas@FreeBSD.org>
To: Pankov Pavel <pankov_p@mail.ru>
Cc: bug-followup@FreeBSD.org
Subject: Re: arm/128897: [PATCH] Failture to build arm kernel with
 "options KTR"
Date: Sun, 16 Nov 2008 12:33:05 +0300

 -----BEGIN PGP SIGNED MESSAGE-----
 Hash: SHA1
 
 On Sat, 15 Nov 2008 21:02:46 GMT
 Pankov Pavel <pankov_p@mail.ru> mentioned:
 
 > Building ktr(4)-enabled ARM kernel results in error because of use of undefined variable Maxmem in _bus_dmamap_count_pages function.
 
 Have you checked KTR works at all on ARM kernels?
 
 - -- 
 Stanislav Sedov
 ST4096-RIPE
 -----BEGIN PGP SIGNATURE-----
 
 iEYEARECAAYFAkkf6NYACgkQK/VZk+smlYEt2QCdEFc9tg8xyKxzN66RFg5xE+9G
 PCYAnRfyo4kWugPNaEEyCH6o9SweU2/a
 =6nZH
 -----END PGP SIGNATURE-----

Date: Sun, 16 Nov 2008 13:53:59 +0300
From: =?koi8-r?Q?=F0=C1=D7=C5=CC_=F0=C1=CE=CB=CF=D7?= <pankov_p@mail.ru>
To: Stanislav Sedov <stas@FreeBSD.org>
In-Reply-To: <20081116123305.49cf9838.stas@FreeBSD.org>
Subject: =?koi8-r?Q?Re[2]=3A_arm/128897=3A_[PATCH]_Failture_to_build_arm_kernel_with=22options_KTR=22?=

 > Have you checked KTR works at all on ARM kernels?

 Yes, at least verbose and DDB modes work without any problems.
Responsible-Changed-From-To: freebsd-arm->stas 
Responsible-Changed-By: stas 
Responsible-Changed-When: Sun Nov 30 22:50:37 UTC 2008 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=128897 
State-Changed-From-To: open->closed 
State-Changed-By: stas 
State-Changed-When: Sun Nov 30 22:58:38 UTC 2008 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=128897 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: arm/128897: commit references a PR
Date: Sun, 18 Jan 2009 11:43:35 +0000 (UTC)

 Author: stas
 Date: Sun Jan 18 11:43:23 2009
 New Revision: 187385
 URL: http://svn.freebsd.org/changeset/base/187385
 
 Log:
   - Merge r185494:
     Get rid of unused variable in KTR checks. This allows ktr(4) enabled
     ARM kernel to compile.
   
   PR:		rm/128897
   Submitted by:	Pankov Pavel <pankov_p@mail.ru>
 
 Modified:
   stable/7/sys/   (props changed)
   stable/7/sys/arm/arm/busdma_machdep.c
   stable/7/sys/contrib/pf/   (props changed)
   stable/7/sys/dev/ath/ath_hal/   (props changed)
   stable/7/sys/dev/cxgb/   (props changed)
 
 Modified: stable/7/sys/arm/arm/busdma_machdep.c
 ==============================================================================
 --- stable/7/sys/arm/arm/busdma_machdep.c	Sun Jan 18 11:38:35 2009	(r187384)
 +++ stable/7/sys/arm/arm/busdma_machdep.c	Sun Jan 18 11:43:23 2009	(r187385)
 @@ -671,9 +671,8 @@ _bus_dmamap_count_pages(bus_dma_tag_t dm
  	bus_addr_t paddr;
  
  	if ((map->pagesneeded == 0)) {
 -		CTR4(KTR_BUSDMA, "lowaddr= %d Maxmem= %d, boundary= %d, "
 -		    "alignment= %d", dmat->lowaddr, ptoa((vm_paddr_t)Maxmem),
 -		    dmat->boundary, dmat->alignment);
 +		CTR3(KTR_BUSDMA, "lowaddr= %d, boundary= %d, alignment= %d",
 +		    dmat->lowaddr, dmat->boundary, dmat->alignment);
  		CTR2(KTR_BUSDMA, "map= %p, pagesneeded= %d",
  		    map, map->pagesneeded);
  		/*
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
