From bkoenig@alpha-tierchen.de  Fri Feb 29 23:29:10 2008
Return-Path: <bkoenig@alpha-tierchen.de>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 32BCD1065674
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 29 Feb 2008 23:29:10 +0000 (UTC)
	(envelope-from bkoenig@alpha-tierchen.de)
Received: from mail.liberty-hosting.de (mail.smartterra.de [195.225.132.203])
	by mx1.freebsd.org (Postfix) with ESMTP id EA3238FC19
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 29 Feb 2008 23:29:09 +0000 (UTC)
	(envelope-from bkoenig@alpha-tierchen.de)
Received: from home.alpha-tierchen.de (port-212-202-40-215.dynamic.qsc.de [212.202.40.215])
	by mail.liberty-hosting.de (Postfix) with ESMTP id E590B3E99D3;
	Sat,  1 Mar 2008 00:27:35 +0100 (CET)
Received: from muhkuh.lan (muhkuh.lan [192.168.1.2])
	by home.alpha-tierchen.de (Postfix) with SMTP id C177D288A8;
	Sat,  1 Mar 2008 00:29:07 +0100 (CET)
Received: by muhkuh.lan (sSMTP sendmail emulation); Sat,  1 Mar 2008 00:29:09 +0100
Message-Id: <20080229232907.C177D288A8@home.alpha-tierchen.de>
Date: Sat,  1 Mar 2008 00:29:09 +0100
From: "Bjrn Knig" <bkoenig@alpha-tierchen.de>
Reply-To: Bjrn Knig <bkoenig@alpha-tierchen.de>
To: FreeBSD-gnats-submit@freebsd.org
Cc: cognet@freebsd.org
Subject: Promiscuous mode of if_ate (arm) doesn't work
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         121242
>Category:       arm
>Synopsis:       [ate] [patch] Promiscuous mode of if_ate (arm) doesn't work
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    ticso
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Feb 29 23:30:02 UTC 2008
>Closed-Date:    Mon Mar 01 11:14:18 UTC 2010
>Last-Modified:  Mon Mar 01 11:14:18 UTC 2010
>Originator:     Bjrn Knig
>Release:        
>Organization:
>Environment:

>Description:
	The ate network interface driver doesn't respect
	the promiscuous mode setting yet.
>How-To-Repeat:
>Fix:

--- src-sys-arm-at91-if_ate.c.diff begins here ---
--- src/sys/arm/at91/if_ate.c.orig	2008-03-01 00:20:35.000000000 +0100
+++ arc/sys/arm/at91/if_ate.c	2008-03-01 00:23:29.000000000 +0100
@@ -740,6 +740,14 @@
 		WR4(sc, ETH_CFG, RD4(sc, ETH_CFG) & ~ETH_CFG_RMII);
 
 	/*
+	 * Enable or disable the promiscuous mode.
+	 */
+	if (ifp->if_flags & IFF_PROMISC)
+		WR4(sc, ETH_CFG, RD4(sc, ETH_CFG) | ETH_CFG_CAF);
+	else
+		WR4(sc, ETH_CFG, RD4(sc, ETH_CFG) & ~ETH_CFG_CAF);
+
+	/*
 	 * Turn on the multicast hash, and write 0's to it.
 	 */
 	WR4(sc, ETH_CFG, RD4(sc, ETH_CFG) | ETH_CFG_MTI);
--- src-sys-arm-at91-if_ate.c.diff ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-net 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Sat Mar 1 14:23:11 UTC 2008 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=121242 
Responsible-Changed-From-To: freebsd-net->freebsd-arm 
Responsible-Changed-By: gavin 
Responsible-Changed-When: Sat Jun 21 13:10:35 UTC 2008 
Responsible-Changed-Why:  
Over to -arm@ mailing list for consideration 

http://www.freebsd.org/cgi/query-pr.cgi?pr=121242 
Responsible-Changed-From-To: freebsd-arm->ticso 
Responsible-Changed-By: ticso 
Responsible-Changed-When: Sat Jun 21 14:40:49 UTC 2008 
Responsible-Changed-Why:  
I'll take this. 
I also have a similar patch in my queue which handles broken multicast 
with this driver. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=121242 
State-Changed-From-To: open->closed 
State-Changed-By: ticso 
State-Changed-When: Mon Mar 1 11:12:06 UTC 2010 
State-Changed-Why:  
Broadcast is working in the meantime because of a major 
rework done by stass@. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=121242 
>Unformatted:
