From nge@cs.hmc.edu  Wed Sep  7 23:48:19 2005
Return-Path: <nge@cs.hmc.edu>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 47A5416A41F
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  7 Sep 2005 23:48:19 +0000 (GMT)
	(envelope-from nge@cs.hmc.edu)
Received: from smtp109.sbc.mail.mud.yahoo.com (smtp109.sbc.mail.mud.yahoo.com [68.142.198.208])
	by mx1.FreeBSD.org (Postfix) with SMTP id CD92E43D4C
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  7 Sep 2005 23:48:18 +0000 (GMT)
	(envelope-from nge@cs.hmc.edu)
Received: (qmail 81909 invoked from network); 7 Sep 2005 23:48:18 -0000
Received: from unknown (HELO mercury.lan) (nattylite@sbcglobal.net@63.206.48.153 with login)
  by smtp109.sbc.mail.mud.yahoo.com with SMTP; 7 Sep 2005 23:48:18 -0000
Received: from mercury.lan (localhost [127.0.0.1])
	by mercury.lan (8.13.3/8.13.3) with ESMTP id j87NmFAb077699
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 7 Sep 2005 16:48:15 -0700 (PDT)
	(envelope-from nate@mercury.lan)
Received: (from nate@localhost)
	by mercury.lan (8.13.3/8.13.3/Submit) id j87NmFP1077698;
	Wed, 7 Sep 2005 16:48:15 -0700 (PDT)
	(envelope-from nate)
Message-Id: <200509072348.j87NmFP1077698@mercury.lan>
Date: Wed, 7 Sep 2005 16:48:15 -0700 (PDT)
From: Nate Eldredge <nge@cs.hmc.edu>
Reply-To: Nate Eldredge <nge@cs.hmc.edu>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Typo in amd64 machine/specialreg.h
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         85852
>Category:       amd64
>Synopsis:       Typo in amd64 machine/specialreg.h
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-amd64
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Sep 07 23:50:10 GMT 2005
>Closed-Date:    Sat Oct 15 00:46:11 GMT 2005
>Last-Modified:  Sat Oct 15 00:46:11 GMT 2005
>Originator:     Nate Eldredge
>Release:        FreeBSD 5.4-RELEASE-p6
>Organization:
>Environment:
System: FreeBSD vulcan.lan 5.4-RELEASE-p6 FreeBSD 5.4-RELEASE-p6 #0: Sun Sep  4 02:52:11 PDT 2005     nate@vulcan.lan:/usr/obj/usr/src/sys/VULCAN  amd64
>Description:
There is a mistake in <machine/specialregs.h> on amd64.  The addresses of
the MSR_MC3_* and MSR_MC4_* machine check registers are reversed.

This would be an issue if somebody implements MCA support someday.  I
have been playing with this a little myself.
>How-To-Repeat:
Compare <machine/specialregs.h> with AMD's documentation.
>Fix:

--- sys/amd64/include/specialreg.h.orig	Wed Sep  7 13:19:24 2005
+++ sys/amd64/include/specialreg.h	Wed Sep  7 13:20:03 2005
@@ -198,14 +198,14 @@
 #define MSR_MC2_STATUS		0x409
 #define MSR_MC2_ADDR		0x40a
 #define MSR_MC2_MISC		0x40b
-#define MSR_MC4_CTL		0x40c
-#define MSR_MC4_STATUS		0x40d
-#define MSR_MC4_ADDR		0x40e
-#define MSR_MC4_MISC		0x40f
-#define MSR_MC3_CTL		0x410
-#define MSR_MC3_STATUS		0x411
-#define MSR_MC3_ADDR		0x412
-#define MSR_MC3_MISC		0x413
+#define MSR_MC3_CTL		0x40c
+#define MSR_MC3_STATUS		0x40d
+#define MSR_MC3_ADDR		0x40e
+#define MSR_MC3_MISC		0x40f
+#define MSR_MC4_CTL		0x410
+#define MSR_MC4_STATUS		0x411
+#define MSR_MC4_ADDR		0x412
+#define MSR_MC4_MISC		0x413
 
 /*
  * Constants related to MSR's.


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: jkim 
State-Changed-When: Sat Oct 15 00:45:37 GMT 2005 
State-Changed-Why:  
Committed.  Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=85852 
>Unformatted:
