From nobody@FreeBSD.org  Tue Jun  8 13:03:26 2004
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id AD0C016A4CE
	for <freebsd-gnats-submit@FreeBSD.org>; Tue,  8 Jun 2004 13:03:26 +0000 (GMT)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id A7EEA43D45
	for <freebsd-gnats-submit@FreeBSD.org>; Tue,  8 Jun 2004 13:03:26 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.12.11/8.12.11) with ESMTP id i58D3Hx6050821
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 8 Jun 2004 13:03:17 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.12.11/8.12.11/Submit) id i58D3HKu050819;
	Tue, 8 Jun 2004 13:03:17 GMT
	(envelope-from nobody)
Message-Id: <200406081303.i58D3HKu050819@www.freebsd.org>
Date: Tue, 8 Jun 2004 13:03:17 GMT
From: Willem Jan Withagen <wjw@withagen.nl>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Extra informal text when trying to dump but dumpdev is not set.
X-Send-Pr-Version: www-2.3

>Number:         67712
>Category:       amd64
>Synopsis:       Extra informal text when trying to dump but dumpdev is not set.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    julian
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jun 08 13:10:17 GMT 2004
>Closed-Date:    Mon Jul 19 18:04:28 GMT 2004
>Last-Modified:  Mon Jul 19 18:04:28 GMT 2004
>Originator:     Willem Jan Withagen
>Release:        5.2-CURRENT
>Organization:
Digiware
>Environment:
FreeBSD opteron.digiware.nl 5.2-CURRENT FreeBSD 5.2-CURRENT #22: Tue Jun  8 13:44:17 CEST 2004     wjw@opteron.digiware.nl:/usr/obj/home2/src/sys/OPTERON.amd64  amd64
      
>Description:
Calling doadump without dumpdev set claims that the partition was too small. Well it worse, it did not exist.
This patch gives a better diagnostic.
It might also be usefull with i386 ea.      
>How-To-Repeat:
      
>Fix:
--- sys/amd64/amd64/dump_machdep.c.org  Tue Jun  8 14:56:49 2004
+++ sys/amd64/amd64/dump_machdep.c      Tue Jun  8 14:56:00 2004
@@ -85,6 +85,8 @@
        if (di->mediasize <
            Maxmem * (off_t)PAGE_SIZE + sizeof kdh * 2 + 64*1024) {
                printf("\nDump failed. Partition too small.\n");
+               if (di->mediasize == 0 )
+                   printf("Partition to dump on is not set. See dumpon(8)\n");
                return;
        }
        dumplo = di->mediaoffset + di->mediasize - Maxmem * (off_t)PAGE_SIZE;
      
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-amd64->julian 
Responsible-Changed-By: dannyboy 
Responsible-Changed-When: Sat Jul 17 00:27:03 GMT 2004 
Responsible-Changed-Why:  
julian added the check in question, before this file was amd64. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=67712 
State-Changed-From-To: open->closed 
State-Changed-By: julian 
State-Changed-When: Mon Jul 19 18:03:22 GMT 2004 
State-Changed-Why:  
Applied a patch that does effectively the same thing. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=67712 
>Unformatted:
