From nobody@FreeBSD.org  Thu Mar 27 05:39:02 2014
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTPS id 03136867
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 27 Mar 2014 05:39:02 +0000 (UTC)
Received: from cgiserv.freebsd.org (cgiserv.freebsd.org [IPv6:2001:1900:2254:206a::50:4])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client did not present a certificate)
	by mx1.freebsd.org (Postfix) with ESMTPS id E4B68F5C
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 27 Mar 2014 05:39:01 +0000 (UTC)
Received: from cgiserv.freebsd.org ([127.0.1.6])
	by cgiserv.freebsd.org (8.14.8/8.14.8) with ESMTP id s2R5d1Cl048644
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 27 Mar 2014 05:39:01 GMT
	(envelope-from nobody@cgiserv.freebsd.org)
Received: (from nobody@localhost)
	by cgiserv.freebsd.org (8.14.8/8.14.8/Submit) id s2R5d1Jw048641;
	Thu, 27 Mar 2014 05:39:01 GMT
	(envelope-from nobody)
Message-Id: <201403270539.s2R5d1Jw048641@cgiserv.freebsd.org>
Date: Thu, 27 Mar 2014 05:39:01 GMT
From: Takuya ASADA <syuu@freebsd.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: madt_parse_nmi() checking incorrect flag
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         188010
>Category:       amd64
>Synopsis:       madt_parse_nmi() checking incorrect flag
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-amd64
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Mar 27 05:40:00 UTC 2014
>Closed-Date:    Thu Mar 27 06:09:41 UTC 2014
>Last-Modified:  Thu Mar 27 06:10:00 UTC 2014
>Originator:     Takuya ASADA
>Release:        -CURRENT
>Organization:
Cloudius Systems
>Environment:
>Description:
madt_parse_nmi() checks ACPI_MADT_TRIGGER_CONFORMS before calling ioapic_set_polarity(), but it should check ACPI_MADT_POLARITY_CONFORMS instead.
I suppose this is typo.
>How-To-Repeat:
I haven't get any problem from this bug
>Fix:


Patch attached with submission follows:

diff --git a/sys/x86/acpica/madt.c b/sys/x86/acpica/madt.c
index 9dfb77f..3e8aee5 100644
--- a/sys/x86/acpica/madt.c
+++ b/sys/x86/acpica/madt.c
@@ -492,7 +492,7 @@ madt_parse_nmi(ACPI_MADT_NMI_SOURCE *nmi)
 	if (!(nmi->IntiFlags & ACPI_MADT_TRIGGER_CONFORMS))
 		ioapic_set_triggermode(ioapic, pin,
 		    interrupt_trigger(nmi->IntiFlags, 0));
-	if (!(nmi->IntiFlags & ACPI_MADT_TRIGGER_CONFORMS))
+	if (!(nmi->IntiFlags & ACPI_MADT_POLARITY_CONFORMS))
 		ioapic_set_polarity(ioapic, pin,
 		    interrupt_polarity(nmi->IntiFlags, 0));
 }


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: takawata 
State-Changed-When: Thu Mar 27 06:08:55 UTC 2014 
State-Changed-Why:  
Committed, thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=188010 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: amd64/188010: commit references a PR
Date: Thu, 27 Mar 2014 06:08:09 +0000 (UTC)

 Author: takawata
 Date: Thu Mar 27 06:08:07 2014
 New Revision: 263794
 URL: http://svnweb.freebsd.org/changeset/base/263794
 
 Log:
   To check polarity, check ACPI_MADT_POLARITY_CONFORMS, instead of ACPI_MADT_TRIGGER_CONFORMS.
   
   PR:amd64/188010
   Submitted by: syuu
 
 Modified:
   head/sys/x86/acpica/madt.c
 
 Modified: head/sys/x86/acpica/madt.c
 ==============================================================================
 --- head/sys/x86/acpica/madt.c	Thu Mar 27 04:30:07 2014	(r263793)
 +++ head/sys/x86/acpica/madt.c	Thu Mar 27 06:08:07 2014	(r263794)
 @@ -492,7 +492,7 @@ madt_parse_nmi(ACPI_MADT_NMI_SOURCE *nmi
  	if (!(nmi->IntiFlags & ACPI_MADT_TRIGGER_CONFORMS))
  		ioapic_set_triggermode(ioapic, pin,
  		    interrupt_trigger(nmi->IntiFlags, 0));
 -	if (!(nmi->IntiFlags & ACPI_MADT_TRIGGER_CONFORMS))
 +	if (!(nmi->IntiFlags & ACPI_MADT_POLARITY_CONFORMS))
  		ioapic_set_polarity(ioapic, pin,
  		    interrupt_polarity(nmi->IntiFlags, 0));
  }
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
