Post 9l8FfEIzVTaQMeOWbA by novenary@pl.hecke.rs
(DIR) More posts by novenary@pl.hecke.rs
(DIR) Post #9l6jKjnFqe3oFam6ng by fribbledom@mastodon.social
2019-07-22T12:17:25Z
1 likes, 0 repeats
I highly respect Andrew (BurntSushi), all of his work and awesome projects, but I really don't know how I'm supposed to feel about that kind of attitude towards project management:https://github.com/BurntSushi/xgbutil/pull/43
(DIR) Post #9l6jSyvlS5UjVxgcVc by lerk@comm.network
2019-07-22T12:18:57Z
0 likes, 0 repeats
@fribbledom People that are unable to manage their e-mail notifications annoy me.I was *this* short of posting that as comment but that would have filled his inbox even more.
(DIR) Post #9l6ja6qOQdpK5IZZVA by rgh@mastodon.social
2019-07-22T12:20:14Z
0 likes, 0 repeats
@fribbledom oh yeah, usually maintainers like small pr..Kinda surprising.Oh well.Keep at it. Can't please everyone.
(DIR) Post #9l6jfk6lsBIVJ9v4z2 by gaeel@stream.void.garden
2019-07-22T12:21:12Z
0 likes, 0 repeats
@fribbledom I agree with you hereIf they don't want to deal with PRs, they can hand off the project or simply close them offBatching PRs together might make sense in some situations, but unless all your changes are part of one particular overhaul or task, then there's no reason to batch them, especially, as you say, when it's trivial to accept/close but time-consuming to manipulate a big PR
(DIR) Post #9l6jiAYGWmPxtrw9fE by fribbledom@mastodon.social
2019-07-22T12:21:41Z
0 likes, 0 repeats
@lerk Heh, yeah, please no drama on GitHub 😂 I don't mean to bash him here either, I'm just seriously a bit baffled.
(DIR) Post #9l6jqqAnfDJlIt60mW by shesgabrielle@mastodon.social
2019-07-22T12:23:13Z
0 likes, 0 repeats
@fribbledom You're doing this stuff for free, right? Don't do work for people who seem not to appreciate it. Getting a notification surely isn't that overwhelming. I'm wondering if it's because the small fixes are making the creator feel attacked somewhat?
(DIR) Post #9l6k5i4e3iEMWnJ7C4 by mansr@society.oftrolls.com
2019-07-22T12:25:57Z
0 likes, 0 repeats
@fribbledom Try maintaining a project for a while and see how you feel then.
(DIR) Post #9l6k8Bk4ixHT7arrVo by ayo@niu.moe
2019-07-22T12:26:22Z
0 likes, 0 repeats
@fribbledom Different maintainers have different problems. I'd expect BurntSushi would have to deal with a lot of the problems discussed in https://nolanlawson.com/2017/03/05/what-it-feels-like-to-be-an-open-source-maintainer/ - fewer and larger PR's might just be an improvement in that setup.
(DIR) Post #9l6kDesznMqOxQeGyu by orionwl@x0f.org
2019-07-22T12:26:41Z
0 likes, 0 repeats
@fribbledom yea—on one hand, fixing typos is good, and these kind of trivial improvements should be welcomebut i do understand his attitude a bit—moderate to large projects get many PRs like this, and every PR needs to go through the review process, so if there's tons of them it can feel overwhelmingso i'd agree with his point to group these changes into fewer PRs if possible (can be multiple commits)
(DIR) Post #9l6kFVmEdKldHlMzuS by Bluedepth@mastodon.technology
2019-07-22T12:27:40Z
0 likes, 0 repeats
@fribbledom No good deed goes unpunished.
(DIR) Post #9l6kN55xigDcqlCsGu by fribbledom@mastodon.social
2019-07-22T12:29:05Z
1 likes, 0 repeats
@mansr You do realize I'm maintaining a wide variety of open source projects since almost 20 years now? 😂
(DIR) Post #9l6kZiKZfU9U0p46Fs by fribbledom@mastodon.social
2019-07-22T12:31:21Z
0 likes, 0 repeats
@orionwl Nobody said maintaining projects is easy 😆I'm certainly not gonna start lumping typo fixes together with improved error handling. That's just silly and really bad practice.
(DIR) Post #9l6kaVtLP04ziqi3km by mansr@society.oftrolls.com
2019-07-22T12:31:32Z
0 likes, 0 repeats
@fribbledom And you never once got annoyed by unsolicited "help" when you had more pressing matters to attend to? Also, I have no idea who you are or what you have maintained.
(DIR) Post #9l6kp7gvf0Th0hrwBc by nightpool@cybre.space
2019-07-22T12:34:03Z
0 likes, 0 repeats
@fribbledom it's all about striking a good balance. As a maintainer with not a lot of time, 15 1-line PRs have a lot more procedural and cognitive overhead then 1 15-line PR. it's about balancing the fixed cost of reviewing any PR with the non-linear per-line cost of reviewing PRs. there's a cross over point where the factors trade off which one dominates.
(DIR) Post #9l6kxCxDyeCLeKLWds by KopfKrieg@mastodon.bayern
2019-07-22T12:35:32Z
0 likes, 0 repeats
@fribbledomHe could just, you know, merge the PRs and everyone would be happy. Yes, GitHub is annoying with sending separate e-mails for every little thing (and no option to summarize them), but usually smaller PRs are preferred. You've don't everything right :)
(DIR) Post #9l6l65Gjv6boQ7hsQ4 by KopfKrieg@mastodon.bayern
2019-07-22T12:37:12Z
0 likes, 0 repeats
@fribbledomHe could just, you know, merge the PRs and everyone would be happy. Yes, GitHub is annoying with sending separate e-mails for every little thing (and no option to summarize them), but usually smaller PRs are preferred. You've done everything right :)
(DIR) Post #9l6l7lVYMWFliBRAwq by orionwl@x0f.org
2019-07-22T12:37:25Z
0 likes, 0 repeats
@fribbledom it's definitely not easy, and mostly a thankless, often frustrating jobthat said, it wasn't clear to me that this concerned completely different *kinds* of changes ! like: we sometimes get 5 PRs by the same person fixing different typos in comments in the same week, then it would be a good thing to group them and do a PR per month or so, there's no hurrybut if it's a typo and error handing i agree it makes sense to split it out
(DIR) Post #9l6mTJX59dLFGxzXUm by PoorLifeChoices@fedi.absturztau.be
2019-07-22T12:49:23.945480Z
0 likes, 0 repeats
@fribbledom @orionwl The big thing I've always used as the basis for the scale of a PR has been the granularity of reverts. If a reasonable person would want to revert two changes together, (moreso if they'd ONLY want to revert them together,) then they should be combined into a single PR. If someone would only want to revert a part of the change, (moreso if they'd ONLY want to revert them,) then they should be split into seperate PRs.Reviewing what you submitted, they're all the appropriate, if rather granular. But they represent changes in rather separate areas and functions, which makes sense.
(DIR) Post #9l6mTJkuKEOtxqSa2q by fribbledom@mastodon.social
2019-07-22T12:52:34Z
0 likes, 0 repeats
@PoorLifeChoicesYeah, that's pretty much my reasoning as well.@orionwl
(DIR) Post #9l6mYaH6Knr8e61tU8 by greyor@social.privacytools.io
2019-07-22T12:53:28Z
0 likes, 0 repeats
@fribbledom Seems kind of rude on his part, looking at your brief conversation. Sorry to hear that. As a counterexample, I noticed some smallish pull requests that seemed to be greatly appreciated on the recent github created by byuu, creator of higan/bsnes. He seemed genuinely appreciative even of fixes to small typos. Cf. https://github.com/byuu/bsnes/commit/1979df20adb5f0601041973bfff30f16a7161536
(DIR) Post #9l6ma8H5PSsyNqlEn2 by dmoonfire@octodon.social
2019-07-22T12:53:49Z
0 likes, 0 repeats
@fribbledom Personally, I prefer small PRs that fix focused areas and "do one thing well" however everyone is different. I don't like that he just closed the or since he spent more effort telling you he didn't like it than merging the five. Plus closing means no one else can merge and resubmit.It's hiding the problem.
(DIR) Post #9l6mkuGpohbA8VmT8i by qubyte@mastodon.social
2019-07-22T12:55:46Z
0 likes, 0 repeats
@mansr @fribbledom Good job providing uninformed, unsolicited advice there 👍
(DIR) Post #9l6mvdHBLG0WcA3dVQ by fribbledom@mastodon.social
2019-07-22T12:57:42Z
1 likes, 0 repeats
Oh my... now he seriously closed all those pull requests. As he mentioned himself, he's aware they're all reasonable (so he already did all the review work involved), and it would have been just as much work for him to actually click "Merge" as it was to click "Close".What is he trying to do here? Teach me a lesson? That's just silly and stubborn now. The exact opposite of what I'm looking for in open-source maintainership 🙄
(DIR) Post #9l6n7WWwFTWXAS67t2 by mdszy@mastodon.technology
2019-07-22T12:59:50Z
0 likes, 0 repeats
@fribbledom he's being one of those dicks that thinks if you're not committing massive code additions your contributions are worthlessfixing typos is something that needs to be done and makes your shit look more professional, and the fact that people look down on those kind of PR's is really damn dumb
(DIR) Post #9l6nEWIPWBmIT4deUq by Bluedepth@mastodon.technology
2019-07-22T13:01:08Z
0 likes, 0 repeats
@fribbledom self-defeating phyrric spite. They should update git so that people who maintain projects have a digest option for these sorts of things. Take it away from people who are just trying to be tidy and leave the headaches for people who can afford the headaches. Otherwise, you're what? Encouraged to behave poorly to this one guy and then you do this with someone else and then they get pissed at you for the other way. It's tent flapping! Who has the standard?! Anyone!
(DIR) Post #9l6nL6tOMlmnhv4wme by alexcleac@mastodon.technology
2019-07-22T13:02:20Z
0 likes, 0 repeats
@fribbledom that is an interesting one. For all the time I hear from maintainers directly opposite: make as small patch as possible to keep the fit history clean and granular to be able to revert any action without breaking things :/
(DIR) Post #9l6nVSHJi0nKvkCbZI by gaeel@stream.void.garden
2019-07-22T13:04:10Z
0 likes, 0 repeats
Don't waste time dealing with this kind of attitude, grunt nit-picky work is important, move on and contribute to projects that welcome your efforts
(DIR) Post #9l6nbEq6aTL6zJERUm by Magess@fandom.ink
2019-07-22T13:04:35Z
0 likes, 0 repeats
@fribbledom Just closing them after having looking at them and agreed that what you did was good is just childish and punitive. I'm sure you've learned your lesson, though! (don't help on his project, obv.)
(DIR) Post #9l6ncUpmbXQastgHp2 by FiXato@mastodon.social
2019-07-22T13:05:29Z
0 likes, 0 repeats
@fribbledomI looked at the 3 PRs you added, and to me it looks like a logical split of issues. The changes are indeed fairly trivial, which imho should make accepting or rejecting them fairly simple too. Most projects I've contributed to, indeed prefer these atomic commits, and would sooner ask you to split changes up rather than merge them into a single PR.For the nil definition and redundant type casting, I might've added a reference as to why it's generally not recommended.
(DIR) Post #9l6nhXdtagtl2fWiFU by chagratt@framapiaf.org
2019-07-22T13:06:22Z
0 likes, 0 repeats
@fribbledom I could only recommend to you to move on and let it go. Don't waste your energy against this kind of person, you'll certainly find another project.
(DIR) Post #9l6oKqxfhHjwFiWPui by FiXato@mastodon.social
2019-07-22T13:13:31Z
0 likes, 0 repeats
@fribbledom also, if maintainers prefer a certain style of contributions, or even don't want 'trivial' stuff li(e typo fixes, perhaps they should consider adding contribution guidelines via a CONTRIBUTING document: https://help.github.com/en/articles/setting-guidelines-for-repository-contributorsIf I saw this behaviour, especially the closing of your PRs (not sure if it's just these 3, or also others on other projects he has access to?) rather than merging, at least with this reasoning, I'd think twice about any future contributions to their projects.
(DIR) Post #9l6oml39Go3a1gODdQ by juliank@mastodon.social
2019-07-22T13:11:08Z
0 likes, 0 repeats
@alexcleac I mean sure, you do want individual commits, but I certainly would want 1 pull request "minor fixes" with 3 individual commits, rather than 3 pull requests with one commit each; especially if it's obvious stuff like typos.@fribbledom
(DIR) Post #9l6omm8rD4DXPg4IAi by fribbledom@mastodon.social
2019-07-22T13:18:32Z
0 likes, 0 repeats
@juliank Of course I'm not posting one pull request per fixed typo.There was one pull request for all typo fixes in the project, one for ineffectual assignments and one removing unnecessary type conversions.That's a fairly reasonable partitioning in my eyes.@alexcleac
(DIR) Post #9l6oz8SA5Anq5MzWbo by epilys@chaos.social
2019-07-22T13:20:46Z
0 likes, 0 repeats
@fribbledom I think you're being far too kind. This guy seems like an asshole, and you should ignore him and his projects. Here's a good article about assholes (although about hiring) and why you should shut them out https://www.nomachetejuggling.com/2019/06/03/dont-hire-assholes/
(DIR) Post #9l6pD6How35pQ4oUim by walruslifestyle@octodon.social
2019-07-22T13:23:14Z
0 likes, 0 repeats
@fribbledom so many assholes on github. I think your granular pull requests are an accepted workflow and this guys whining about it is counterproductive
(DIR) Post #9l6pDg8rcpJqcitql6 by alexcleac@mastodon.technology
2019-07-22T13:23:23Z
0 likes, 0 repeats
@fribbledom @juliank +1 on this one, that really looks nicely splitted.In my opinion, the maintainer himself should fix such small issues. It's his name on the project, not an organization or somebody else's...
(DIR) Post #9l6pIssNhv3VZ8fkPY by walruslifestyle@octodon.social
2019-07-22T13:24:19Z
0 likes, 0 repeats
@fribbledom he's an ass!
(DIR) Post #9l6pJyX89wSfOvFjjE by faho@octodon.social
2019-07-22T12:52:03Z
0 likes, 0 repeats
@nightpool @fribbledom It was 3 PRs, with a total of 11 lines.
(DIR) Post #9l6pJzvcyLePjBioYC by nightpool@cybre.space
2019-07-22T12:53:30Z
0 likes, 0 repeats
@faho @fribbledom sure, I'm just saying that the overall point does not strike me as particularly strange, depending on the maintainer and the codebase and what they're comfortable with/used to
(DIR) Post #9l6pK19UQIKjWTDOnQ by faho@octodon.social
2019-07-22T12:54:51Z
0 likes, 0 repeats
@nightpool @fribbledom Sure, but the overall point basically does not apply here because the effort to discuss is *higher* than just clicking "merge" three times and then saying "Hey, next time I'd prefer these as separate commits in one PR - no need to separate for trivial stuff".
(DIR) Post #9l6pK1XEzzKei8KMoi by nightpool@cybre.space
2019-07-22T13:11:05Z
0 likes, 0 repeats
@faho @fribbledom again, I don't know Andrew and I don't know his workflow or how he manages his time. When I'm replying to email in the morning, it's certainly a smaller marginal cost to toss off a few replies then it is to pay the cost for context switching into code review mode.and by the same token, I'm not going to walk into a project and tell the maintainer that their workflow is wrong based on "best practices". I don't know their life.
(DIR) Post #9l6pK2NLsF13Jkhz2e by fribbledom@mastodon.social
2019-07-22T13:24:23Z
0 likes, 0 repeats
@nightpool Fair enough, but then don't make your contributors jump through hoops if you already did all the review work involved. He could have said "thank you" and "by the way...", and I would have remembered his preference for the next time.Now I most certainly won't contribute to his projects ever again.@faho
(DIR) Post #9l6pPH5WbIriOZrpsO by greyor@social.privacytools.io
2019-07-22T13:25:24Z
0 likes, 0 repeats
@fribbledom Yeah, that just seems rude and petty. Ugh.
(DIR) Post #9l6pWcf2n8d9KUz7uS by faho@octodon.social
2019-07-22T13:26:46Z
0 likes, 0 repeats
@fribbledom @nightpool That's what I'm saying - you don't want to have it for *this one*, because you can already see that this one is okay, so you click "merge" three times.If you require it for this time, you introduce one round-trip - tell the contributor, they do the change, tell you, you confirm the change. That's *worse* than just merging it!
(DIR) Post #9l6pvky32rZIKbrIps by KopfKrieg@mastodon.bayern
2019-07-22T13:31:20Z
0 likes, 0 repeats
@fribbledomErm, what? Why didn't he ... just merge them? *confused*
(DIR) Post #9l6q8BHV2MeFPusi3c by fribbledom@mastodon.social
2019-07-22T13:33:35Z
0 likes, 0 repeats
@KopfKrieg That'll teach me! How dare I contribute to his projects! 😂
(DIR) Post #9l6qeHeKtZL2R0s2vw by strangeglyph@chaos.social
2019-07-22T13:39:23Z
0 likes, 0 repeats
@fribbledom @KopfKrieg Honestly, to a degree I can understand them. If I have PR preferences as a workflow maintainer, I wouldn't be interested in leading debates about them in PRs either. Whether "other project maintainers" consider my policy bad style is irrelevant - it's my project after all. The correct answer to his first reply would've been to either consolidate the PRs, as he requested, or close them and move on.
(DIR) Post #9l6qtZUWqGmK77ZbGK by dot@mastodon.mg
2019-07-22T13:41:18Z
0 likes, 0 repeats
@fribbledom So, the guy wants you not to seperate your commits, but to simplfy them in one big PR for all.
(DIR) Post #9l6rEKztvRaPF79KLI by fribbledom@mastodon.social
2019-07-22T13:45:57Z
0 likes, 0 repeats
@strangeglyph I'm not really interested in the debate either, I'm merely explaining why I did what I did.He already reviewed them and it would have been just as much work for him to click "Merge". I would have remembered his preference for the next time and it's all good.Instead he decides to make me jump through hoops to teach me a lesson. That's just childish.@KopfKrieg
(DIR) Post #9l6rJTf18xQRYipea0 by epicmorphism@satania.space
2019-07-22T13:46:53.742852Z
0 likes, 0 repeats
@fribbledom he’s too lazy to click the merge button? ffs
(DIR) Post #9l6rO0g8KEHd7YW0pc by fribbledom@mastodon.social
2019-07-22T13:47:41Z
0 likes, 0 repeats
@epicmorphism I don't think it comes down to laziness. Clicking "Close" is just as much work as clicking "Merge" 😆
(DIR) Post #9l6rU4I1oOPk3g84Se by ianbetteridge@mastodon.social
2019-07-22T13:48:46Z
0 likes, 0 repeats
@fribbledom It definitely sounds more like “I’m going to run this my way and if you don’t agree you can F off “
(DIR) Post #9l6rViyQ2IvgWgkMhE by epicmorphism@satania.space
2019-07-22T13:49:06.545804Z
0 likes, 0 repeats
@fribbledom well it’s easier than writing those messages heh
(DIR) Post #9l6rVzhfpodUPg2jSK by danielcassidy@mastodon.social
2019-07-22T13:49:07Z
0 likes, 0 repeats
@fribbledom https://mastodon.social/@danielcassidy/101689496245589736
(DIR) Post #9l6rejXTIsWQszREno by sirspate@mastodon.social
2019-07-22T13:50:41Z
0 likes, 0 repeats
@fribbledomHis reaction seems reasonable. Any code in a project's history is precedent, so he reasonably doesn't want other people seeing this and arguing with him about his having allowed it in the past.And having dealt with integrations to release branches at work, and the overhead of reviews in general, there are significant benefits to always trying to chunk up smaller changes like this into bigger patches.
(DIR) Post #9l6rsOlbKY64W5Yyv2 by fribbledom@mastodon.social
2019-07-22T13:53:09Z
0 likes, 0 repeats
@sirspate I didn't split them up completely arbitrarily. There was one PR for all typo fixes, one for ineffectual assignments and one for unnecessary conversions. That's rather reasonable imo, and should actually make it a lot easier and less time consuming to review.
(DIR) Post #9l6siKANgBalJ6uix6 by ripp_@mastodon.social
2019-07-22T14:02:32Z
0 likes, 0 repeats
@fribbledom Goes through effort to argue PR flow, which is going to take longer than just, hitting approve.
(DIR) Post #9l6soPrJQawKhQtpi4 by fribbledom@mastodon.social
2019-07-22T14:03:39Z
0 likes, 0 repeats
@ripp_ It's fine to tell me about his preference for future pull requests, but making me jump through hoops after having reviewed them already... just childish & stubborn 🙄
(DIR) Post #9l6svJudvzukHhkXK4 by 61@en.osm.town
2019-07-22T14:04:50Z
0 likes, 0 repeats
@fribbledomGuy must be having a bad day. I can't see anything wrong with those patches, and there were only three of them. Hardly a source of stress.
(DIR) Post #9l6tMWdcjHgbZRlGVc by enki@fedi.lynnesbian.space
2019-07-22T14:09:47Z
0 likes, 0 repeats
@mansr @fribbledom thanks for labeling yourself a troll
(DIR) Post #9l6tuynkWcxYlOvVqK by fribbledom@mastodon.social
2019-07-22T14:16:04Z
0 likes, 1 repeats
@mansr Unsolicited help? We're talking about open source projects, ffs. If you don't like maintaining open-source projects, don't maintain open-source projects.
(DIR) Post #9l6vtIYOJcxFLy4KpM by tbr@society.oftrolls.com
2019-07-22T14:38:00Z
0 likes, 0 repeats
@fribbledom @mansr There is no inherent obligation for a PR to be handled, one way or the other. In the end it is actually the maintainers call and work.This is often a cause for frustration.
(DIR) Post #9l6vwqLD9R8F0naupM by atrus@toot.cafe
2019-07-22T14:38:46Z
0 likes, 0 repeats
@fribbledom what *I* don't understand about this is that GitHub is really not very good at multi-commit PRs -- they explicitly say to avoid rebases, comparing changes between 2 versions of a PR is brutal.More small PRs is the only effectively way to work around GitHub's faults here, *especially* as a reviewer/maintainer.
(DIR) Post #9l6wHibF82pP5F2zT6 by fribbledom@mastodon.social
2019-07-22T14:42:34Z
0 likes, 0 repeats
@tbr Being a maintainer of several open source projects myself, I'm well aware of that. I'm not trying to tell him how to run his projects, I'm merely explaining why I did what I did. But I find it rather condescending and disrespectful asking me to jump through hoops to get my changes accepted. It would have been just as much work for him to click "Merge" instead of "Close" now.For future pull requests I would have been happy to respect his workflow preference.@mansr
(DIR) Post #9l6wnGdgcZ0HdFEYq0 by nero@welovela.in
2019-07-22T13:04:30.106317Z
1 likes, 0 repeats
@fribbledom If i was a dad with a dayjob, i would surely have done the same. Attention can be a scarce resource nowadays, and some people have no time for users failing to respect that.
(DIR) Post #9l6xQjq1zdqJU8pTJA by fink@chaos.social
2019-07-22T14:55:17Z
0 likes, 0 repeats
@fribbledom Wtf? Instead of just merging this??
(DIR) Post #9l6zJS43sQZQF52qmm by sirspate@mastodon.social
2019-07-22T15:16:29Z
0 likes, 0 repeats
@fribbledomAh.
(DIR) Post #9l70FTWoanqRZtA6Ua by vertigo@mastodon.social
2019-07-22T15:26:58Z
0 likes, 1 repeats
@fribbledom @KopfKrieg Honestly, this is one of the reasons why I no longer contribute back to open source projects today.I've been soundly denied the privilege of contributing small to medium-sized patches by just about every project I submitted to: Firefox, Linux kernel, etc.My one and only contribution to the #BSD community was the "cut" C Unit Tester many years ago, and that happened because of a generous maintainer who took my software and make a package for it for me.
(DIR) Post #9l74hsJCS8SYMFahyy by rain@niu.moe
2019-07-22T16:16:57Z
0 likes, 0 repeats
@fribbledom it makes no sense, he is in the wrong
(DIR) Post #9l74jd0AKp03SmWXwm by KopfKrieg@mastodon.bayern
2019-07-22T16:07:55Z
0 likes, 1 repeats
@vertigoIf people are afraid of contributing then we're doing something horribly wrong. Open Source is - for me - not just the access to the source code. It's also the community behind it, and if there's no community because PRs get denied then it's not what I'd call Open Source or Free Software.I'm sorry to hear that you couldn't contribute.@fribbledom
(DIR) Post #9l751zHYEf5PmFPV2W by rain@niu.moe
2019-07-22T16:20:35Z
0 likes, 0 repeats
@fribbledom if you had done it all as one PR he would have asked you to split it into separate PRs
(DIR) Post #9l79QttVnt1G7jIjIG by mdhughes@cybre.space
2019-07-22T17:09:48Z
0 likes, 0 repeats
@fribbledom Are you part of these projects, or even using them? Did you file an issue first and get go-ahead, or just guerilla-fixing stuff and hoping the PM merges them?I wouldn't accept that kind of PR, either, as it's the kind of thing black-hat hackers do to get into a project, then inject vulnerabilities later, as we've seen with NPM.Very sketch. No commit.
(DIR) Post #9l7AmaCLoWhvMW11vs by johnribbon@mastodon.social
2019-07-22T17:25:00Z
0 likes, 0 repeats
@fribbledom sounds like an arsehole to me. And you're right, you're using best practices.
(DIR) Post #9l7BjjsJTm8mSYqowi by chebra@mstdn.io
2019-07-22T17:35:39Z
0 likes, 0 repeats
@fribbledom @ripp_ I wonder how long will those typos stay there if he doesn't merge this PR... it's either that, or he merge them, or he forgets about it and invests all the effort in finding them again.
(DIR) Post #9l7CNTTLsoEvAg7g80 by mpg@social.librem.one
2019-07-22T17:42:51Z
0 likes, 0 repeats
@fribbledom wow read his response, what a fucking dick! Screw that dude man, contribute to those who appreciate it. I relate to this, I work for a knob, I go way above and beyond. Not for him, but for the folks I service and I'm a professional in what I do. (Outside of stirring shit on Mastodon). But regardless, not once do I get a thank you. So now I delay projects while I look for a new gig. There are folks that will appreciate you, you just have to find them. Rest can FUCK OFF
(DIR) Post #9l7STjLtM1PpQQdeGO by mrcrilly@aus.social
2019-07-22T20:43:16Z
0 likes, 0 repeats
@fribbledom he should have just merged those PRs. This is why I love OSS and hate OSS at the same time: people - what a bunch of bastards :P
(DIR) Post #9l87bHEHtSwudqnaIy by novenary@pl.hecke.rs
2019-07-22T17:53:02.557855Z
0 likes, 0 repeats
@fribbledom I don't mean to be an ass but I think your criticism is undeserved hereif you want a maintainer to look at your contributions then you can't just impose your way of doing things on them, you should know that since you are a maintainer yourselfI think his response was perfectly reasonable (and respectful) and calling him out for it in public feels rude and uncalled for, some might perceive it as brigading
(DIR) Post #9l87bIleAvEBPbPjwO by fribbledom@mastodon.social
2019-07-23T04:24:02Z
0 likes, 0 repeats
@novenaryI mean, he doesn't owe me anything. It's his right to ignore this PR, his right to disagree with this PR and his right to close this PR.However it becomes rather condescending if you're asking your contributors to jump through hoops to get their changes merged. He already had reviewed them and they were reasonably partitioned. It may not be his style of workflow, but then just say "thank you" and "I'd prefer it some other way next time".This is public, I'm not exposing anything.
(DIR) Post #9l88JWXyIxXMtE6XJI by bb010g@weirder.earth
2019-07-23T04:27:45Z
0 likes, 0 repeats
@fribbledom The first impression I get is that PRs are rigid and not made for a "traditional" Git workflow of commit-by-commit discussion. PRs are good because they allow people to submit stuff that works without learning Git as much and having to refactor history into nice commits at the end! But they're bad because GitHub's review tooling, while getting better, is still bad, and not commit-oriented. External tools like Reviewable can help, but they're still mostly single-topic PR-focused.
(DIR) Post #9l8FfEIzVTaQMeOWbA by novenary@pl.hecke.rs
2019-07-23T05:43:34.678267Z
0 likes, 0 repeats
@fribbledom I'll admit that I replied to you without looking at the actual changes you madeas far as organization goes, I'd side with burntsushi and say that a single "minor cleanups" PR would have been niceryou're right that it would have been less effort for him to merge all three as is, but it would also have been less effort for you to only submit onemaybe he just doesn't care? as he stated in his comment, the project is in maintenance mode and as far as I can tell your PRs bring no functional change, they're purely cosmeticor maybe he was having a bad day and just didn't want to deal with it; if that's the case then he handled it better than mostI understand your frustration, but I think you're making a bigger deal out of this than it deservesboth the GitHub thread and your toots being public is exactly what makes it brigading: you're exposing a thread that would otherwise have gone by unnoticed to a much wider audience, while setting a negative mood with your comment, and so people went and downvoted messages on the pull request, and also posted more flaming comments here, with the other party being blissfully unaware of it and getting no chance to defend himself
(DIR) Post #9l8FfEs5Ozew7UoYIi by fribbledom@mastodon.social
2019-07-23T05:54:18Z
0 likes, 0 repeats
@novenaryYes, I went the extra mile because I believe it's less time consuming and easier to review them, once they're split up in logical pieces. That's common practice for a good reason.He's acting out of spite here, asking me to do more work to literally get to the exact same result eventually. To teach me a lesson? Silly.If he doesn't care about these projects anymore, that's fine. Just say that and I'll be understanding. Just don't behave like a condescending dick.
(DIR) Post #9l8JemP1eDvVdtG3qC by gravityisforsuckers@mastodon.sdf.org
2019-07-23T06:38:58Z
0 likes, 0 repeats
@fribbledom Dang I wish I could complain about my mailbox filling up with PRs from people making honest improvements. I wish I had a contribber like you helping me work on #rmw. Does that guy not realize he'll get more emails in his inbox if you close all your PR's and submit another one with all your changes? If it were me, I'd just state policy, for future reference and merge the darn things!