Subj : Re: Ctrl+Y
To   : Carlos Navarro
From : Tim Schattkowsky
Date : Sun Jan 16 2022 23:08:01

//Hello Carlos,//

on *16.01.22* at *20:09:08* You wrote in rea *WINPOINT*
to *Tim Schattkowsky* about *"Ctrl+Y"*.

 CN>>> So you will implement this? I see that Ctrl-E is the new shortcut for
 CN>>> inserting UUEncoded files, but Ctrl-U does nothing.

 TS>> Works like a charm here !?

 CN> When replying to a message, I press Ctrl-Y and current line is deleted.
 CN> Immediately after, I press Ctrl-U. No change.

Indeed. The delete line functionality (basically one line of code) was implemented outside the actual editor control and thus accidentally bypassed the control's undo/redo functionality.

However, making that work gave me the creeps. I ended up with this (no kidding):

procedure TMessageEditor.MnDeleteLineClick(Sender: TObject);
var
  LineStart:TBufferCoord;
begin
     if Line<=Editor.Lines.Count then
     begin
          LineStart.Line   :=Line;
          LineStart.Char   :=1;
          Editor.UndoList.BeginBlock;
          Editor.UndoList.AddChange(crSelection,Editor.CharIndexToRowCol(Editor.SelStart),Editor.CharIndexToRowCol(Editor.SelEnd),'',smNormal);
          Editor.UndoList.AddChange(crCaret,Editor.CaretXY,Editor.CaretXY,'',smNormal);
          Editor.SelStart  :=Editor.RowColToCharIndex(LineStart);
          Editor.SelLength :=Length(Editor.Lines[Line-1])+2;
          Editor.SelText   :='';
          Editor.UndoList.AddChange(crGroupBreak,LineStart,LineStart,'', smNormal);
          Editor.UndoList.EndBlock;
     end;
end;

Hurts a little, but seems to do the job. Took me two hours of life time to figure that sick shit out.

 CN> I expected it to work like in GoldEd (delete line, undelete line), but I
 CN> now see that I hadn't realized that Ctrl-Y is the usual keystroke for
 CN> redoing in Windows... I don't use that when I'm in Fido-mode O:-)

Indeed.

 CN> Thinking about it, maybe Ctrl-Y should work the standard way (redo) in
 CN> WinPoint, as that could be what most potential Windows users would
 CN> expect, and use a different keystroke like Alt-D (the alternative one in
 CN> GoldEd) or Ctrl-L (like in Notepad++) for deleting the current line. What
 CN> do you think?

Like the idea. Changed it to this for testing ... However, Ctrl-Y was more conveniently located on the keyboard ...

Regards,
Tim
--- WinPoint 391.0
 * Origin: Original WinPoint Origin! (2:240/1120.29)

.