Subj : New Defects reported by Coverity Scan for Synchronet
To   : cov-scan@synchro.net
From : scan-admin@coverity.com
Date : Mon Apr 19 2021 12:50:56

Hi,

Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

1 new defect(s) introduced to Synchronet found with Coverity Scan.
2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 331161:    (TAINTED_SCALAR)


________________________________________________________________________________________________________
*** CID 331161:    (TAINTED_SCALAR)
/js_filebase.c: 1229 in js_remove_file()
1223     		char path[MAX_PATH + 1];
1224     		if(delfile && remove(getfilepath(scfg, &file, path)) != 0) {
1225     			JS_ReportError(cx, "%d removing '%s'", errno, path);
1226     			p->smb_result = SMB_ERR_DELETE;
1227     			result = JS_FALSE;
1228     		} else
>>>     CID 331161:    (TAINTED_SCALAR)
>>>     Passing tainted expression "*file.hfield" to "smb_removefile", which uses it as an offset.
1229     			p->smb_result = smb_removefile(&p->smb, &file);
1230     		smb_freefilemem(&file);
1231     	}
1232     	JS_SET_RVAL(cx, arglist, BOOLEAN_TO_JSVAL(p->smb_result == SMB_SUCCESS));
1233     	JS_RESUMEREQUEST(cx, rc);
1234     	free(fname);
/js_filebase.c: 1229 in js_remove_file()
1223     		char path[MAX_PATH + 1];
1224     		if(delfile && remove(getfilepath(scfg, &file, path)) != 0) {
1225     			JS_ReportError(cx, "%d removing '%s'", errno, path);
1226     			p->smb_result = SMB_ERR_DELETE;
1227     			result = JS_FALSE;
1228     		} else
>>>     CID 331161:    (TAINTED_SCALAR)
>>>     Passing tainted expression "file.hdr" to "smb_removefile", which uses it as a loop boundary.
1229     			p->smb_result = smb_removefile(&p->smb, &file);
1230     		smb_freefilemem(&file);
1231     	}
1232     	JS_SET_RVAL(cx, arglist, BOOLEAN_TO_JSVAL(p->smb_result == SMB_SUCCESS));
1233     	JS_RESUMEREQUEST(cx, rc);
1234     	free(fname);


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yp-2FP9gGRhvFklLaQKuBylUrkMFB3WMR2p7qIYKYTZrh4BbWTBf-2B-2Fi5ZUVF-2Fo-2B6flxo-3DNny2_g4j7BHlu96plUOfCQsO0yRjoWZCZl8YGnZ-2FUtT39hrDJSEGLq0ZEzbhqfA-2B9uyrlD1r3aHm7C-2F-2BGwTI2O91hfLTVfs6cvDbrI7hg07synxatZQah5A9SgqBCGMe7PdJNIVqhDgTcwJs1fOYDIZHQO-2BOlmORJBtRR-2BEKqFfl2wInl-2FaSBRFiNm51eWwoqFs4X1dgsPhqBt8BxBXPuMJ8Sdw-3D-3D


--- SBBSecho 3.14-Linux
 * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

.