Subj : New Defects reported by Coverity Scan for Synchronet
To   : cov-scan@synchro.net
From : scan-admin@coverity.com
Date : Mon Apr 05 2021 19:43:22

Hi,

Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

1 new defect(s) introduced to Synchronet found with Coverity Scan.
49 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 331001:  Incorrect expression  (BAD_SIZEOF)
/telgate.cpp: 194 in sbbs_t::telnet_gate(char *, unsigned long, char *, char *, char *)()


________________________________________________________________________________________________________
*** CID 331001:  Incorrect expression  (BAD_SIZEOF)
/telgate.cpp: 194 in sbbs_t::telnet_gate(char *, unsigned long, char *, char *, char *)()
188     					l=K_CHAT;
189     					if(!(mode&TG_ECHO))
190     						l|=K_NOECHO;
191     					rd=getstr((char*)buf,sizeof(buf)-1,l);
192     					if(!rd)
193     						continue;
>>>     CID 331001:  Incorrect expression  (BAD_SIZEOF)
>>>     Taking the size of "buf", which is the address of an object, is suspicious.
194     					SAFECAT((char*)buf,crlf);
195     					rd+=2;
196     					gotline=true;
197     				}
198     				if((mode&TG_CRLF) && buf[rd-1]=='\r')
199     					buf[rd++]='\n';


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yp-2FP9gGRhvFklLaQKuBylUrkMFB3WMR2p7qIYKYTZrh4BbWTBf-2B-2Fi5ZUVF-2Fo-2B6flxo-3D1_9R_g4j7BHlu96plUOfCQsO0yRjoWZCZl8YGnZ-2FUtT39hrB-2FdOsv8nKPrZ4lCHIKvjliMhSYQU5LBY4e-2Ft-2B6xhoeO-2FF0hRzqIbKPknerU-2FECQL7GKBH552gCVFvh2r-2BrQjH8L2-2BfEuL4yJUdRNTeZ9sZHLuizdT3Dw0wgrwrPpWb40nhTIlhnYoqazFx2EEo0gfjtfxwfi1DqWv3M1B7Z7k63oR66I9-2FFsngSTqrROZ-2BI0Y-3D


--- SBBSecho 3.14-Linux
 * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

.