Subj : Re: src/sbbs3/nopen.c
To   : Rob Swindell
From : Wilfred van Velzen
Date : Wed Sep 09 2020 12:49:55

Hi Rob,

On 2020-09-09 02:22:17, you wrote to Git commit to sbbs/master:

 RS> https://gitlab.synchro.net/sbbs/sbbs/-/commit/914790f5931e27c30f94e204
 RS> Modified Files:
 RS>   src/sbbs3/nopen.c
 RS> Log Message:
 RS> Improve file copy (fcopy()) performance by more than an order of
 RS> magnitude.Using a 256KB read buffer for copying files (rather than one byte
 RS> at a time).Apparently calling fread() is not the same as a bunch of calls
 RS> to fgetc()after all. Or maybe it was the many calls to fputc() being
 RS> replaced withfwrite(). Or maybe it was both. Anyway, decreased the time to
 RS> copy a 1GBfile from and to a Samba share over a Gb Ethernet network from 13
 RS> minutesto less than a minute. This matters when sbbs is backing up your
 RS> data/mailbase and the files are big. The mail base is locked while being
 RS> backed upand the longer it takes to back up, the longer the mail base is
 RS> locked andno mail can be received, read or sent during that time.

Maybe this can even be improved upon:

https://sourceforge.net/p/fmail/code/ci/linux/tree/copyFile.h
https://sourceforge.net/p/fmail/code/ci/linux/tree/copyFile.c


Bye, Wilfred.

--- FMail-lnx64 2.1.0.18-B20170815
 * Origin: FMail development HQ (2:280/464)

.