Subj : New Defects reported by Coverity Scan for Synchronet
To   : All
From : scan-admin@coverity.com
Date : Sat Apr 05 2025 12:46:11

Hi,

Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

1 new defect(s) introduced to Synchronet found with Coverity Scan.
3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 548912:  Data race undermines locking  (LOCK_EVASION)
/answer.cpp: 437 in sbbs_t::answer(bool *)()


________________________________________________________________________________________________________
*** CID 548912:  Data race undermines locking  (LOCK_EVASION)
/answer.cpp: 437 in sbbs_t::answer(bool *)()
431     								activate_ssh = init_sftp(cid);
432     								term->cols = 0;
433     								term->rows = 0;
434     								SAFECOPY(terminal, "sftp");
435     								mouse_mode = MOUSE_MODE_OFF;
436     								autoterm = 0;
>>>     CID 548912:  Data race undermines locking  (LOCK_EVASION)
>>>     Thread1 sets "sys_status" to a new value. Now the two threads have an inconsistent view of "sys_status" and updates to fields correlated with "sys_status" may be lost.
437     								sys_status |= SS_USERON;
438     								SAFECOPY(client.protocol, "SFTP");
439     								SAFECOPY(client.user, useron.alias);
440     								client.usernum = useron.number;
441     								client_on(client_socket, &client, /* update: */ TRUE);
442     								SAFECOPY(connection, client.protocol);


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/synchronet?tab=overview


--- SBBSecho 3.24-Linux
 * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

.