Subj : src/sbbs3/getnode.cpp
To   : Git commit to main/sbbs/master
From : Rob Swindell (on Windows 11)
Date : Thu Aug 22 2024 21:26:25

https://gitlab.synchro.net/main/sbbs/-/commit/e93b6dfa682e792f39c548dd
Modified Files:
	src/sbbs3/getnode.cpp
Log Message:
Don't call utime() on the node.dab file for every read

.... this was the cause of some observed unnecessarily high disk/file server
(Samba) utilization, as we call getnodedat() a lot. utime() opens and closes
the file, which was already open - and we're not modifying the file, so
updating the 'modification time' here is wrong anyway.

Disabling this 21-year old bit of logic resulted in a pretty dramatic
reduction in Samba (smbd) CPU utilization on Vertrauen.

If a BBS actually needes this hack (e.g. for NFS compatibility, as Deuce
eluded in the comment), they'd be better off just setting the "Keep Node File
Open" node setting (in SCFG->Nodes) to "No".
--- SBBSecho 3.20-Linux
 * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

.