Subj : New Defects reported by Coverity Scan for Synchronet
To   : cov-scan@synchro.net
From : scan-admin@coverity.com
Date : Tue Apr 09 2024 13:19:43

Hi,

Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

1 new defect(s) introduced to Synchronet found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 492287:  Error handling issues  (CHECKED_RETURN)
/main.cpp: 4472 in node_thread(void *)()


________________________________________________________________________________________________________
*** CID 492287:  Error handling issues  (CHECKED_RETURN)
/main.cpp: 4472 in node_thread(void *)()
4466     				}
4467     				SAFEPRINTF2(str,"%s%s.bin",sbbs->cfg.mods_dir
4468     					,sbbs->cfg.shell[sbbs->useron.shell]->code);
4469     				if(sbbs->cfg.mods_dir[0]==0 || !fexistcase(str)) {
4470     					SAFEPRINTF2(str,"%s%s.bin",sbbs->cfg.exec_dir
4471     						,sbbs->cfg.shell[sbbs->useron.shell]->code);
>>>     CID 492287:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "fexistcase" without checking return value (as is done elsewhere 117 out of 131 times).
4472     					fexistcase(str);
4473     				}
4474     				if((file=sbbs->nopen(str,O_RDONLY))==-1) {
4475     					sbbs->errormsg(WHERE,ERR_OPEN,str,O_RDONLY);
4476     					sbbs->hangup();
4477     					break;


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu4gdQbQRNsarCbK0jIoVQSWT2zCPijRqaed4AhLiEI9Z7MR9SJQ09ot5XPbn9SW-2F14-3DHvP9_7FYjIqE8olEh4k02KWtt1r1LGSyuXVEtCuKuJCXgAQagYisv-2BW69zRWxBhimCtdag5Y-2FmNQU-2F9a-2BQz99muYyDMQHaJ9IAAUHt0J4m9PdQ-2FM2LeT5-2B1UNdpeKXpgNOTn265LNUeBHOZI40IJ3EqY58uotyMvBntmOFa6NssYuPj9pyF9jsG3Ot15K77yZ8uUVZ5aWBxVVnDKUwxo1ITxjHQ-3D-3D


--- SBBSecho 3.20-Linux
 * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

.