Subj : New Defects reported by Coverity Scan for Synchronet
To   : cov-scan@synchro.net
From : scan-admin@coverity.com
Date : Tue Mar 19 2024 13:22:45

Hi,

Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

1 new defect(s) introduced to Synchronet found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 488122:  Concurrent data access violations  (MISSING_LOCK)
/websrvr.c: 6243 in respond()


________________________________________________________________________________________________________
*** CID 488122:  Concurrent data access violations  (MISSING_LOCK)
/websrvr.c: 6243 in respond()
6237     				,session->socket, session->client.protocol, session->client.addr, session->req.physical_path
6238     				,session->req.range_start,session->req.range_end, content_length);
6239     		else
6240     			lprintf(LOG_INFO,"%04d %s [%s] Sending file: %s (%"PRIdOFF" bytes)"
6241     				,session->socket, session->client.protocol, session->client.addr, session->req.physical_path, content_length);
6242     		snt=sock_sendfile(session,session->req.physical_path,session->req.range_start,session->req.range_end);
>>>     CID 488122:  Concurrent data access violations  (MISSING_LOCK)
>>>     Accessing "session->send_failed" without holding lock "http_session_t.outbuf_write". Elsewhere, "http_session_t.send_failed" is written to with "http_session_t.outbuf_write" held 1 out of 1 times.
6243     		if(!session->send_failed) {
6244     			if(session->req.ld!=NULL) {
6245     				if(snt<0)
6246     					snt=0;
6247     				session->req.ld->size=snt;
6248     			}


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu4gdQbQRNsarCbK0jIoVQSWT2zCPijRqaed4AhLiEI9Z7MR9SJQ09ot5XPbn9SW-2F14-3DmHtV_7FYjIqE8olEh4k02KWtt1r1LGSyuXVEtCuKuJCXgAQbYwk4stqvOulAQyfb9Qz7UqXa-2FyYiLNtJQLdPQNB0BbrubVIHVqt8wbwLmHsBUJon6PC9sbncKQ-2BAxsdRHbzS8LHKyt8nQ5XXM7E400tls6CE8QTOmeO-2BbTPMyH95TYfYCuXcmmWIuH-2F2U7WSDFD5czc7Rvy8hX-2BZbhm7O5DgwmQ-3D-3D


--- SBBSecho 3.20-Linux
 * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

.