Subj : New Defects reported by Coverity Scan for Synchronet
To   : cov-scan@synchro.net
From : scan-admin@coverity.com
Date : Fri Mar 01 2024 13:43:05

Hi,

Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

1 new defect(s) introduced to Synchronet found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 487600:  Error handling issues  (CHECKED_RETURN)
/sftp.cpp: 1625 in sftp_readdir(sftp_string *, void *)()


________________________________________________________________________________________________________
*** CID 487600:  Error handling issues  (CHECKED_RETURN)
/sftp.cpp: 1625 in sftp_readdir(sftp_string *, void *)()
1619     			free(link);
1620     			if (lname == nullptr) {
1621     				sftp_fattr_free(attr);
1622     				return sftps_send_error(sbbs->sftp_state, SSH_FX_FAILURE, "Longname allocation failure");
1623     			}
1624     			vpath = getfname(tmppath);
>>>     CID 487600:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "add_name" without checking return value (as is done elsewhere 4 out of 5 times).
1625     			fn.add_name(strdup(vpath), lname, attr);
1626     		}
1627     	}
1628     	else {
1629     		if (dd->info.filebase.lib == -1) {
1630     			// /files/ (ie: list of libs)


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu4gdQbQRNsarCbK0jIoVQSWT2zCPijRqaed4AhLiEI9Z7MR9SJQ09ot5XPbn9SW-2F14-3D_Mv9_7FYjIqE8olEh4k02KWtt1r1LGSyuXVEtCuKuJCXgAQZAvea4qFQBhPrjKB4cHy2kAbmKz1-2F0ttbXdmTqhC-2BEq7-2Bvgywi6EN0yh9ZWlpucVXNfv4OAgSDch06A-2FyZfKQuykxNA3ygHnLLNJZ-2FPbpNGcgiztSzdmC0nW0gtMv3miUCmrLhEqR-2FOP8z9BsqWg6i-2B8KyEK4CuE0E7PMo9TUvnw-3D-3D


--- SBBSecho 3.20-Linux
 * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

.