Subj : New Defects reported by Coverity Scan for Synchronet
To   : cov-scan@synchro.net
From : scan-admin@coverity.com
Date : Tue Feb 27 2024 13:40:04

Hi,

Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

2 new defect(s) introduced to Synchronet found with Coverity Scan.
3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 487089:  High impact quality  (Y2K38_SAFETY)
/logout.cpp: 97 in sbbs_t::logout(bool)()


________________________________________________________________________________________________________
*** CID 487089:  High impact quality  (Y2K38_SAFETY)
/logout.cpp: 97 in sbbs_t::logout(bool)()
91     	delfiles(cfg.temp_dir,ALLFILES);
92     	if(sys_status&SS_USERON) {	// Insures the useron actually went through logon()/getmsgptrs() first
93     		putmsgptrs();
94     	}
95     	if(!REALSYSOP)
96     		logofflist();
>>>     CID 487089:  High impact quality  (Y2K38_SAFETY)
>>>     A "time_t" value is stored in an integer with too few bits to accommodate it.  The expression "this->now" is cast to "time32_t".
97     	useron.laston=(time32_t)now;
98
99     	ttoday=useron.ttoday-useron.textra; 		/* billable time used prev calls */
100     	if(ttoday>=cfg.level_timeperday[useron.level])
101     		i=0;
102     	else

** CID 487088:  Error handling issues  (CHECKED_RETURN)
/logout.cpp: 89 in sbbs_t::logout(bool)()


________________________________________________________________________________________________________
*** CID 487088:  Error handling issues  (CHECKED_RETURN)
/logout.cpp: 89 in sbbs_t::logout(bool)()
83     	if(cfg.logout_mod[0]) {
84     		lprintf(LOG_DEBUG, "executing logout module: %s", cfg.logout_mod);
85     		exec_bin(cfg.logout_mod,&main_csi);
86     	}
87     	SAFEPRINTF2(path,"%smsgs/%4.4u.msg",cfg.data_dir,useron.number);
88     	if(fexistcase(path) && !flength(path))		/* remove any 0 byte message files */
>>>     CID 487088:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "remove(path)" without checking return value. This library function may fail and return an error code.
89     		remove(path);
90
91     	delfiles(cfg.temp_dir,ALLFILES);
92     	if(sys_status&SS_USERON) {	// Insures the useron actually went through logon()/getmsgptrs() first
93     		putmsgptrs();
94     	}


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu4gdQbQRNsarCbK0jIoVQSWT2zCPijRqaed4AhLiEI9Z7MR9SJQ09ot5XPbn9SW-2F14-3D6w7L_7FYjIqE8olEh4k02KWtt1r1LGSyuXVEtCuKuJCXgAQZL2KLON9c0qMM4K5aJ-2BfdThB6-2BKGg4cWLgpEPITZFj21NY7HODKa21xNCYmqB9WQ9jGdCaJ8kxZplYYP3ZpJQciN5y3k5uG3vF-2Bbjho-2FJ80W4KFTLh14Ge0YKg4KwvJQypDruDryLBwEKW1kUPhOIUyQwbpfzm3Xgxi8Wb6VLKOw-3D-3D


--- SBBSecho 3.20-Linux
 * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

.