Subj : New Defects reported by Coverity Scan for Synchronet
To   : cov-scan@synchro.net
From : scan-admin@coverity.com
Date : Fri Feb 16 2024 13:40:21

Hi,

Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

1 new defect(s) introduced to Synchronet found with Coverity Scan.
4 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 486496:    (CHECKED_RETURN)
/writemsg.cpp: 382 in sbbs_t::writemsg(const char *, const char *, char *, int, int, const char *, const char *, const char **, const char **)()
/writemsg.cpp: 344 in sbbs_t::writemsg(const char *, const char *, char *, int, int, const char *, const char *, const char **, const char **)()


________________________________________________________________________________________________________
*** CID 486496:    (CHECKED_RETURN)
/writemsg.cpp: 382 in sbbs_t::writemsg(const char *, const char *, char *, int, int, const char *, const char *, const char **, const char **)()
376
377     		else if(useron_xedit && cfg.xedit[useron_xedit-1]->misc&QUOTENONE)
378     			;
379
380     		else if(yesno(text[QuoteMessageQ])) {
381     			if(!fexist(quotes_fname(useron_xedit, path, sizeof(path))))
>>>     CID 486496:    (CHECKED_RETURN)
>>>     Calling "fexistcase" without checking return value (as is done elsewhere 117 out of 130 times).
382     				fexistcase(path);
383     			if((stream=fnopen(&file,path,O_RDONLY))==NULL) {
384     				errormsg(WHERE,ERR_OPEN,path,O_RDONLY);
385     				free(buf);
386     				return(false);
387     			}
/writemsg.cpp: 344 in sbbs_t::writemsg(const char *, const char *, char *, int, int, const char *, const char *, const char **, const char **)()
338     			&& cfg.sub[subnum]->misc&SUB_QUOTE))) {
339
340     		/* Quote entire message to MSGTMP or INPUT.MSG */
341
342     		if(useron_xedit && cfg.xedit[useron_xedit-1]->misc&QUOTEALL) {
343     			if(!fexist(quotes_fname(useron_xedit, path, sizeof(path))))
>>>     CID 486496:    (CHECKED_RETURN)
>>>     Calling "fexistcase" without checking return value (as is done elsewhere 117 out of 130 times).
344     				fexistcase(path);
345     			if((stream=fnopen(NULL,path,O_RDONLY))==NULL) {
346     				errormsg(WHERE,ERR_OPEN,path,O_RDONLY);
347     				free(buf);
348     				return(false);
349     			}


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yp-2FP9gGRhvFklLaQKuBylUrkMFB3WMR2p7qIYKYTZrh4E6fW2ok94RcmG1J20ETIf4-3Dzn-5_g4j7BHlu96plUOfCQsO0yRjoWZCZl8YGnZ-2FUtT39hrDPrVkNTVRB68tnZKkkXRCkPUT71LTHn8QopE1tYVp-2FX-2Br08qA1yywGwU3c4MVrlWG-2BFbxw1q-2Fo2e8fear09VrdxSTaZYVAh-2F7Xjhpabc-2Bcxm1n9Xbtacc4z9BZManLJqZ02pp-2F9yM96t7IgwLb1rxOxJKJoizd1NnBghDuRAiDsQ-3D-3D


--- SBBSecho 3.20-Linux
 * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

.