Subj : New Defects reported by Coverity Scan for Synchronet
To   : cov-scan@synchro.net
From : scan-admin@coverity.com
Date : Mon Feb 05 2024 13:39:54

Hi,

Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

1 new defect(s) introduced to Synchronet found with Coverity Scan.
8 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 483249:  Error handling issues  (CHECKED_RETURN)
/main.cpp: 3570 in sbbs_t::init()()


________________________________________________________________________________________________________
*** CID 483249:  Error handling issues  (CHECKED_RETURN)
/main.cpp: 3570 in sbbs_t::init()()
3564     		thisnode.misc&=(NODE_EVENT|NODE_LOCK|NODE_RRUN);
3565     		criterrs=thisnode.errors;
3566     		putnodedat(cfg.node_num,&thisnode);
3567
3568     		// remove any pending node messages
3569     		safe_snprintf(str, sizeof(str), "%smsgs/n%3.3u.msg",cfg.data_dir,cfg.node_num);
>>>     CID 483249:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "remove(str)" without checking return value. This library function may fail and return an error code.
3570     		remove(str);
3571     		// Delete any stale temporary files (with potentially sensitive content)
3572     		delfiles(cfg.temp_dir,ALLFILES);
3573     		safe_snprintf(str, sizeof(str), "%sMSGTMP", cfg.node_dir);
3574     		removecase(str);
3575     		safe_snprintf(str, sizeof(str), "%sQUOTES.TXT", cfg.node_dir);


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yp-2FP9gGRhvFklLaQKuBylUrkMFB3WMR2p7qIYKYTZrh4E6fW2ok94RcmG1J20ETIf4-3DuxM4_g4j7BHlu96plUOfCQsO0yRjoWZCZl8YGnZ-2FUtT39hrDlWnKXqUo4ko-2BswZDnU0KThZlBPhv1kFyIVU6rRp9K48otOTA5WQm5qg8o-2FY8FDqYkPfgDhKOyoUIQMv1mPwAY7yKStOAqjn6xloHvMgh0mRG0DJXpuxyIOkTyi2gGZzdoTshBDw9gCNjiMqTW3IeGxtntX-2B4oBRMrCvut8dx1Kg-3D-3D


--- SBBSecho 3.20-Linux
 * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

.