Subj : src/sbbs3/zmodem.c To : CVS commit From : rswindell Date : Fri Oct 20 2023 20:19:52 src/sbbs3 zmodem.c 1.123 1.124 Update of /cvsroot/sbbs/src/sbbs3 In directory cvs:/home/rswindell/sbbs/src/sbbs3 Modified Files: zmodem.c Log Message: Fix a 14-year old bug with ZMODEM-send. If the receiver already has the file named in the ZFILE frame, they will usually compute the local CRC value and request the sender to compute and send its CRC of the file it wants to send. If the CRCs match, the receiver will send a ZSKIP frame next ("skip this file, I already have it"). However, when I implemented the ZCRC frame support in zmodem_send_file(), I added the ZCRC frame check *after* the check to see if its a ZSKIP frame, when in fact, they will normally come in the other order (ZCRC, then ZSKIP). This would result in multiple ZCRC request/response, then ZSKIP requests that were ignored by the sender (who just send a ZFILE frame again). Simple fix: check for ZCRC frame before ZSKIP frame. --- SBBSecho 3.20-Linux * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705) .