Subj : New Defects reported by Coverity Scan for Synchronet
To   : cov-scan@synchro.net
From : scan-admin@coverity.com
Date : Tue Apr 25 2023 12:57:18

Hi,

Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

2 new defect(s) introduced to Synchronet found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 452582:    (ATOMICITY)
/tmp/sbbs-Apr-25-2023/src/conio/bitmap_con.c: 562 in bitmap_draw_one_char()
/tmp/sbbs-Apr-25-2023/src/conio/bitmap_con.c: 647 in bitmap_draw_one_char()
/tmp/sbbs-Apr-25-2023/src/conio/bitmap_con.c: 584 in bitmap_draw_one_char()


________________________________________________________________________________________________________
*** CID 452582:    (ATOMICITY)
/tmp/sbbs-Apr-25-2023/src/conio/bitmap_con.c: 562 in bitmap_draw_one_char()
556     					break;
557     				case 16:
558     					this_font = (unsigned char *)conio_fontdata[vmem_ptr->vmem[vmo].font].eight_by_sixteen;
559     					break;
560     				default:
561     					pthread_mutex_lock(&vstatlock);
>>>     CID 452582:    (ATOMICITY)
>>>     Using an unreliable value of "vmem_ptr" inside the second locked section. If the data that "vmem_ptr" depends on was changed by another thread, this use might be incorrect.
562     					release_vmem(vmem_ptr);
563     					pthread_mutex_unlock(&vstatlock);
564     					return(-1);
565     			}
566     		}
567     	}
/tmp/sbbs-Apr-25-2023/src/conio/bitmap_con.c: 647 in bitmap_draw_one_char()
641     		if (x & 0x07)
642     			fontoffset++;
643     		pixeloffset += rsz;
644     	}
645     	pthread_mutex_unlock(&screenlock);
646     	pthread_mutex_lock(&vstatlock);
>>>     CID 452582:    (ATOMICITY)
>>>     Using an unreliable value of "vmem_ptr" inside the second locked section. If the data that "vmem_ptr" depends on was changed by another thread, this use might be incorrect.
647     	release_vmem(vmem_ptr);
648     	pthread_mutex_unlock(&vstatlock);
649
650     	return(0);
651     }
652
/tmp/sbbs-Apr-25-2023/src/conio/bitmap_con.c: 584 in bitmap_draw_one_char()
578     		return(-1);
579     	}
580
581     	if((!screena.rect) || (!screenb.rect)) {
582     		pthread_mutex_unlock(&screenlock);
583     		pthread_mutex_lock(&vstatlock);
>>>     CID 452582:    (ATOMICITY)
>>>     Using an unreliable value of "vmem_ptr" inside the second locked section. If the data that "vmem_ptr" depends on was changed by another thread, this use might be incorrect.
584     		release_vmem(vmem_ptr);
585     		pthread_mutex_unlock(&vstatlock);
586     		return(-1);
587     	}
588
589     	pixeloffset = PIXEL_OFFSET(screena, xoffset, yoffset);

** CID 452581:  Program hangs  (ORDER_REVERSAL)


________________________________________________________________________________________________________
*** CID 452581:  Program hangs  (ORDER_REVERSAL)
/tmp/sbbs-Apr-25-2023/src/conio/bitmap_con.c: 1608 in bitmap_replace_font()
1602     			conio_fontdata[id].desc=name;
1603     			break;
1604     		default:
1605     			free(name);
1606     			free(data);
1607     	}
>>>     CID 452581:  Program hangs  (ORDER_REVERSAL)
>>>     Calling "request_redraw" acquires lock "vstatlock" while holding lock "screenlock" (count: 1 / 2).
1608     	request_redraw();
1609     	pthread_mutex_unlock(&screenlock);
1610     }
1611
1612     int bitmap_setpalette(uint32_t index, uint16_t r, uint16_t g, uint16_t b)
1613     {


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yp-2FP9gGRhvFklLaQKuBylUrkMFB3WMR2p7qIYKYTZrh4BbWTBf-2B-2Fi5ZUVF-2Fo-2B6flxo-3DUSpV_g4j7BHlu96plUOfCQsO0yRjoWZCZl8YGnZ-2FUtT39hrDmDz-2FisU4CybMTa4AFdNqjWoDadrImI2uOf58ArG-2FffJ7seqZM-2Bl84or1w-2BzxkvZYcPQITxGrgDJGv16GZTsMIutD2gv437SrvMcUM-2F5l3-2BKCAbVD4eiDR8izGVmzfzthTmQymbENGNMMEUITS2aGvAfi-2BZKEdNWTnMrEIlvUiBQ-3D-3D


--- SBBSecho 3.20-Linux
 * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

.