Subj : New Defects reported by Coverity Scan for Synchronet
To   : cov-scan@synchro.net
From : scan-admin@coverity.com
Date : Fri Apr 14 2023 12:38:41

Hi,

Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

2 new defect(s) introduced to Synchronet found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 452331:  Incorrect expression  (SIZEOF_MISMATCH)
/writemsg.cpp: 936 in sbbs_t::msgeditor(char *, const char *, char *, unsigned int, unsigned int)()


________________________________________________________________________________________________________
*** CID 452331:  Incorrect expression  (SIZEOF_MISMATCH)
/writemsg.cpp: 936 in sbbs_t::msgeditor(char *, const char *, char *, unsigned int, unsigned int)()
930     	}
931
932     	rioctl(IOCM|ABORT);
933     	rioctl(IOCS|ABORT);
934
935     	if((str = strListDivide(NULL, buf, "\n")) == NULL) {
>>>     CID 452331:  Incorrect expression  (SIZEOF_MISMATCH)
>>>     Passing argument "getfname("writemsg.cpp")" of type "char *" and argument "8UL /* sizeof (char *) */ * (maxlines + 1)" to function "errormsg" is suspicious.
936     		errormsg(WHERE,ERR_ALLOC,"msgeditor",sizeof(char *)*(maxlines+1));
937     		return(0);
938     	}
939     	lines = strListCount(str);
940     	while(lines > maxlines)
941     		free(str[--lines]);

** CID 452330:  Control flow issues  (NO_EFFECT)
/writemsg.cpp: 966 in sbbs_t::msgeditor(char *, const char *, char *, unsigned int, unsigned int)()


________________________________________________________________________________________________________
*** CID 452330:  Control flow issues  (NO_EFFECT)
/writemsg.cpp: 966 in sbbs_t::msgeditor(char *, const char *, char *, unsigned int, unsigned int)()
960     		cleartoeol();  /* delete to end of line */
961     		CRLF;
962     	}
963     	sync();
964     	rioctl(IOSM|ABORT);
965     	while(online) {
>>>     CID 452330:  Control flow issues  (NO_EFFECT)
>>>     This less-than-zero comparison of an unsigned value is never true. "line < 0U".
966     		if(line < 0)
967     			line = 0;
968     		if((int)line>(int)maxlines-10) {
969     			if(line >= maxlines)
970     				bprintf(text[NoMoreLines],line);
971     			else


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yp-2FP9gGRhvFklLaQKuBylUrkMFB3WMR2p7qIYKYTZrh4BbWTBf-2B-2Fi5ZUVF-2Fo-2B6flxo-3DXYWj_g4j7BHlu96plUOfCQsO0yRjoWZCZl8YGnZ-2FUtT39hrCe3xJD-2By2cfraguiJlF6Q3ggv-2BQewqXHCAM-2Fbq0fOod1rV0SghwSJAQLLY7JR2Xg22UoJpTPmAA7i9XkIaQJXzZ-2BbJXoY-2BCdAkcnvE60sKg-2BPS6l7v-2FKFZFOwbcriVbnnje-2BbNcxdGeVrvLCQd8h-2BSecIZPgzSL8PiXCCNGI8f5Q-3D-3D


--- SBBSecho 3.20-Linux
 * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

.