Subj : New Defects reported by Coverity Scan for Synchronet
To   : cov-scan@synchro.net
From : scan-admin@coverity.com
Date : Sat Apr 01 2023 12:40:10

Hi,

Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

1 new defect(s) introduced to Synchronet found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 451182:  Null pointer dereferences  (NULL_RETURNS)


________________________________________________________________________________________________________
*** CID 451182:  Null pointer dereferences  (NULL_RETURNS)
/scfg/scfgnode.c: 50 in adjust_last_node()
44     	uint last_node = iniGetUInteger(ini, section, key, cfg.sys_nodes);
45     	char prompt[128];
46     	SAFEPRINTF(prompt, "Update Terminal Server 'LastNode' value to %u", cfg.sys_nodes);
47     	if(last_node < cfg.sys_nodes && uifc.confirm(prompt)) {
48     		fp = iniOpenFile(ini_fname, /* modify */true);
49     		iniSetUInteger(&ini, section, key, cfg.sys_nodes, NULL);
>>>     CID 451182:  Null pointer dereferences  (NULL_RETURNS)
>>>     Dereferencing a pointer that might be "NULL" "fp" when calling "iniWriteFile".
50     		iniWriteFile(fp, ini);
51     		iniCloseFile(fp);
52     	}
53     	iniFreeStringList(ini);
54     }
55


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yp-2FP9gGRhvFklLaQKuBylUrkMFB3WMR2p7qIYKYTZrh4BbWTBf-2B-2Fi5ZUVF-2Fo-2B6flxo-3DpuyQ_g4j7BHlu96plUOfCQsO0yRjoWZCZl8YGnZ-2FUtT39hrAa7nggF92-2FRxsLcvm87CK4-2Bto78Azi3yyX9qWek6JmUtnehJGAtrvzJBvO1d9nD-2Bg0GKKa4GqYzEva6Siznl2xJXy-2FjPn1uZ-2BKvYX68NoiQd5tzVJKUFlPrALUGvlehbzHDUYDbzILFgmSfjOdYWlAKHa0sR-2FUDtT5FufQM-2BrMyA-3D-3D


--- SBBSecho 3.20-Linux
 * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

.