Subj : src/sbbs3/bat_xfer.cpp
To   : Git commit to main/sbbs/master
From : Rob Swindell (in GitKraken)
Date : Thu Mar 02 2023 18:56:50

https://gitlab.synchro.net/main/sbbs/-/commit/5d1d586fd74709f9cd1a9fc3
Modified Files:
	src/sbbs3/bat_xfer.cpp
Log Message:
Better access enforcement to files in batch download queuesIf a file gets added to a batch download queue that a user doesn't have download-access to (at the time of batch download), deal with that gracefully and consistently.start_batch_download():- Now checks current user access to download the file in both single-file and batch modes- Now performs credit-check in single-file mode (wasn't doing so previously)- totalsize of multi-file batch download queue is now calculated again (apparently removed/broken in the new filebase conversion of v3.19), so download ETA should be calculated more accurately (?) again- Use gettimetodl() to calculate each file's download time for multi-file downloads- Using new putnode_download() method to write node downloading "action" and ETA-in-aux fields- The node status wasn't being updated at all before start of download in single-file mode - fixedcreate_batchdn_lst() :- Checks each file still downloadable by the user and if not, removes from the queue (and the generated list file).- Performs credit check and removes files that exceed available user credit- returns true only when 1 or more files is added to the batch download list fileaddtobatdl()- Removed redundant 'D' restriction check - this is handled by can_user_download() check already.- Use the 'reason' out parameter from can_user_download() to determine which error string to display (not always CantDownloadFromDir).
--- SBBSecho 3.20-Linux
 * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

.