Subj : New Defects reported by Coverity Scan for Synchronet
To   : cov-scan@synchro.net
From : scan-admin@coverity.com
Date : Mon Feb 13 2023 13:37:11

Hi,

Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

1 new defect(s) introduced to Synchronet found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 436064:  Error handling issues  (CHECKED_RETURN)
/scfg/scfg.c: 2266 in bail()


________________________________________________________________________________________________________
*** CID 436064:  Error handling issues  (CHECKED_RETURN)
/scfg/scfg.c: 2266 in bail()
2260         if(code) {
2261     		printf("\nHit enter to continue...");
2262     		(void)getchar();
2263     	}
2264         else if(forcesave) {
2265             load_main_cfg(&cfg, error, sizeof(error));
>>>     CID 436064:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "load_msgs_cfg" without checking return value (as is done elsewhere 4 out of 5 times).
2266             load_msgs_cfg(&cfg, error, sizeof(error));
2267             load_file_cfg(&cfg, error, sizeof(error));
2268             load_chat_cfg(&cfg, error, sizeof(error));
2269             load_xtrn_cfg(&cfg, error, sizeof(error));
2270     		cfg.new_install=new_install;
2271             save_main_cfg(&cfg,backup_level);


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yp-2FP9gGRhvFklLaQKuBylUrkMFB3WMR2p7qIYKYTZrh4BbWTBf-2B-2Fi5ZUVF-2Fo-2B6flxo-3DD5MO_g4j7BHlu96plUOfCQsO0yRjoWZCZl8YGnZ-2FUtT39hrDTaDtSmOw-2Bk-2F2GY9-2Fd2mdj1kV98qMuZQMWgSaq-2FKJTpW1JmDNOWTqgrbhAT5Uu1FeAUx9pihjmNzRCgsVATSDaJVNi1-2Fy70syPCKRY-2FmYivvscQV3ejVXXYul1-2BVLFI3iZ6Tr68ZR3M-2FuWbVS2FOTtToDy4GMZVGnWexi0ASRqfA-3D-3D


--- SBBSecho 3.20-Linux
 * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

.