Subj : New Defects reported by Coverity Scan for Synchronet
To   : cov-scan@synchro.net
From : scan-admin@coverity.com
Date : Tue Jan 24 2023 13:36:42

Hi,

Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

2 new defect(s) introduced to Synchronet found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 434885:  Null pointer dereferences  (FORWARD_NULL)
/services.c: 720 in js_client_update()


________________________________________________________________________________________________________
*** CID 434885:  Null pointer dereferences  (FORWARD_NULL)
/services.c: 720 in js_client_update()
714     		inet_addrtop(&addr, client.addr, sizeof(client.addr));
715     		client.port=inet_addrport(&addr);
716     	}
717
718     	if(argc>1) {
719     		JSVALUE_TO_MSTRING(cx, argv[1], cstr, NULL);
>>>     CID 434885:  Null pointer dereferences  (FORWARD_NULL)
>>>     Passing null pointer "cstr" to "strncpy", which dereferences it.
720     		SAFECOPY(client.user, cstr);
721     	}
722
723     	if(argc>2)
724     		JSVALUE_TO_STRBUF(cx, argv[2], client.host, sizeof(client.host), NULL);
725

** CID 434884:  Null pointer dereferences  (FORWARD_NULL)
/services.c: 666 in js_client_add()


________________________________________________________________________________________________________
*** CID 434884:  Null pointer dereferences  (FORWARD_NULL)
/services.c: 666 in js_client_add()
660     		client.port=inet_addrport(&addr);
661     	}
662
663     	if(argc>1) {
664     		JSVALUE_TO_MSTRING(cx, argv[1], cstr, NULL);
665     		HANDLE_PENDING(cx, cstr);
>>>     CID 434884:  Null pointer dereferences  (FORWARD_NULL)
>>>     Passing null pointer "cstr" to "strncpy", which dereferences it.
666     		SAFECOPY(client.user, cstr);
667     	}
668
669     	if(argc>2)
670     		JSVALUE_TO_STRBUF(cx, argv[2], client.host, sizeof(client.host), NULL);
671


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yp-2FP9gGRhvFklLaQKuBylUrkMFB3WMR2p7qIYKYTZrh4BbWTBf-2B-2Fi5ZUVF-2Fo-2B6flxo-3DvLhJ_g4j7BHlu96plUOfCQsO0yRjoWZCZl8YGnZ-2FUtT39hrBNa4gwWWzuH4YpejndlE5gsky18iXCI4AkB01pepljfQqe7LF9jGy-2FPzogJNdd8GOgQ3TnLbTyrrZZkhw2xvoNM46EZwpq7pxgwtgEEnxcRLT7VMF9VB0-2Ff-2B2KirIMbgwvbghsG43LiLS-2FF-2BCh68FdiTiQ6aMChynPzZbnhEv4cw-3D-3D


--- SBBSecho 3.20-Linux
 * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

.