Subj : New Defects reported by Coverity Scan for Synchronet
To   : cov-scan@synchro.net
From : scan-admin@coverity.com
Date : Wed Mar 23 2022 23:05:35

Hi,

Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

3 new defect(s) introduced to Synchronet found with Coverity Scan.
5 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)


** CID 350813:  Error handling issues  (CHECKED_RETURN)
/js_system.c: 373 in js_system_set()


________________________________________________________________________________________________________
*** CID 350813:  Error handling issues  (CHECKED_RETURN)
/js_system.c: 373 in js_system_set()
367         JS_IdToValue(cx, id, &idval);
368         tiny = JSVAL_TO_INT(idval);
369
370     #ifndef JSDOOR
371     	switch(tiny) {
372     		case SYS_PROP_MISC:
>>>     CID 350813:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "JS_ValueToECMAUint32" without checking return value (as is done elsewhere 68 out of 71 times).
373     			JS_ValueToECMAUint32(cx, *vp, (uint32_t*)&sys->cfg->sys_misc);
374     			break;
375     		case SYS_PROP_OP_AVAIL:
376     			if(!set_sysop_availability(sys->cfg, JSVAL_TO_BOOLEAN(*vp))) {
377     				JS_ReportError(cx, "%s: Failed to set sysop availability", __FUNCTION__);
378     				return JS_FALSE;

** CID 350812:  Error handling issues  (CHECKED_RETURN)
/js_system.c: 1198 in js_secondstr()


________________________________________________________________________________________________________
*** CID 350812:  Error handling issues  (CHECKED_RETURN)
/js_system.c: 1198 in js_secondstr()
1192     		return JS_FALSE;
1193
1194     	if(JSVAL_NULL_OR_VOID(argv[0])) {
1195     		JS_ReportError(cx, "Invalid argument");
1196     		return JS_FALSE;
1197     	}
>>>     CID 350812:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "JS_ValueToECMAUint32" without checking return value (as is done elsewhere 68 out of 71 times).
1198     	JS_ValueToECMAUint32(cx,argv[0],&t);
1199     	sectostr(t,str);
1200     	if((js_str = JS_NewStringCopyZ(cx, str))==NULL)
1201     		return(JS_FALSE);
1202
1203     	JS_SET_RVAL(cx, arglist, STRING_TO_JSVAL(js_str));

** CID 350811:  Error handling issues  (CHECKED_RETURN)
/js_system.c: 1171 in js_datestr()


________________________________________________________________________________________________________
*** CID 350811:  Error handling issues  (CHECKED_RETURN)
/js_system.c: 1171 in js_datestr()
1165     	else {
1166     		if(JSVAL_IS_STRING(argv[0])) {	/* convert from string to time_t? */
1167     			JSVALUE_TO_ASTRING(cx, argv[0], p, 10, NULL);
1168     			JS_SET_RVAL(cx, arglist, DOUBLE_TO_JSVAL((double)dstrtounix(sys->cfg, p)));
1169     			return(JS_TRUE);
1170     		}
>>>     CID 350811:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "JS_ValueToECMAUint32" without checking return value (as is done elsewhere 68 out of 71 times).
1171     		JS_ValueToECMAUint32(cx,argv[0],(uint32_t*)&t);
1172     	}
1173     	unixtodstr(sys->cfg,t,str);
1174     	if((js_str = JS_NewStringCopyZ(cx, str))==NULL)
1175     		return(JS_FALSE);
1176


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yp-2FP9gGRhvFklLaQKuBylUrkMFB3WMR2p7qIYKYTZrh4BbWTBf-2B-2Fi5ZUVF-2Fo-2B6flxo-3DO-T-_g4j7BHlu96plUOfCQsO0yRjoWZCZl8YGnZ-2FUtT39hrD5lmQkwtzbpuckFzICuBb-2BrzHxNzOQGFWU1wii6NtUwUINnM1SD13bgyTn-2F0F7qCyOVMOWvJkz8JpmgGX7IMstkqknb7-2FOCJJ4b-2BForC6hd6cNSyW5oO2x4Mpuy8QqNdzyI5-2FKFN3KrApvvfnbJilV7OSnsAMQKp00hkOCYfuisA-3D-3D


--- SBBSecho 3.15-Linux
 * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

.