Subj : New Defects reported by Coverity Scan for Synchronet
To   : cov-scan@synchro.net
From : scan-admin@coverity.com
Date : Thu Jan 13 2022 13:54:43

Hi,

Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

1 new defect(s) introduced to Synchronet found with Coverity Scan.
3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 345291:    (NULL_RETURNS)
/filedat.c: 202 in loadfiles()
/filedat.c: 202 in loadfiles()


________________________________________________________________________________________________________
*** CID 345291:    (NULL_RETURNS)
/filedat.c: 202 in loadfiles()
196     		if(len >= 12 && strcspn(filespec, "*?") == len) {
197     			SAFECOPY(newfilespec, filespec);
198     			char* ext = getfext(newfilespec);
199     			if(ext != NULL) {
200     				*ext = 0;
201     				SAFECAT(newfilespec, "*");
>>>     CID 345291:    (NULL_RETURNS)
>>>     Dereferencing a pointer that might be "NULL" "(char *)getfext(filespec)" when calling "strcat". [Note: The source code implementation of the function has been overridden by a builtin model.]
202     				SAFECAT(newfilespec, getfext(filespec));
203     			} else
204     				SAFECAT(newfilespec, "*");
205     			filespec = newfilespec;
206     		}
207     	}
/filedat.c: 202 in loadfiles()
196     		if(len >= 12 && strcspn(filespec, "*?") == len) {
197     			SAFECOPY(newfilespec, filespec);
198     			char* ext = getfext(newfilespec);
199     			if(ext != NULL) {
200     				*ext = 0;
201     				SAFECAT(newfilespec, "*");
>>>     CID 345291:    (NULL_RETURNS)
>>>     Dereferencing a pointer that might be "NULL" "(char *)getfext(filespec)" when calling "strlen".
202     				SAFECAT(newfilespec, getfext(filespec));
203     			} else
204     				SAFECAT(newfilespec, "*");
205     			filespec = newfilespec;
206     		}
207     	}


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yp-2FP9gGRhvFklLaQKuBylUrkMFB3WMR2p7qIYKYTZrh4BbWTBf-2B-2Fi5ZUVF-2Fo-2B6flxo-3DGrV8_g4j7BHlu96plUOfCQsO0yRjoWZCZl8YGnZ-2FUtT39hrDQ-2FZ3IDp0hl0aRs9c3bbZXR09ibAartchzkQRercYp5MpY4M-2FdOLgJu6uM6PF55LOtRkX8GlziQeO71zu92tsVW15fOTPs2xwdwlZEvBvJx7pNfugWTmYp-2FS9RCHU-2BZOe0GsRl57chmm32I25QaJ2KWFRKONC-2BSAufsS-2FWKTiYEw-3D-3D


--- SBBSecho 3.14-Linux
 * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

.