Subj : New Defects reported by Coverity Scan for Synchronet
To   : cov-scan@synchro.net
From : scan-admin@coverity.com
Date : Wed Jun 09 2021 12:51:42

Hi,

Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

1 new defect(s) introduced to Synchronet found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 332219:  Control flow issues  (DEADCODE)
/main.cpp: 3967 in sbbs_t::mv(char *, char *, char)()


________________________________________________________________________________________________________
*** CID 332219:  Control flow issues  (DEADCODE)
/main.cpp: 3967 in sbbs_t::mv(char *, char *, char)()
3961             return(0);
3962     	}
3963     	if(!CopyFile(src, dest, /* fail if exists: */true)) {
3964     		errormsg(WHERE, "CopyFile", src, 0, dest);
3965     		return -1;
3966     	}
>>>     CID 332219:  Control flow issues  (DEADCODE)
>>>     Execution cannot reach the expression "remove(src)" inside this statement: "if (!copy && remove(src)) {...".
3967         if(!copy && remove(src)) {
3968             errormsg(WHERE,ERR_REMOVE,src,0);
3969             return(-1);
3970     	}
3971         return(0);
3972     }


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yp-2FP9gGRhvFklLaQKuBylUrkMFB3WMR2p7qIYKYTZrh4BbWTBf-2B-2Fi5ZUVF-2Fo-2B6flxo-3DJdo4_g4j7BHlu96plUOfCQsO0yRjoWZCZl8YGnZ-2FUtT39hrBBE-2FJI6YRBGypMFdZyXJVPIIKFhPXAf9fo0B5GFPQPQdxfwppj17qbrv2rQ91AdPP2cTE9QcemUMjgHq9UbxjwGOEeJcfWha2Khj7ZkXm1XJ6qsCyNN9GvL6wK0Sq5moa97ehIK5r3sho6efye8-2Bw4BIB4GC8aWGIYT-2BPvwz6ygw-3D-3D


--- SBBSecho 3.14-Linux
 * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

.