Subj : New Defects reported by Coverity Scan for Synchronet
To   : cov-scan@synchro.net
From : scan-admin@coverity.com
Date : Tue May 04 2021 12:49:23

Hi,

Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

2 new defect(s) introduced to Synchronet found with Coverity Scan.
2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 331353:  Resource leaks  (RESOURCE_LEAK)
/tmp/sbbs-May-04-2021/src/xpdev/ini_file.c: 465 in iniSortSections()


________________________________________________________________________________________________________
*** CID 331353:  Resource leaks  (RESOURCE_LEAK)
/tmp/sbbs-May-04-2021/src/xpdev/ini_file.c: 465 in iniSortSections()
459
460     	if(section_list != NULL)
461     		strListSortAlphaCase(section_list);
462     	new_list = strListInit();
463     	if(new_list == NULL) {
464     		strListFree(&section_list);
>>>     CID 331353:  Resource leaks  (RESOURCE_LEAK)
>>>     Variable "root_keys" going out of scope leaks the storage it points to.
465     		return FALSE;
466     	}
467     	strListAppendList(&new_list, root_keys);
468     	strListFree(&root_keys);
469     	for(i = 0; section_list != NULL && section_list[i] != NULL; i++) {
470     		keys = iniGetSection(*list, section_list[i]);

** CID 331352:  Memory - illegal accesses  (UNINIT)


________________________________________________________________________________________________________
*** CID 331352:  Memory - illegal accesses  (UNINIT)
/sbbs_ini.c: 784 in sbbs_write_ini()
778     	style.bit_separator = " | ";
779
780     	if((list=iniReadFile(fp))==NULL)
781     		return(FALSE);
782
783     	if(global==NULL) {
>>>     CID 331352:  Memory - illegal accesses  (UNINIT)
>>>     Using uninitialized value "global_buf.interfaces" when calling "get_ini_globals".
784     		get_ini_globals(list, &global_buf);
785     		global = &global_buf;
786     	}
787
788     	lp=&list;
789


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yp-2FP9gGRhvFklLaQKuBylUrkMFB3WMR2p7qIYKYTZrh4BbWTBf-2B-2Fi5ZUVF-2Fo-2B6flxo-3DEfUX_g4j7BHlu96plUOfCQsO0yRjoWZCZl8YGnZ-2FUtT39hrA28P387pFw9dgMRK70ZINT9B2FTFVmBIa9VpDPasp9BGRK3Mxaew-2B-2FY0FckgfhdhtFs7aK2mHpCTVSJ2oVHN-2FOUDW-2BjcCmL8CjODBVap2DhWI4tO8Z8n7TcakajD-2FVcNwFQ1gQUvZC41Hwc-2BhpJjh3SC5lYhtMgbEybex-2FmwcP2Q-3D-3D


--- SBBSecho 3.14-Linux
 * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

.