Subj : feature request
To   : Michiel van der Vlist
From : Andrew Leary
Date : Thu Oct 02 2014 14:10:42

Hello Michiel!

Wednesday October 01 2014 18:01, Michiel van der Vlist wrote to Kees van Eeten:

 KE>>  Should makenl_ng flag spaces in a node line as errors?

 MvdV> Definitely! According to FTS-5000 it IS an error.

Agreed.

 KE>> Should makenl_ng remove these spaces,

 MvdV> Or replace them with an underscore?

 KE>> probably a nono, as makenl should not apply automatic editing of
 KE>> nodelist lines..

 MvdV> Replacing with an underscore will most likely give the desired result
 MvdV> in the name fields. removing spaces will most likely result in line
 MvdV> that parses. Or it may produce another error.

 MvdV> Perhaps it is better to let a human judge. But it definitely should be
 MvdV> flagged as an error!

I just dug through the code.  Currently leading or trailing spaces in the first 
7 fields (keyword, number, name, location, sysop, telephone, baudrate) of a 
nodelist line will be removed.  The issue here is an incorrect entry with a 
space embedded in the flags field.  MakeNL has never done error checking on the 
flags, which is why ERRFLAGS was developed in the first place.  I suppose I 
could add basic error checking of the flags (probably limited to flagging 
illegal characters such as spaces.)  Anything more extensive would probably 
involve rewriting ERRFLAGS in C and merging it with MakeNL.  That is a project 
that would require extensive amounts of time to code, test, and debug.  Given 
that some of the current ZCs refuse to use ERRFLAGS, I don't imagine they would 
want to have the equivalent added to MakeNL.

Regards,

Andrew

---
 * Origin: Bits & Bytes BBS * V.Everything! * 860/535-4284 (1:320/119)

.