Subj : BinkleyForce IPv6 patch
To   : Andre Grueneberg
From : Konstantin Kuzov
Date : Mon Jan 23 2012 17:35:04

Konnichi wa, *Andre-kun*! Aogu manako oyobi uketamawaru waga koe!
Tomodachi _Andre Grueneberg_ tsukuru airon _Konstantin Kuzov_
Nichiji - /*23 Ÿ­¢ 12 09:42*/, Daizai - /*BinkleyForce IPv6 patch*/:

 >> There is a small patch for binkleyforce 0.22.9-v for systems with
 >> IPv6 support (getaddrinfo/getnameinfo). Not tested much but looks
 >> like all works fine.
 >> http://fido.g0x.ru/gpl/fido/ftnsoft/mailer/bforce/bforce-0.22.9-v-ip
 >> v6 .patch So, my node is fully IPv6 capable now. ^_^

 AG> There are a few glitches in the patch:

 AG> 1)
 AG> +        DEB((D_INFO, "tcpip_connect: trying \"%s\" at port %d",
 AG> hostbuf, servbuf));
 AG> ... servbuf is a string ... so you should replace %d with %s. [Made
 AG> the same mistake myself a few times ;)]

Fixed. ^_^

 AG> 2)
 AG> You should be cautious with how you determine the port (strrchr(host,
 AG> ':')) ... this will fail for literal IPv6 addresses.

Yeah, I know port was required for literal ipv6 addresses to work. Now It is not, but square brackets enclosing required instead. ^_^

By the way, your qico patch have similar issue:
    if (( portname = strchr( proxy ? proxy : name, ':' ))) {

 AG> 3)
 AG> +        state.peerport = (long)htons(((struct sockaddr_in
 AG> *)&client)->sin_port);
 AG> ... is by far not protocol independent. You should either use
 AG> getnameinfo(..., NI_NUMERICSERV) or build some protocol dependent
 AG> code.

Improved.

 AG> BinkForce doesn't do own incoming session handling?!

Nope, only in slave mode through inetd.

Ganbatte, *Andre*!

[_N0SF3R@TU_]
.... GoldED-NSF/LNX 1.1.5-20101212 (Linux 3.2.1-gentoo iF6M42)
--- #[ICQ: 211191411] [Kaori Sekken: Master.NoSFeRaTU[@]Gmail.com] [Kumi Nyaa]#
 * Origin: Ojisan, oriru mottekuru suna oyobi korosu sagaru kabe (2:5019/40.1)

.