Subj : BinkleyForce IPv6 patch
To   : Konstantin Kuzov
From : Andre Grueneberg
Date : Mon Jan 23 2012 09:42:24

Hi Konstantin

Konstantin Kuzov schrieb:

> There is a small patch for binkleyforce 0.22.9-v for systems with IPv6
> support (getaddrinfo/getnameinfo). Not tested much but looks like all
> works fine. 
> http://fido.g0x.ru/gpl/fido/ftnsoft/mailer/bforce/bforce-0.22.9-v-ipv6
> .patch 
> So, my node is fully IPv6 capable now. ^_^

There are a few glitches in the patch:

1)
+        DEB((D_INFO, "tcpip_connect: trying \"%s\" at port %d", hostbuf, servbuf));

.... servbuf is a string ... so you should replace %d with %s. [Made the same mistake myself a few times ;)]

2)
You should be cautious with how you determine the port (strrchr(host, ':')) ... this will fail for literal IPv6 addresses.

3)
+        state.peerport = (long)htons(((struct sockaddr_in *)&client)->sin_port);
.... is by far not protocol independent. You should either use getnameinfo(..., NI_NUMERICSERV) or build some protocol dependent code.

BinkForce doesn't do own incoming session handling?!

CU Andre               E-Mail: andre@grueneberg.de 
--- timEd/Linux 1.11.b5
 * Origin: Testing timed/Linux (2:2411/525)

.