Subj : Re: dupes
To   : Wilfred van Velzen
From : Markus Reschke
Date : Mon Sep 24 2018 13:36:58

* Forwarded from FTSC_PUBLIC by Markus Reschke (2:240/1661).
* Originally by: Markus Reschke (2:240/1661), 15 Nov 2013 23:31.
* Originally to: Wilfred van Velzen (2:240/1661).

---------- Forwarded message ----------
Hello Wilfred!

Nov 15 11:02 2013, Markus Reschke wrote to Wilfred van Velzen:

I had a quick view at the source

 MR> There's a lot more to add or fix. AddToSeen works globally only, you 
 MR> can't set it for just a few echos and clear it. Haven't checked 
 MR> IgnoreSeen but I assume it's the same. For the stripping problem 

With -sbadd and -sbign I can set both individually for each echo. Great!

 MR> something like KeepSeen would be great, i.e. any SEEN-BY matching 
 MR> KeepSeen would stay in the mail. Also a KeepAllSeen switch to keep 
 MR> all SEEN-BYs when zonegating and a StripSeen to strip specific 
 MR> SEEN-BYs. With those features you should be able fix any echomail 
 MR> routing problem.

The interesting functions are forwardMsgToLinks() and forwardToLinks() in 
toss.c.

I think we should move this thread to FIDOSOFT.HUSKY.

---------------------------------------

Ok, the KeepAllSeen switch is very simple to implement in forwardMsgToLinks(). 
We have just to decide if we like a global or echo-specific switch. Let's 
assume we've added an echo specific switch to fidoconf.

Currently:

    if (zoneLinks) {
        if (echo->useAka->zone != pktOrigAddr.zone) seenByCount = 0;
        forwardToLinks(msg, echo, zoneLinks, &seenBys, &seenByCount, &path, 
&pathCount);
    }

That could be changed to:

   if (zoneLinks) {
        if ((!echo->keepAllSeen) && (echo->useAka->zone != pktOrigAddr.zone)) 
seenByCount = 0;
        forwardToLinks(msg, echo, zoneLinks, &seenBys, &seenByCount, &path,    
&pathCount);
   }


The KeepSeen and StripSeen features could be added also in forwardToLinks() 
but require own processing functions. Those functions would simply build a new 
seen-by list and discard the old one, nothing fancy :-)

So the question is: Are there any more hpt user wishing to have following 
features (per erea):
- StripSeen to remove specific SEEN-BYs
- KeepSeen to keep specific SEEN-BYs when zonegating
- KeepAllSeen to keep all SEEN-BYs when zonegating

Regards,
Markus

--- 
 * Origin: *** theca tabellaria *** (2:240/1661)

.