Subj : loglevels
To   : Tommi Koivula
From : andrew clarke
Date : Sat Feb 27 2021 22:50:18

On 2021-02-27 08:48:54, Tommi Koivula (2:221/360) wrote to All:

 TK> I installed openwatcom 2.0 for OS/2. Compiled, and hpt seems to run
 TK> fine. Thanks Andrew! :)

You're welcome. :)

 TK> I turned on logging "1" and now the log is full of "scanning area"
 TK> lines starting with "1".

 TK> Is this ok? According to the docs :

 TK> 1 - Program start, end;
 TK> 4 - scanning messages

 TK> === Cut ===
 TK> ----------  Sat 27 Feb 2021, hpt/os2-wc 1.9.0-cur 2021-02-17
 TK> 1 08:46:51  Start
 TK> 1 08:46:51  Start scanning...
 TK> 1 08:46:51  EchoTossLogFile not found -> Scanning all areas
 TK> 1 08:46:51  Scanning area: r20_kontroll
 TK> 1 08:46:51  Scanning area: r20_test
 TK> 1 08:46:51  Scanning area: r20_admin

$ cd hpt/src
$ grep "Scanning area" *.c
scanarea.c:       w_log(LL_START, "Scanning area: %s", echo->areaName);
toss.c: w_log(LL_START, "Scanning area: %s", config->badArea.areaName);

At first glance this a bug, and "LL_START" should be "LL_SCANNING".

Though looking deeper, these aren't the only places where LL_START looks to be used erroneously.

So I'd like a second opinion...

--- GoldED+/BSD 1.1.5-b20180707
 * Origin: Blizzard of Ozz, Melbourne, Victoria, Australia (3:633/267)

.